[bug#72396] [PATCH 0/2] gnu: Add zydis.

[bug#72396] [PATCH 0/2] gnu: Add zydis.

[guix-patches--- via]

Zydis is a library for x86 and amd64 disassembly and decoding.
My goal is to package E9Patch (amd64 binary patching tool)
which depends on it but upstream needs a bit of clean up.

Nguyễn Gia Phong (2):
  gnu: Add zycore.
  gnu: Add zydis.

 gnu/packages/engineering.scm | 55 ++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)


base-commit: f59c4126827af3d2041d49f1d0a8ce12b41470cf
-- 
2.45.2

[bug#72396] [PATCH 1/2] gnu: Add zycore.

[guix-patches--- via]

* gnu/packages/engineering.scm (zycore): New variable.

Change-Id: Ia38413f43bc667a9a12916d3f0e786e06f6d358f
---
 gnu/packages/engineering.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index f411d4ac1ed6..b6ae19101b42 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -40,6 +40,7 @@
 ;;; Copyright © 2023 Sharlatan Hellseher <sharlatanus@gmail.com>
 ;;; Copyright © 2023 pinoaffe <pinoaffe@gmail.com>
 ;;; Copyright © 2024 Juliana Sims <juli@incana.org>
+;;; Copyright © 2024 Nguyễn Gia Phong <mcsinyx@disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1926,6 +1927,29 @@ (define-public radare2
 it suitable for security research and analysis.")
     (license license:lgpl3)))
 
+(define-public zycore
+  (package
+    (name "zycore")
+    (version "1.5.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/zyantific/zycore-c")
+                    (commit (string-append "v" version))))
+              (sha256
+               (base32 "0s962pkqybh1xbs75y4jb4bqc9qnq0sviqd570mirqdhhq87agib"))
+              (file-name (git-file-name name version))))
+    (build-system cmake-build-system)
+    (native-inputs (list googletest))
+    (arguments `(#:configure-flags '("-DZYCORE_BUILD_SHARED_LIBS=ON"
+                                     "-DZYCORE_BUILD_TESTS=ON")))
+    (home-page "https://github.com/zyantific/zycore-c")
+    (synopsis "Internal library for Zydis.")
+    (description
+     "This package provides platfrom-independent types, macros
+and a fallback for environments without libc for Zydis.")
+    (license license:expat)))
+
 (define-public asco
   (package
     (name "asco")
-- 
2.45.2

[bug#72396] [PATCH 2/2] gnu: Add zydis.

[guix-patches--- via]

* gnu/packages/engineering.scm (zydis): New variable.

Change-Id: I6e0b04e1d957f8c172e81177f6669415beeaf20a
---
 gnu/packages/engineering.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index b6ae19101b42..4eb0e6cb6b9a 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -1950,6 +1950,37 @@ (define-public zycore
 and a fallback for environments without libc for Zydis.")
     (license license:expat)))
 
+(define-public zydis
+  (package
+    (name "zydis")
+    (version "4.1.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/zyantific/zydis")
+                    (commit (string-append "v" version))))
+              (sha256
+               (base32 "15iw6wcg2van8pw54xs15zk5cniqm8d8vbd1w1br9azv8jxsqjva"))
+              (file-name (git-file-name name version))))
+    (build-system cmake-build-system)
+    (arguments `(#:configure-flags '("-DZYAN_SYSTEM_ZYCORE=ON"
+                                     "-DZYDIS_BUILD_SHARED_LIB=ON"
+                                     "-DZYDIS_BUILD_MAN=ON")))
+    (native-inputs (list python ronn-ng))
+    (inputs (list zycore))
+    (home-page "https://zydis.re")
+    (synopsis "Disassembler and code generation library for x86 and AMD64")
+    (description
+     "Zydis is a decoder and disassembler library with the following features:
+@itemize
+@item Support for all x86 and AMD64 instructions and extensions
+@item Optimization for high performance
+@item No dynamic memory allocation
+@item Thread-safe by design
+@item Smaller file-size overhead compared to other common disassembler libraries
+@end itemize")
+    (license license:expat)))
+
 (define-public asco
   (package
     (name "asco")
-- 
2.45.2

[bug#72396] [PATCH 1/2] gnu: Add zycore.

[Nicolas Graves via Guix-patches via]

On 2024-07-31 19:14, guix-patches--- via wrote:

> * gnu/packages/engineering.scm (zycore): New variable.
>
> +    (synopsis "Internal library for Zydis.")

Hi Nguyễn Gia Phong,

A minor nitpick:
zycore@1.5.0: no period allowed at the end of the synopsis

Checking `guix lint` would have told you ;)

Otherwise LGTM, built and rebuilt deterministically.

-- 
Best regards,
Nicolas Graves

[bug#72396] [PATCH v2 1/2] gnu: Add zycore.

[guix-patches--- via]

* gnu/packages/engineering.scm (zycore): New variable.

Change-Id: Ia38413f43bc667a9a12916d3f0e786e06f6d358f
---
On 2024-08-15 at 16:19+02:00, Nicolas Graves wrote:
> On 2024-07-31 19:14, Nguyễn Gia Phong via wrote:
>
> > * gnu/packages/engineering.scm (zycore): New variable.
> >
> > +    (synopsis "Internal library for Zydis.")
> A minor nitpick:
> zycore@1.5.0: no period allowed at the end of the synopsis
>
> Checking `guix lint` would have told you ;)
>
> Otherwise LGTM, built and rebuilt deterministically.

Thanks, this revision fixes that.

I cannot get guix lint to tell that to me however
(I ran `./pre-inst-env guix lint zycore`).

 gnu/packages/engineering.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 7a9c0bc436f7..24dc4f0197c7 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -40,6 +40,7 @@
 ;;; Copyright © 2023 Sharlatan Hellseher <sharlatanus@gmail.com>
 ;;; Copyright © 2023 pinoaffe <pinoaffe@gmail.com>
 ;;; Copyright © 2024 Juliana Sims <juli@incana.org>
+;;; Copyright © 2024 Nguyễn Gia Phong <mcsinyx@disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1927,6 +1928,29 @@ (define-public radare2
 it suitable for security research and analysis.")
     (license license:lgpl3)))
 
+(define-public zycore
+  (package
+    (name "zycore")
+    (version "1.5.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/zyantific/zycore-c")
+                    (commit (string-append "v" version))))
+              (sha256
+               (base32 "0s962pkqybh1xbs75y4jb4bqc9qnq0sviqd570mirqdhhq87agib"))
+              (file-name (git-file-name name version))))
+    (build-system cmake-build-system)
+    (native-inputs (list googletest))
+    (arguments `(#:configure-flags '("-DZYCORE_BUILD_SHARED_LIBS=ON"
+                                     "-DZYCORE_BUILD_TESTS=ON")))
+    (home-page "https://github.com/zyantific/zycore-c")
+    (synopsis "Internal library for Zydis")
+    (description
+     "This package provides platfrom-independent types, macros
+and a fallback for environments without libc for Zydis.")
+    (license license:expat)))
+
 (define-public asco
   (package
     (name "asco")

base-commit: 41c44ffd5659d13f5c1edb78d92ad27275ead78a
-- 
2.45.2

[bug#72396] [PATCH v2 2/2] gnu: Add zydis.

[guix-patches--- via]

* gnu/packages/engineering.scm (zydis): New variable.

Change-Id: I6e0b04e1d957f8c172e81177f6669415beeaf20a
---
This patch is identical to the one in v1.

 gnu/packages/engineering.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 24dc4f0197c7..fba30809e18b 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -1951,6 +1951,37 @@ (define-public zycore
 and a fallback for environments without libc for Zydis.")
     (license license:expat)))
 
+(define-public zydis
+  (package
+    (name "zydis")
+    (version "4.1.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/zyantific/zydis")
+                    (commit (string-append "v" version))))
+              (sha256
+               (base32 "15iw6wcg2van8pw54xs15zk5cniqm8d8vbd1w1br9azv8jxsqjva"))
+              (file-name (git-file-name name version))))
+    (build-system cmake-build-system)
+    (arguments `(#:configure-flags '("-DZYAN_SYSTEM_ZYCORE=ON"
+                                     "-DZYDIS_BUILD_SHARED_LIB=ON"
+                                     "-DZYDIS_BUILD_MAN=ON")))
+    (native-inputs (list python ronn-ng))
+    (inputs (list zycore))
+    (home-page "https://zydis.re")
+    (synopsis "Disassembler and code generation library for x86 and AMD64")
+    (description
+     "Zydis is a decoder and disassembler library with the following features:
+@itemize
+@item Support for all x86 and AMD64 instructions and extensions
+@item Optimization for high performance
+@item No dynamic memory allocation
+@item Thread-safe by design
+@item Smaller file-size overhead compared to other common disassembler libraries
+@end itemize")
+    (license license:expat)))
+
 (define-public asco
   (package
     (name "asco")
-- 
2.45.2

bug#72396: [PATCH v2 1/2] gnu: Add zycore.

[Zheng Junjie]

[-- Attachment #1: Type: text/plain, Size: 2864 bytes --]

guix-patches--- via <guix-patches@gnu.org> writes:

> * gnu/packages/engineering.scm (zycore): New variable.
>
> Change-Id: Ia38413f43bc667a9a12916d3f0e786e06f6d358f
> ---
> On 2024-08-15 at 16:19+02:00, Nicolas Graves wrote:
>> On 2024-07-31 19:14, Nguyễn Gia Phong via wrote:
>>
>> > * gnu/packages/engineering.scm (zycore): New variable.
>> >
>> > +    (synopsis "Internal library for Zydis.")
>> A minor nitpick:
>> zycore@1.5.0: no period allowed at the end of the synopsis
>>
>> Checking `guix lint` would have told you ;)
>>
>> Otherwise LGTM, built and rebuilt deterministically.
>
> Thanks, this revision fixes that.
>
> I cannot get guix lint to tell that to me however
> (I ran `./pre-inst-env guix lint zycore`).
>
>  gnu/packages/engineering.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index 7a9c0bc436f7..24dc4f0197c7 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -40,6 +40,7 @@
>  ;;; Copyright © 2023 Sharlatan Hellseher <sharlatanus@gmail.com>
>  ;;; Copyright © 2023 pinoaffe <pinoaffe@gmail.com>
>  ;;; Copyright © 2024 Juliana Sims <juli@incana.org>
> +;;; Copyright © 2024 Nguyễn Gia Phong <mcsinyx@disroot.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1927,6 +1928,29 @@ (define-public radare2
>  it suitable for security research and analysis.")
>      (license license:lgpl3)))
>  
> +(define-public zycore
> +  (package
> +    (name "zycore")
> +    (version "1.5.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/zyantific/zycore-c")
> +                    (commit (string-append "v" version))))
> +              (sha256
> +               (base32 "0s962pkqybh1xbs75y4jb4bqc9qnq0sviqd570mirqdhhq87agib"))
> +              (file-name (git-file-name name version))))

i move file-name before sha256.

> +    (build-system cmake-build-system)
> +    (native-inputs (list googletest))
> +    (arguments `(#:configure-flags '("-DZYCORE_BUILD_SHARED_LIBS=ON"
                                        is ZYCORE_BUILD_SHARED_LIB                    
> +                                     "-DZYCORE_BUILD_TESTS=ON")))
 
i adjust to use gexp, and disable ZYCORE_BUILD_TESTS on cross-compilation.

> +    (home-page "https://github.com/zyantific/zycore-c")
> +    (synopsis "Internal library for Zydis")
> +    (description
> +     "This package provides platfrom-independent types, macros
> +and a fallback for environments without libc for Zydis.")
> +    (license license:expat)))
> +
>  (define-public asco
>    (package
>      (name "asco")
>
> base-commit: 41c44ffd5659d13f5c1edb78d92ad27275ead78a

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#72396] [PATCH v2 2/2] gnu: Add zydis.

[Zheng Junjie]

[-- Attachment #1: Type: text/plain, Size: 2165 bytes --]

guix-patches--- via <guix-patches@gnu.org> writes:

> * gnu/packages/engineering.scm (zydis): New variable.
>
> Change-Id: I6e0b04e1d957f8c172e81177f6669415beeaf20a
> ---
> This patch is identical to the one in v1.
>
>  gnu/packages/engineering.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index 24dc4f0197c7..fba30809e18b 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -1951,6 +1951,37 @@ (define-public zycore
>  and a fallback for environments without libc for Zydis.")
>      (license license:expat)))
>  
> +(define-public zydis
> +  (package
> +    (name "zydis")
> +    (version "4.1.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/zyantific/zydis")
> +                    (commit (string-append "v" version))))
> +              (sha256
> +               (base32 "15iw6wcg2van8pw54xs15zk5cniqm8d8vbd1w1br9azv8jxsqjva"))
> +              (file-name (git-file-name name version))))

move file-name before sha256.

> +    (build-system cmake-build-system)
> +    (arguments `(#:configure-flags '("-DZYAN_SYSTEM_ZYCORE=ON"
> +                                     "-DZYDIS_BUILD_SHARED_LIB=ON"
> +                                     "-DZYDIS_BUILD_MAN=ON")))

use gexp.

> +    (native-inputs (list python ronn-ng))
> +    (inputs (list zycore))
> +    (home-page "https://zydis.re")
> +    (synopsis "Disassembler and code generation library for x86 and AMD64")
> +    (description
> +     "Zydis is a decoder and disassembler library with the following features:
> +@itemize
> +@item Support for all x86 and AMD64 instructions and extensions
> +@item Optimization for high performance
> +@item No dynamic memory allocation
> +@item Thread-safe by design
> +@item Smaller file-size overhead compared to other common disassembler libraries
> +@end itemize")
> +    (license license:expat)))
> +
>  (define-public asco
>    (package
>      (name "asco")

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#72396] [PATCH v2 2/2] gnu: Add zydis.

[guix-patches--- via]

[-- Attachment #1: Type: text/plain, Size: 1846 bytes --]

On 2024-08-19 at 14:17+08:00, Zheng Junjie wrote:
> Nguyễn Gia Phong writes:
> > +    (source (origin
> > +              (method git-fetch)
> > +              (uri (git-reference
> > +                    (url "https://github.com/zyantific/zycore-c")
> > +                    (commit (string-append "v" version))))
> > +              (sha256
> > +               (base32 "0s962pkqybh1xbs75y4jb4bqc9qnq0sviqd570mirqdhhq87agib"))
> > +              (file-name (git-file-name name version))))
>
> i move file-name before sha256.
>
> Nguyễn Gia Phong writes:
> > +    (build-system cmake-build-system)
> > +    (native-inputs (list googletest))
> > +    (arguments `(#:configure-flags '("-DZYCORE_BUILD_SHARED_LIBS=ON"
>                                         is ZYCORE_BUILD_SHARED_LIB
> > +                                     "-DZYCORE_BUILD_TESTS=ON")))
>
> i adjust to use gexp, and disable ZYCORE_BUILD_TESTS on cross-compilation.

On 2024-08-19 at 14:19+08:00, Zheng Junjie wrote:
> Nguyễn Gia Phong writes:
> > +    (source (origin
> > +              (method git-fetch)
> > +              (uri (git-reference
> > +                    (url "https://github.com/zyantific/zydis")
> > +                    (commit (string-append "v" version))))
> > +              (sha256
> > +               (base32 "15iw6wcg2van8pw54xs15zk5cniqm8d8vbd1w1br9azv8jxsqjva"))
> > +              (file-name (git-file-name name version))))
>
> move file-name before sha256.
>
> Nguyễn Gia Phong writes:
> > +    (build-system cmake-build-system)
> > +    (arguments `(#:configure-flags '("-DZYAN_SYSTEM_ZYCORE=ON"
> > +                                     "-DZYDIS_BUILD_SHARED_LIB=ON"
> > +                                     "-DZYDIS_BUILD_MAN=ON")))
>
> use gexp.

Thanks for the nits and application to master!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 687 bytes --]