unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: guix-patches--- via <guix-patches@gnu.org>
To: "Efraim Flashner" <efraim@flashner.co.il>
Cc: 71914@debbugs.gnu.org
Subject: [bug#71914] [PATCH 00/10] gnu: Add python-nh3.
Date: Wed, 03 Jul 2024 18:44:43 +0900	[thread overview]
Message-ID: <D2FT2M4TRZKZ.223OV140X1QS1@guix> (raw)
In-Reply-To: <ZoUYsxiinbKbi7yn@3900XT>

[-- Attachment #1: Type: text/plain, Size: 1846 bytes --]

On 2024-07-03 at 12:24+03:00, Efraim Flashner wrote:
> On Wed, Jul 03, 2024 at 06:20:03PM +0900, Nguyễn Gia Phong wrote:
> > On 2024-07-03 at 12:07+03:00, Efraim Flashner wrote:
> > > There were a couple of missing bits, which I found
> > > while building all the packages affected:
> > > rust-pyo3-macros-0.21, rust-pyo3-macros-0.20:
> > > Needs python-minimal as a native-input [...]
> > >
> > > I used the following command to build all the packages:
> > > ./pre-inst-env guix build --no-grafts --fallback --max-jobs=3 rust-typed-arena@2 rust-markup5ever@0.12 rust-html5ever@0.27 rust-ammonia@4 rust-pyo3{,-{build-config,ffi,macros-backend,macros}}@0.{20,21} python-nh3
> > 
> > So because Rust is statically compiled,
> > each package needs to be (built and) tested individually?
>
> Yeah, its an unfortunate side effect of using the sources of the
> packages instead of an output. There has been talk in the upstream
> rust community about providing a stable-ish interface
> so that we can reuse build artifacts from one build to another.

Thank you, that's good to know.

On 2024-07-03 at 12:27+03:00, Efraim Flashner wrote:
> On Wed, Jul 03, 2024 at 06:12:51PM +0900, Nguyễn Gia Phong wrote:
> > what's the general etiquette for sending revisions
> > of a subset of the patch series?
>
> I don't think we have a consensus. On one hand re-sending unchanged
> patches is "wasteful", on the other hand it makes it easier to work
> on a set of patches (or a revision of patches) in one go.
>
> I think I normally end up with a single updated patch if there's
> a change to only one patch, but otherwise I normally send out
> a whole new set and then in 0000-v2 I mention what changes
> there are compared to the previous version.

Thanks, guess that'd be best for compatibility with everyone's tooling.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 687 bytes --]

      reply	other threads:[~2024-07-03  9:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03  7:54 [bug#71914] [PATCH 00/10] gnu: Add python-nh3 guix-patches--- via
2024-07-03  7:57 ` [bug#71914] [PATCH 01/10] gnu: rust-typed-arena-2: Update to 2.0.2 guix-patches--- via
2024-07-03  7:57 ` [bug#71914] [PATCH 02/10] gnu: Add rust-markup5ever-0.12 guix-patches--- via
2024-07-03  7:57 ` [bug#71914] [PATCH 03/10] gnu: Add rust-html5ever-0.27 guix-patches--- via
2024-07-03  7:57 ` [bug#71914] [PATCH 04/10] gnu: Add rust-ammonia-4 guix-patches--- via
2024-07-03  7:57 ` [bug#71914] [PATCH 05/10] gnu: Add rust-pyo3-build-config-0.21 guix-patches--- via
2024-07-03  7:57 ` [bug#71914] [PATCH 06/10] gnu: Add rust-pyo3-ffi-0.21 guix-patches--- via
2024-07-03  7:57 ` [bug#71914] [PATCH 07/10] gnu: Add rust-pyo3-macros-backend-0.21 guix-patches--- via
2024-07-03  7:57 ` [bug#71914] [PATCH 08/10] gnu: Add rust-pyo3-macros-0.21 guix-patches--- via
2024-07-03  8:11   ` guix-patches--- via
2024-07-03  9:00     ` Efraim Flashner
2024-07-03  9:12       ` guix-patches--- via
2024-07-03  9:27         ` Efraim Flashner
2024-07-03  7:58 ` [bug#71914] [PATCH 09/10] gnu: Add rust-pyo3-0.21 guix-patches--- via
2024-07-03  7:58 ` [bug#71914] [PATCH 10/10] gnu: Add python-nh3 guix-patches--- via
2024-07-03  9:07 ` bug#71914: [PATCH 00/10] " Efraim Flashner
2024-07-03  9:20   ` [bug#71914] " guix-patches--- via
2024-07-03  9:24     ` Efraim Flashner
2024-07-03  9:44       ` guix-patches--- via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D2FT2M4TRZKZ.223OV140X1QS1@guix \
    --to=guix-patches@gnu.org \
    --cc=71914@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=mcsinyx@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).