[bug#29979] [PATCH] gnu: glog: Disable signal-handler unit tests.

[bug#29979] [PATCH] gnu: glog: Disable signal-handler unit tests.

[Eric Bavier]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

This patch disable the signal handler unit tests in 'glog'.  These
tests are known to fail on several systems where the expected signals
are not generated.

-- 
Eric Bavier, Scientific Libraries, Cray Inc.

[-- Attachment #2: 0001-gnu-glog-Disable-signal-handler-unit-tests.patch --]
[-- Type: text/x-patch, Size: 1747 bytes --]

From 08e3f2407c98e8cdad631e5671c8563de3b78978 Mon Sep 17 00:00:00 2001
From: Eric Bavier <bavier@cray.com>
Date: Thu, 7 Dec 2017 16:15:38 -0600
Subject: [PATCH] gnu: glog: Disable signal-handler unit tests.

* gnu/packages/logging.scm (glog)[arguments]: Add 'disable-signal-tests' phase.
---
 gnu/packages/logging.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm
index 6f9056d8f..713435c6a 100644
--- a/gnu/packages/logging.scm
+++ b/gnu/packages/logging.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2016, 2017 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2017 Stefan Reichör <stefan@xsteve.at>
+;;; Copyright © 2017 Eric Bavier <bavier@member.fsf.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -84,7 +85,14 @@ staying as close to their API as is reasonable.")
                       ;; mismatch, so run the whole thing.
                       (delete-file "test-driver")
                       (delete-file "configure")   ;it's read-only
-                      (zero? (system* "autoreconf" "-vfi")))))))
+                      (zero? (system* "autoreconf" "-vfi"))))
+                  (add-before 'check 'disable-signal-tests
+                    (lambda _
+                      ;; See e.g. https://github.com/google/glog/issues/219
+                      ;; and https://github.com/google/glog/issues/256
+                      (substitute* "Makefile"
+                        (("\tsignalhandler_unittest_sh") "\t$(EMPTY)"))
+                      #t)))))
     (synopsis "C++ logging library")
     (description
      "Google glog is a library that implements application-level logging.
-- 
2.15.0

[bug#29979] [PATCH] gnu: glog: Disable signal-handler unit tests.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

On Thu, Jan 04, 2018 at 11:04:27AM -0600, Eric Bavier wrote:
> This patch disable the signal handler unit tests in 'glog'.  These
> tests are known to fail on several systems where the expected signals
> are not generated.

LGTM

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#29979: [PATCH] gnu: glog: Disable signal-handler unit tests.

[Eric Bavier]

Thanks for the review.  Pushed in 17e1e21603e7cba622cf4ec41c0e1467972fd449

Eric Bavier, Scientific Libraries, Cray Inc.

________________________________________
From: Leo Famulari <leo@famulari.name>
Sent: Thursday, January 4, 2018 12:03
To: Eric Bavier
Cc: 29979@debbugs.gnu.org
Subject: Re: [bug#29979] [PATCH] gnu: glog: Disable signal-handler unit tests.

On Thu, Jan 04, 2018 at 11:04:27AM -0600, Eric Bavier wrote:
> This patch disable the signal handler unit tests in 'glog'.  These
> tests are known to fail on several systems where the expected signals
> are not generated.

LGTM