unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: guix-patches--- via <guix-patches@gnu.org>
To: "John Kehayias" <john.kehayias@protonmail.com>
Cc: "Ludovic Courtès" <ludo@gnu.org>,
	64222@debbugs.gnu.org, 50035@debbugs.gnu.org,
	"Sarah Morgensen" <iskarian@mgsn.dev>
Subject: [bug#64222] gnu: go-github-com-godbus-dbus-v5
Date: Fri, 13 Oct 2023 13:52:29 +0900	[thread overview]
Message-ID: <CW71HXE2UCHX.1SU4O7MG8PD9E@guix> (raw)
In-Reply-To: <87ttqv7mnb.fsf_-_@protonmail.com>

On 2023-10-12 at 17:53+00:00, John Kehayias wrote:
> [godbus's] import name has changed.  Though as an example
> chezmoi seems to have been broken for some time anyway.
> Maybe the import-name doesn't need the v5?

IIUC go-github-com-godbus-dbus is just a name for human consumption,
on the other hand I don't understand how it works without
the import-path matching the one in the go.mod file:

On 2021-08-13 at 20:49-07:00, Sarah Morgensen wrote in patchset 50037:
> -     `(#:import-path "github.com/godbus/dbus"
> +     `(#:import-path "github.com/godbus/dbus/v5"

On 2023-10-12 at 17:53+00:00, John Kehayias wrote:
> Nguyễn and/or Sarah would you like to submit a patch to change the
> import path if needed, enable tests, and make any other changes? I could
> also take a look if no one gets to it quickly.

As stated above, I don't quite understand how go packages work
(when they don't seem to be supposed to), so you two please go ahead.
(BTW you can call me by my given name Phong.)

On 2023-10-12 at 17:53+00:00, John Kehayias wrote:
> I can't help but read this as "god bus"

Yea DBus is short for Dieu Bus anyway.




  reply	other threads:[~2023-10-13  4:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13  3:06 [bug#50035] [PATCH 1/3] gnu: go-github-com-godbus-dbus: Update to 5.0.4 Sarah Morgensen
2021-08-13  3:12 ` [bug#50035] [PATCH 2/3] gnu: Rename go-github-com-godbus-dbus to go-github-com-godbus-dbus-v5 Sarah Morgensen
2021-08-13  3:12 ` [bug#50035] [PATCH 3/3] gnu: go-github-com-godbus-dbus-v5: Fix and enable tests Sarah Morgensen
2021-08-13 19:12 ` [bug#50035] [PATCH 1/3] gnu: go-github-com-godbus-dbus: Update to 5.0.4 John Kehayias via Guix-patches via
2022-02-04 20:06   ` John Kehayias via Guix-patches via
2023-10-12 17:53 ` [bug#50035] bug#64222: [PATCH 0/4] Add senpai IRC client John Kehayias via Guix-patches via
2023-10-13  4:52   ` guix-patches--- via [this message]
2024-09-03 10:10 ` bug#50035: [PATCH 1/3] gnu: go-github-com-godbus-dbus: Update to 5.0.4 Sharlatan Hellseher via Guix-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CW71HXE2UCHX.1SU4O7MG8PD9E@guix \
    --to=guix-patches@gnu.org \
    --cc=50035@debbugs.gnu.org \
    --cc=64222@debbugs.gnu.org \
    --cc=iskarian@mgsn.dev \
    --cc=john.kehayias@protonmail.com \
    --cc=ludo@gnu.org \
    --cc=mcsinyx@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).