unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Benjamin" <benjamin@uvy.fr>
To: "Andrew Tropin" <andrew@trop.in>, "Ludovic Courtès" <ludo@gnu.org>
Cc: 63357-done@debbugs.gnu.org, muradm <mail@muradm.net>
Subject: [bug#63357] [PATCH] gnu: swaylock: Add linux-pam to inputs
Date: Mon, 22 May 2023 17:53:32 +0200	[thread overview]
Message-ID: <CSSXD21OYWQK.3QRX14N8FTIK4@robot.uvy.fr> (raw)
In-Reply-To: <87h6s4qtyp.fsf@trop.in>

Hello,

> One of our colleagues mentioned that it's a breaking change and swaylock
> with pam backend will complain if suid is set, so the old setups with
> (screen-locker-service swaylock) will break after this commit.
>
> Do we want to document how to configure pam for swaylock in manual and
> add a news entry for this change?

First of all sorry for the breaking change.

I am pretty new to guix and did not know about screen-locker-service.
How I managed to make this to work is by setting a custom pam system
service :

(define-public swaylock-pam-service-type
  (service-type (name 'swaylock)
                (extensions (list (service-extension pam-root-service-type
                                                     (const (list (pam-service
                                                                   (name "swaylock")
                                                                   (auth (list
                                                                          (pam-entry
                                                                           (control "include")
                                                                           (module "greetd"))))))))))
                (description "Swaylock pam configuration")
                (default-value '())))

I do not know the policy in case of breaking changes, but if it is
easier we can roll back this change maybe ?

Best

Benjamin




  reply	other threads:[~2023-05-22 15:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-07 15:27 [bug#63357] [PATCH] gnu: swaylock: Add linux-pam to inputs Benjamin
2023-05-18 17:54 ` bug#63357: " Ludovic Courtès
2023-05-22 15:14   ` [bug#63357] " Andrew Tropin
2023-05-22 15:53     ` Benjamin [this message]
2023-05-22 19:33       ` muradm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CSSXD21OYWQK.3QRX14N8FTIK4@robot.uvy.fr \
    --to=benjamin@uvy.fr \
    --cc=63357-done@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=ludo@gnu.org \
    --cc=mail@muradm.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).