From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6Ao1MmiP4mMmwAAAbAwnHQ (envelope-from ) for ; Tue, 07 Feb 2023 18:50:32 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id WLE4MWiP4mPRdwEAG6o9tA (envelope-from ) for ; Tue, 07 Feb 2023 18:50:32 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9658E9657 for ; Tue, 7 Feb 2023 18:50:32 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPS6X-0005aj-M3; Tue, 07 Feb 2023 12:50:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPS6V-0005Zr-8q for guix-patches@gnu.org; Tue, 07 Feb 2023 12:50:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPS6U-0006jZ-Ug for guix-patches@gnu.org; Tue, 07 Feb 2023 12:50:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPS6U-0003CH-G6 for guix-patches@gnu.org; Tue, 07 Feb 2023 12:50:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60905] [PATCH 08/25] gnu: go-github-com-pkg-diff: Update to 0.0.0-20210226163009-20ebb0f2a09e. Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Feb 2023 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60905 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: cox.katherine.e@gmail.com, 60905@debbugs.gnu.org, mail@cbaines.net X-Debbugs-Original-To: "Katherine Cox-Buday" , "( via Guix-patches via" , "Christopher Baines" X-Debbugs-Original-Cc: 60905@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167579215512222 (code B ref -1); Tue, 07 Feb 2023 17:50:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Feb 2023 17:49:15 +0000 Received: from localhost ([127.0.0.1]:53953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPS5j-0003B3-Dw for submit@debbugs.gnu.org; Tue, 07 Feb 2023 12:49:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:45524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPS5h-0003Aw-KK for submit@debbugs.gnu.org; Tue, 07 Feb 2023 12:49:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPS5Z-0004uD-Se for guix-patches@gnu.org; Tue, 07 Feb 2023 12:49:07 -0500 Received: from knopi.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPS5X-0006b8-Ep for guix-patches@gnu.org; Tue, 07 Feb 2023 12:49:05 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id C67AE41092; Tue, 7 Feb 2023 18:49:01 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aItAzDWHu61E; Tue, 7 Feb 2023 18:49:00 +0100 (CET) Content-Type: multipart/signed; boundary=45cab4afc129225684b4cf5b2bd9449cd8e36fdb170133c86f5df5ce5d8b; micalg=pgp-sha512; protocol="application/pgp-signature" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1675792140; bh=SWy2A4UfWxPdk441Bdt/W0qdX515KP+GucMznrfwW9Y=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=RCT0z+6s9BBzf6sAy+ZUG387iew5IaXBa4Rem4P16zlKao5iigLRVqyscwV/a3qeW f1G3DTkpmLx6l+jfT4IMkUqcj9D/guiksWmU4PcIvR7ATzKvud9X/h2zW4UOOjqnI7 wLm4JncUhBw3jJMzLRU3YI4vR4t7ljS/gwODabnNRsLKv7aILhIspSDE02mhAqvRyn V1WW3fZjaFPTdnGxz1w6dI1UnBs9MAxq/DLUFNOaxnfs8iU/UMbGIKUGQiMRsM3I7l PAl6JyIKNByWgWRdb2P5f8m3LO6sAdUuJXKHLhWvjMSL67+IunB/gqlxyePpkmmgAw ZwmCZre4eZFyw== Date: Tue, 07 Feb 2023 17:48:59 +0000 Message-Id: References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <20230118014510.19320-9-cox.katherine.e@gmail.com> <87mt5pxv8u.fsf@gmail.com> In-Reply-To: <87mt5pxv8u.fsf@gmail.com> Received-SPF: pass client-ip=178.21.23.139; envelope-from=paren@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_HEADER_CTYPE_ONLY=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: "\(" X-ACL-Warn: , "\( via Guix-patches" From: "\( via Guix-patches" via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=RCT0z+6s; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675792232; a=rsa-sha256; cv=none; b=KVvvsNtkbOtK4XtHiVt4Y+rGxH8uYNjmw4dAIjITFnSW5sKk9HdFIrqRs6JsxBhx5FDPRn Bf4uhIRMJnGC2PyZwUZN8jBQa1YccylN1XxNwucQ4lNjOjNgqEnQoky1kBm475hyb4UZUC KrGH4LdG6T/ohHEnLBD/otJfrrThhpIa/S1AglrE+I4IEPnrT66rhPcCz+CG9AL7ZIEArZ SZ3B5WuT6Uy4KJ8l76UruvagJCMQLw0KbJ2rEqGGbpblH7G93/2cfKz/u+Dt/bXXgnE14c 5qGXHDVYqQjAkA7E6R+TTt32x/2ol3gDxTAjS3s3lwWVAkbftAg/gVe3U/k2tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675792232; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:content-type:content-type:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0swuhbTSxqE9V62AFAWS3y2r4RFqGHjXz/ym5wie+rQ=; b=kiTbMWIgrQgdMociPQ01Vq7fNzIu7Y0UwhWnJGsDxs/kSAunwJoQ+ihOMYI4XfogT84c3f 8UAOYS8SbcN7gFwlqlzBrgjgJchzE52clSm3XjE+AB8JS3ZndsQDwBDN3lD4VPvXf1VtUO vIz81kdDe9iAan4/N8e4iOTWfDbDVrHLdcTfYSTUJZPBO1CFA5Se+6KZXJ19nELtOT1oem BM7zalVA5AQt/R2mpaNdew930cc63jU3DgoJRmRG4/9sDXJMKl24DIMjoKJwiN6iAzTAAq KUJIoHfC7StyufdB6EE2MY5oU8RLfOzzezkqVTJRpsdWBZyk3QGCtZiYajW1uw== X-Migadu-Spam-Score: -3.39 X-Spam-Score: -3.39 X-Migadu-Queue-Id: 9658E9657 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=RCT0z+6s; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: Ul+jX3D2N2ZA --45cab4afc129225684b4cf5b2bd9449cd8e36fdb170133c86f5df5ce5d8b Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Tue Feb 7, 2023 at 5:04 PM GMT, Katherine Cox-Buday wrote: > What are your opinions on this? Hmm, interesting. I think this would be better answered by more experience= d contributors. > > >> + (source (origin > >> + (method git-fetch) > >> + (uri (git-reference > >> + (url "https://github.com/pkg/diff") > >> + (commit "20ebb0f2a09e612109b224b32f79370409108bcc= "))) > > > > And especially don't write the commit twice. I should've elaborated: use GO-VERSION->GIT-REF here :) > I only bumped the version here; the synopsis was pre-existing. But: is th= e language important? Do we say "Diff creates and prints diffs in > C"? Isn't this also a Go library? If it isn't, then yeah, it's not important, but if it is, I'd say you should add "in Go". -- ( --45cab4afc129225684b4cf5b2bd9449cd8e36fdb170133c86f5df5ce5d8b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEE6Vh10NblKE5doNlW7ImHg/nqI20FAmPijwwACgkQ7ImHg/nq I22fPgwA5oN+JDo9QPluPDZOs7wcNyjBwYmQvbChBGWrbhhTwxuAjix6X8FCFNZC jVhNt1kf9CbuectvWbAM07Fa0j8mrRxTDEeXOz4QFFyYzrCRurrNDTTzmA0rrMOZ 1kAecmBIQYEwk9YueLO7edztThPSkABJq/7eMTOqYOjTm3itMeWdjPu//F8yMegs YNRZWhgB5a3PfihJp1y9EziJGhrouI0Q+TjKIbOk4MvswymjKx46j8SOplC3z0KG +qV2pnUd/96fROgN8Zl6Z6jU2aioSVld2b6NX/ubFgZ+HCUyQv4ZD777dr0QNyD6 aYsDz8SbuywW23i/ip7as36SIK9P461Y6APpTs6FEU5h4tnuBGneK5bvSoD8t5Hz q9DdGrPe6pvy/S5WMhwveJMWKxKYpNaxZsBcmOeChKGJ5jl5VGJzHEOQlsskXl89 PUPgMANnjxHEn69w9F4ax5BxKr3IQLMn/+SRyaJGKOxfA0t3p58oyj8ODZyE0k0A L0L4qZjR =peD8 -----END PGP SIGNATURE----- --45cab4afc129225684b4cf5b2bd9449cd8e36fdb170133c86f5df5ce5d8b--