unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: <mirai@makinata.eu>, <59437@debbugs.gnu.org>
Subject: [bug#59437] [PATCH] gnu: Add mympd.
Date: Mon, 21 Nov 2022 17:09:22 +0000	[thread overview]
Message-ID: <COI51N3PIFNK.2BPO69PB2A815@guix-framework> (raw)
In-Reply-To: <d919bf1bc6a818f1ecb09ee3cf150307beedb1b7.1668990380.git.mirai@makinata.eu>

Heya,

On Mon Nov 21, 2022 at 12:26 AM GMT,  wrote:
> * gnu/packages/mpd.scm (mympd): New variable.

> --- a/gnu/packages/mpd.scm
> +++ b/gnu/packages/mpd.scm

> @@ -561,3 +565,28 @@ (define-public mpdevil

> +    (arguments
> +     '(#:tests? #f))

Please explain why tests are disabled in a comment. Also, please use

  (list ...)

rather than

  '(...)

for arguments.

> +    (description
> +     "myMPD is a standalone and mobile friendly web mpd client with
> +a tiny footprint and advanced features.")

This is a bit markety, I think. How about this?

  (description
   "MyMPD is a mobile-friendly web client for the MPD music
player daemon.")

    -- (




  reply	other threads:[~2022-11-21 17:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21  0:26 [bug#59437] [PATCH] gnu: Add mympd mirai
2022-11-21 17:09 ` ( via Guix-patches via [this message]
2022-11-21 17:50 ` [bug#59437] [PATCH v2] " mirai
2022-11-22  4:38   ` ( via Guix-patches via
2022-11-22 16:11 ` [bug#59437] [PATCH v3] " mirai
2022-11-24  9:51   ` bug#59437: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=COI51N3PIFNK.2BPO69PB2A815@guix-framework \
    --to=guix-patches@gnu.org \
    --cc=59437@debbugs.gnu.org \
    --cc=mirai@makinata.eu \
    --cc=paren@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).