unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: "Felix Lechner" <felix.lechner@lease-up.com>, <59399@debbugs.gnu.org>
Subject: [bug#59399] [PATCH 1/4] gnu: Add go-github-com-nathan-osman-go-sunrise.
Date: Sun, 20 Nov 2022 13:53:28 +0000	[thread overview]
Message-ID: <COH693SRWB97.OL42UKOEYP88@guix-framework> (raw)
In-Reply-To: <20221120134802.19051-1-felix.lechner@lease-up.com>

Heya,

Thanks for splitting them! A few remarks:

On Sun Nov 20, 2022 at 1:47 PM GMT, Felix Lechner wrote:
> * gnu/packages/golang.scm
>   (go-github-com-nathan-osman-go-sunrise): New variable.

Indentation for this should look something like:

  * gnu/packages/golang.scm (go-github-com-nathan-osman-go-sunrise):
    New variable.

> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm

> @@ -2485,6 +2485,33 @@ (define-public go-gopkg-in-go-playground-validator-v9

> +      (arguments
> +       '(#:import-path "github.com/nathan-osman/go-sunrise"))

Please use

  (list #:import-path ...)

instead.

> +      (synopsis "Calculates the sunrise and sunset times for a given location")

Maybe change this to:

  (synopsis "Calculate sunrise and sunset times in Go")

> +      (description
> +       "To calculate the sunrise and sunset times, you will need the date of your
> +observation and the geographical coordinates in latitude and longitude for the
> +location.")

How about this:

  (description
   "This package provides a Go library for calculating sunrise and
sunset times from geographical coordinates and a date.")

    -- (




      parent reply	other threads:[~2022-11-20 13:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-20  4:15 [bug#59399] [PATCH] gnu: Add hebcal Felix Lechner via Guix-patches via
2022-11-20  8:44 ` ( via Guix-patches via
2022-11-20 13:47   ` [bug#59399] [PATCH 1/4] gnu: Add go-github-com-nathan-osman-go-sunrise Felix Lechner via Guix-patches via
2022-11-20 13:47     ` [bug#59399] [PATCH 2/4] gnu: Add go-github-com-hebcal-gematriya Felix Lechner via Guix-patches via
2022-11-20 13:55       ` ( via Guix-patches via
2022-11-20 13:48     ` [bug#59399] [PATCH 3/4] gnu: Add go-github-com-hebcal-hebcal-go Felix Lechner via Guix-patches via
2022-11-20 14:02       ` ( via Guix-patches via
2022-11-20 14:04         ` ( via Guix-patches via
2022-11-20 13:48     ` [bug#59399] [PATCH 4/4] gnu: Add hebcal Felix Lechner via Guix-patches via
2022-11-20 14:06       ` ( via Guix-patches via
2022-11-20 17:23         ` [bug#59399] [PATCH 1/4] gnu: Add go-github-com-nathan-osman-go-sunrise Felix Lechner via Guix-patches via
2022-11-20 17:24           ` [bug#59399] [PATCH 2/4] gnu: Add go-github-com-hebcal-gematriya Felix Lechner via Guix-patches via
2022-11-20 17:24           ` [bug#59399] [PATCH 3/4] gnu: Add go-github-com-hebcal-hebcal-go Felix Lechner via Guix-patches via
2022-11-20 17:24           ` [bug#59399] [PATCH 4/4] gnu: Add hebcal Felix Lechner via Guix-patches via
2022-11-20 17:26           ` [bug#59399] [PATCH 1/4] gnu: Add go-github-com-nathan-osman-go-sunrise ( via Guix-patches via
2022-11-24  9:48             ` Christopher Baines
2022-11-20 13:53     ` ( via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=COH693SRWB97.OL42UKOEYP88@guix-framework \
    --to=guix-patches@gnu.org \
    --cc=59399@debbugs.gnu.org \
    --cc=felix.lechner@lease-up.com \
    --cc=paren@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).