unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#59126] [PATCH] gnu: go-github-com-zenhack-go-notmuch: Use UNGEXP-NATIVE with NOTMUCH-FIXTURES.
@ 2022-11-08 17:19 ( via Guix-patches via
  2022-11-20 11:28 ` Christopher Baines
  0 siblings, 1 reply; 5+ messages in thread
From: ( via Guix-patches via @ 2022-11-08 17:19 UTC (permalink / raw)
  To: 59126; +Cc: (

* gnu/packages/golang.scm (go-github-com-zenhack-go-notmuch)
  [arguments]<#:phases>{'unpack-test-fixtures}: Use UNGEXP-NATIVE with
  NOTMUCH-FIXTURES.
---
 gnu/packages/golang.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index e52161228e..26b5048ed0 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -10371,7 +10371,7 @@ (define-public go-github-com-zenhack-go-notmuch
                           (lambda* (#:key inputs import-path
                                     #:allow-other-keys)
                             (invoke "tar" "xf"
-                                    #$notmuch-fixtures "-C"
+                                    #+notmuch-fixtures "-C"
                                     (string-append "src/" import-path
                                                    "/fixtures")))))))
     (inputs (list notmuch))

base-commit: 96ae718c516a289124a0b91ceeef78b20d187825
-- 
2.38.0





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#59126] [PATCH] gnu: go-github-com-zenhack-go-notmuch: Use UNGEXP-NATIVE with NOTMUCH-FIXTURES.
  2022-11-08 17:19 [bug#59126] [PATCH] gnu: go-github-com-zenhack-go-notmuch: Use UNGEXP-NATIVE with NOTMUCH-FIXTURES ( via Guix-patches via
@ 2022-11-20 11:28 ` Christopher Baines
  2022-11-20 11:40   ` ( via Guix-patches via
  0 siblings, 1 reply; 5+ messages in thread
From: Christopher Baines @ 2022-11-20 11:28 UTC (permalink / raw)
  To: (; +Cc: 59126

[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]


"( via Guix-patches" via <guix-patches@gnu.org> writes:

> * gnu/packages/golang.scm (go-github-com-zenhack-go-notmuch)
>   [arguments]<#:phases>{'unpack-test-fixtures}: Use UNGEXP-NATIVE with
>   NOTMUCH-FIXTURES.
> ---
>  gnu/packages/golang.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index e52161228e..26b5048ed0 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -10371,7 +10371,7 @@ (define-public go-github-com-zenhack-go-notmuch
>                            (lambda* (#:key inputs import-path
>                                      #:allow-other-keys)
>                              (invoke "tar" "xf"
> -                                    #$notmuch-fixtures "-C"
> +                                    #+notmuch-fixtures "-C"
>                                      (string-append "src/" import-path
>                                                     "/fixtures")))))))
>      (inputs (list notmuch))
>
> base-commit: 96ae718c516a289124a0b91ceeef78b20d187825

Hey,

I can guess at why you might be wanting to change this, but I'm
interested in what your actual reasoning is (and it's good if this is in
the commit message to)?

Thanks,

Chris


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#59126] [PATCH] gnu: go-github-com-zenhack-go-notmuch: Use UNGEXP-NATIVE with NOTMUCH-FIXTURES.
  2022-11-20 11:28 ` Christopher Baines
@ 2022-11-20 11:40   ` ( via Guix-patches via
  2022-11-20 12:09     ` Christopher Baines
  0 siblings, 1 reply; 5+ messages in thread
From: ( via Guix-patches via @ 2022-11-20 11:40 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 59126

On Sun Nov 20, 2022 at 11:28 AM GMT, Christopher Baines wrote:
> I can guess at why you might be wanting to change this, but I'm
> interested in what your actual reasoning is (and it's good if this is in
> the commit message to)?

Well, since NOTMUCH-FIXTURES is just an origin, it won't differ on
different systems. So, we don't need to cross-compile it, because a
non-cross-compiled version will work just as well. But Guix has no
way of knowing this, so if we use UNGEXP, it'll re-build the origin
unnecessarily. If we use UNGEXP-NATIVE, it'll just use the host's
NOTMUCH-FIXTURES.

    -- (




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#59126] [PATCH] gnu: go-github-com-zenhack-go-notmuch: Use UNGEXP-NATIVE with NOTMUCH-FIXTURES.
  2022-11-20 11:40   ` ( via Guix-patches via
@ 2022-11-20 12:09     ` Christopher Baines
  2022-11-20 12:12       ` ( via Guix-patches via
  0 siblings, 1 reply; 5+ messages in thread
From: Christopher Baines @ 2022-11-20 12:09 UTC (permalink / raw)
  To: (; +Cc: 59126-done, 59126

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]


"(" <paren@disroot.org> writes:

> On Sun Nov 20, 2022 at 11:28 AM GMT, Christopher Baines wrote:
>> I can guess at why you might be wanting to change this, but I'm
>> interested in what your actual reasoning is (and it's good if this is in
>> the commit message to)?
>
> Well, since NOTMUCH-FIXTURES is just an origin, it won't differ on
> different systems. So, we don't need to cross-compile it, because a
> non-cross-compiled version will work just as well. But Guix has no
> way of knowing this, so if we use UNGEXP, it'll re-build the origin
> unnecessarily. If we use UNGEXP-NATIVE, it'll just use the host's
> NOTMUCH-FIXTURES.

Thanks. And yeah, given notmuch-fixtures is just an origin, maybe this
just does make sense without any extra explaination.

I've gone ahead and pushed this to master as
cfec9f055272feb6fca8c52ba92c8e7d831052ac.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#59126] [PATCH] gnu: go-github-com-zenhack-go-notmuch: Use UNGEXP-NATIVE with NOTMUCH-FIXTURES.
  2022-11-20 12:09     ` Christopher Baines
@ 2022-11-20 12:12       ` ( via Guix-patches via
  0 siblings, 0 replies; 5+ messages in thread
From: ( via Guix-patches via @ 2022-11-20 12:12 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 59126-done, 59126

On Sun Nov 20, 2022 at 12:09 PM GMT, Christopher Baines wrote:
> I've gone ahead and pushed this to master as
> cfec9f055272feb6fca8c52ba92c8e7d831052ac.

Thanks!

    -- (




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-11-20 12:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-08 17:19 [bug#59126] [PATCH] gnu: go-github-com-zenhack-go-notmuch: Use UNGEXP-NATIVE with NOTMUCH-FIXTURES ( via Guix-patches via
2022-11-20 11:28 ` Christopher Baines
2022-11-20 11:40   ` ( via Guix-patches via
2022-11-20 12:09     ` Christopher Baines
2022-11-20 12:12       ` ( via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).