* [bug#58442] [PATCH 0/1] Add EditorConfig specification.
@ 2022-10-11 15:06 ( via Guix-patches via
2022-10-11 15:22 ` [bug#58442] [PATCH 1/1] " ( via Guix-patches via
2022-11-03 15:52 ` [bug#58442] [PATCH 0/1] " Christopher Baines
0 siblings, 2 replies; 7+ messages in thread
From: ( via Guix-patches via @ 2022-10-11 15:06 UTC (permalink / raw)
To: 58442; +Cc: (
This patch adds a .editorconfig file to the project root. This is especially
useful for ~~nonbelievers~~ non-Emacs users.
( (1):
Add EditorConfig specification.
.editorconfig | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 .editorconfig
--
2.38.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#58442] [PATCH 1/1] Add EditorConfig specification.
2022-10-11 15:06 [bug#58442] [PATCH 0/1] Add EditorConfig specification ( via Guix-patches via
@ 2022-10-11 15:22 ` ( via Guix-patches via
2022-10-11 15:59 ` Tobias Geerinckx-Rice via Guix-patches via
2022-11-03 15:52 ` [bug#58442] [PATCH 0/1] " Christopher Baines
1 sibling, 1 reply; 7+ messages in thread
From: ( via Guix-patches via @ 2022-10-11 15:22 UTC (permalink / raw)
To: 58442; +Cc: (
* .editorconfig: New file.
---
.editorconfig | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 .editorconfig
diff --git a/.editorconfig b/.editorconfig
new file mode 100644
index 0000000000..bc68ff24c8
--- /dev/null
+++ b/.editorconfig
@@ -0,0 +1,16 @@
+root = true
+
+[*.{c,h,cpp,hpp,el,scm,ac,am,m4,po}{,.in}]
+end_of_line = lf
+insert_final_newline = true
+charset = utf-8
+trim_trailing_whitespace = true
+
+[*.{c,h,cpp,hpp,ac,am,m4,el,scm}{,.in}]
+max_line_length = 85
+
+[*.{c,h,cpp,hpp,ac,m4,el,scm}{,.in}]
+indent_style = space
+
+[*.{c,h,cpp,hpp}{,.in}]
+indent_size = 4
--
2.38.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#58442] [PATCH 1/1] Add EditorConfig specification.
2022-10-11 15:22 ` [bug#58442] [PATCH 1/1] " ( via Guix-patches via
@ 2022-10-11 15:59 ` Tobias Geerinckx-Rice via Guix-patches via
2022-10-13 10:32 ` Liliana Marie Prikler
0 siblings, 1 reply; 7+ messages in thread
From: Tobias Geerinckx-Rice via Guix-patches via @ 2022-10-11 15:59 UTC (permalink / raw)
To: (; +Cc: 58442
[-- Attachment #1: Type: text/plain, Size: 334 bytes --]
Hi!
"( via Guix-patches" via 写道:
> * .editorconfig: New file.
All these values LGTM, but I use the correct editor.
> max_line_length = 85
As discussed on IRC, it's obvious to ‘us’ what this really means,
but I wonder if it's universal. Unless someone disagrees, I think
it's OK.
Kind regards,
T G-R
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#58442] [PATCH 1/1] Add EditorConfig specification.
2022-10-11 15:59 ` Tobias Geerinckx-Rice via Guix-patches via
@ 2022-10-13 10:32 ` Liliana Marie Prikler
0 siblings, 0 replies; 7+ messages in thread
From: Liliana Marie Prikler @ 2022-10-13 10:32 UTC (permalink / raw)
To: Tobias Geerinckx-Rice, (; +Cc: 58442
Am Dienstag, dem 11.10.2022 um 17:59 +0200 schrieb Tobias Geerinckx-
Rice:
> Hi!
>
> "( via Guix-patches" via 写道:
> > * .editorconfig: New file.
>
> All these values LGTM, but I use the correct editor.
>
> > max_line_length = 85
>
> As discussed on IRC, it's obvious to ‘us’ what this really means,
> but I wonder if it's universal. Unless someone disagrees, I think
> it's OK.
If I recall correctly, the correct editor uses 79 as fill-column. Even
if extended URLs are nasty in other editors, as discussed in IRC, I'd
claim that to be "a good thing", because the failed word-wrapping shows
the writer how nasty that'd be and makes them use string-append.
Cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#58442] [PATCH 0/1] Add EditorConfig specification.
2022-10-11 15:06 [bug#58442] [PATCH 0/1] Add EditorConfig specification ( via Guix-patches via
2022-10-11 15:22 ` [bug#58442] [PATCH 1/1] " ( via Guix-patches via
@ 2022-11-03 15:52 ` Christopher Baines
2022-11-05 10:50 ` bug#58442: " Christopher Baines
1 sibling, 1 reply; 7+ messages in thread
From: Christopher Baines @ 2022-11-03 15:52 UTC (permalink / raw)
To: (; +Cc: 58442
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
"( via Guix-patches" via <guix-patches@gnu.org> writes:
> This patch adds a .editorconfig file to the project root. This is especially
> useful for ~~nonbelievers~~ non-Emacs users.
>
> ( (1):
> Add EditorConfig specification.
>
> .editorconfig | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 .editorconfig
Is this just waiting to be merged? It seems fine to me, although I
probably won't notice it's addition.
Given it's easy to change, I don't think we need to do much upfront
review.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#58442: [PATCH 0/1] Add EditorConfig specification.
2022-11-03 15:52 ` [bug#58442] [PATCH 0/1] " Christopher Baines
@ 2022-11-05 10:50 ` Christopher Baines
2022-11-05 10:52 ` [bug#58442] " ( via Guix-patches via
0 siblings, 1 reply; 7+ messages in thread
From: Christopher Baines @ 2022-11-05 10:50 UTC (permalink / raw)
To: (; +Cc: 58442-done
[-- Attachment #1: Type: text/plain, Size: 689 bytes --]
Christopher Baines <mail@cbaines.net> writes:
> "( via Guix-patches" via <guix-patches@gnu.org> writes:
>
>> This patch adds a .editorconfig file to the project root. This is especially
>> useful for ~~nonbelievers~~ non-Emacs users.
>>
>> ( (1):
>> Add EditorConfig specification.
>>
>> .editorconfig | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>> create mode 100644 .editorconfig
>
> Is this just waiting to be merged? It seems fine to me, although I
> probably won't notice it's addition.
>
> Given it's easy to change, I don't think we need to do much upfront
> review.
I've gone ahead and pushed this as
6123f0e467aa5249f0a497c89ce434222702a535.
Thanks,
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#58442] [PATCH 0/1] Add EditorConfig specification.
2022-11-05 10:50 ` bug#58442: " Christopher Baines
@ 2022-11-05 10:52 ` ( via Guix-patches via
0 siblings, 0 replies; 7+ messages in thread
From: ( via Guix-patches via @ 2022-11-05 10:52 UTC (permalink / raw)
To: Christopher Baines; +Cc: 58442-done
On Sat Nov 5, 2022 at 10:50 AM GMT, Christopher Baines wrote:
> I've gone ahead and pushed this as
> 6123f0e467aa5249f0a497c89ce434222702a535.
Thanks!
-- (
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-11-05 10:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-11 15:06 [bug#58442] [PATCH 0/1] Add EditorConfig specification ( via Guix-patches via
2022-10-11 15:22 ` [bug#58442] [PATCH 1/1] " ( via Guix-patches via
2022-10-11 15:59 ` Tobias Geerinckx-Rice via Guix-patches via
2022-10-13 10:32 ` Liliana Marie Prikler
2022-11-03 15:52 ` [bug#58442] [PATCH 0/1] " Christopher Baines
2022-11-05 10:50 ` bug#58442: " Christopher Baines
2022-11-05 10:52 ` [bug#58442] " ( via Guix-patches via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).