From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CB97IfvYWmNpawEAbAwnHQ (envelope-from ) for ; Thu, 27 Oct 2022 21:16:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wJBqIfvYWmN3LwAAauVa8A (envelope-from ) for ; Thu, 27 Oct 2022 21:16:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3B6511CAC4 for ; Thu, 27 Oct 2022 21:16:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo8DY-0004Bq-WA; Thu, 27 Oct 2022 15:07:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo8DS-0002p3-2r for guix-patches@gnu.org; Thu, 27 Oct 2022 15:06:59 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo8CY-0007xT-Gh for guix-patches@gnu.org; Thu, 27 Oct 2022 15:06:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oo8CY-00065R-5r for guix-patches@gnu.org; Thu, 27 Oct 2022 15:06:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58208] [PATCH 6/7] gnu: Add vamp-aubio-plugins. Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 27 Oct 2022 19:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58208 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Lilah Tascheter" , <58208@debbugs.gnu.org> Cc: ludo@gnu.org Received: via spool by 58208-submit@debbugs.gnu.org id=B58208.166689753923364 (code B ref 58208); Thu, 27 Oct 2022 19:06:02 +0000 Received: (at 58208) by debbugs.gnu.org; 27 Oct 2022 19:05:39 +0000 Received: from localhost ([127.0.0.1]:59351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo8CB-00064m-7r for submit@debbugs.gnu.org; Thu, 27 Oct 2022 15:05:39 -0400 Received: from knopi.disroot.org ([178.21.23.139]:50474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo8C9-00064e-GX for 58208@debbugs.gnu.org; Thu, 27 Oct 2022 15:05:38 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id DBCF54E6F6; Thu, 27 Oct 2022 21:05:36 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id dj5BXVQHw7PE; Thu, 27 Oct 2022 21:05:35 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1666897519; bh=X5ZiWMAR8O0BhEGvMRgJZxaSmHv/j+lB/1OOFZslZ+o=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=FJcBdTq8IsWufU5z283ANiGIdUR7FZf4Nv/k/pP23eU7l6uiOgsLbtXeLGCHVJssN R4KSOoJxIF3ApfefmvSCpMj84e1v79XqZ7VwWYqEIwPtVf6WsuSi13WybA1+ofMphC vADmLzjdW3tOeUU4tJmgyUid9ToOVaL0vAnagE3ADfLOtOdrkmTnw7w/XA4PMqu5ES +tCpryLJcpLfPTYvyMgqABZckfV2mBvXaPsYyYRoQq7g7GG/cZK58oDlW3n3LHwpbt Snox6RizKG7rauD2N9rOVdy9sbWvMR59UjTs1HtQRYjeL6iduyD+Y5MWfL8i1idCQc 3y/a3BQqausDg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 27 Oct 2022 20:05:18 +0100 Message-Id: References: <7545dbcf059f8a60f3b1a48411a3e30a893f0edc.1664583143.git.lilah@lunabee.space> In-Reply-To: <7545dbcf059f8a60f3b1a48411a3e30a893f0edc.1664583143.git.lilah@lunabee.space> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Guix-patches" Reply-to: "\(" X-ACL-Warn: , "\( via Guix-patches" From: "\( via Guix-patches" via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666898171; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HBZLGUx0YfHkUHWHSse0RJUlckU1LkmX8BrhU/Kujks=; b=SmL2ymjnEoY6nzUgJ5e/mAHtdq2tcwwXM0sUwTQs3932okjY3TtBfs7hOW4eDDbhFvjEZU vSCca4a6PqVTJo1r7ajMsLoy/kOdgAzGUIIIm0J+fOyTVEb3qh5FUMhpJjryXs6A7RMNjI m24ugtrX1y3sQ/qppMmA8jF9Q5BjXqm7U4i19IU99FA3HZSznxb5ACCphz+WBxw2/CYEJ0 GCeqeHTyASkWe8bBp5qBK5gaEoYEeJO6hX3G1cU+rfAbnqnwPbuZ9ALHbanvMyoX5VPDV0 WZkNWyxUyluUk0PbHGMWZOO+inSsmdHu+IJ3ELDPLUYIPV4MjEKsCd/XszVpeA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666898171; a=rsa-sha256; cv=none; b=XmLEgEcD5nsiuih5M+zc1bsrO+pKMnI/QZOHyHp3g2nBW0/UQtGlt8dIhxX9CTiZ/SBdde TSiWx2MW/wCDgB5kUU54tdKaPlur4A0vKb0bVbYSBhrDcOn1raIpnIBpO6UWeEDpiCDUwl awYL6hVnga+HRdxa8vbdXXfgUSTBmuKYTA62XUBgoJmfjK5GnD2LujayGi2Rs6nVhn3jEQ gRyqUFxeP2ObtmKzFkOx5XAitCYHaE3TE18r4mV4lBABtvlcyFuo3LEeS5o3kuOljx80Hd B0aS18m+4zh9Br/YK287qrcAcPsdAkxKHQdanPZNOQlYN7DcAycvgZD8HdLxpA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=FJcBdTq8; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.91 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=FJcBdTq8; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3B6511CAC4 X-Spam-Score: -0.91 X-Migadu-Scanner: scn1.migadu.com X-TUID: o4RhOf0dwefp On Sat Oct 1, 2022 at 1:22 AM BST, Lilah Tascheter via Guix-patches via wro= te: > + (uri (string-append "https://aubio.org/pub/vamp-aubio-plug= ins/" > + "vamp-aubio-plugins-" version ".tar.bz= 2")) Add a file-name field. > + (sha256 > + (base32 > + "1gpcg7hih42qmys8a9zylgas3xfrzqijasgaphm43bmiw7vrvxis"= )) One space indents here. > + (snippet '(begin ;; remove outdated & bundled waf > + (delete-file "waf") > + (delete-file-recursively "waflib"))))) Use gexp instead of quote here, (snippet #~(begin (delete-file "waf") (delete-file-recursively "waflib"))) > + (arguments > + `(#:tests? #f ;; no tests available > + #:phases > + (modify-phases %standard-phases > + (add-before 'configure 'setup-waf > + (lambda* (#:key inputs #:allow-other-keys) > + (let ((waf (assoc-ref inputs "python-waf"))) > + (copy-file (string-append waf "/bin/waf") "waf"))))))) Use the modern argument style (and correct comment style), (arguments (list #:tests? #f ;no tests #:phases #~(modify-phases %standard-phases (add-before 'configure 'setup-waf (lambda* (#:key inputs #:allow-other-keys) (copy-file (search-input-file inputs "bin/waf") "waf")))))) > + (native-search-paths > + (list (search-path-specification > + (variable "VAMP_PATH") > + (files '("lib/vamp"))))) Use the ``$VAMP_PATH'' variable here. > + (description "A set of VAMP plugins wrapping the audio annotation fe= atures > +of Aubio for use in a VAMP host. Includes plugins for note tracking, ene= rgy guix lint says "sentences in description should be followed by two spaces"; remember to run it for every package you write :) Also, full sentences. > + (home-page "https://aubio.org/vamp-aubio-plugins/") Move home-page, etc etc :) -- (