unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: "Lilah Tascheter" <lilah@lunabee.space>, <58208@debbugs.gnu.org>
Cc: ludo@gnu.org
Subject: [bug#58208] [PATCH 4/7] gnu: Add sonic-visualiser.
Date: Thu, 27 Oct 2022 19:57:02 +0100	[thread overview]
Message-ID: <CNWXOGHX6LG2.WQL3LUULNS8F@guix-framework> (raw)
In-Reply-To: <5c85435a14c0b7e423ac3b9d03f238835c7cec0d.1664583143.git.lilah@lunabee.space>

On Sat Oct 1, 2022 at 1:22 AM BST, Lilah Tascheter via Guix-patches via wrote:
> +              (uri (string-append
> +                     "https://github.com/sonic-visualiser/sonic-visualiser"
> +                     "/releases/download/sv_v" version "/sonic-visualiser-"
> +                     version ".tar.gz"))

file-name, please.

> +              (sha256
> +                (base32
> +                  "18w2mf4c6sis0lg6dq75v4zb8q9rbmbmlfvcvk60lyqynmvq4yy5"))))

Too many spaces again :)

> +    (arguments (list #:tests? #f)) ;; tests fail due to build sandbox

Could you please be more specific here? How does it fail? Also, the usual
practice in Scheme is to use a single semicolon for comments at the *end*
of a line (as opposed to two for a full line, three for a whole section of
a file, and four for the whole file).

> +    (inputs (list alsa-lib

Put the (list ...) on a new line.

> +    (home-page "https://sonicvisualiser.org")

home-page goes before synopsis.

    -- (




  reply	other threads:[~2022-10-27 19:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-01  0:19 [bug#58208] [PATCH 0/7] Add Sonic Visualiser and VAMP plugins Lilah Tascheter via Guix-patches via
2022-10-01  0:22 ` [bug#58208] [PATCH 1/7] gnu: Add oggz Lilah Tascheter via Guix-patches via
2022-10-27 18:48   ` ( via Guix-patches via
2022-10-01  0:22 ` [bug#58208] [PATCH 2/7] gnu: libkate: Add optional input oggz Lilah Tascheter via Guix-patches via
2022-10-27 18:52   ` ( via Guix-patches via
2022-10-01  0:22 ` [bug#58208] [PATCH 3/7] gnu: Add libfishsound Lilah Tascheter via Guix-patches via
2022-10-27 18:53   ` ( via Guix-patches via
2022-10-01  0:22 ` [bug#58208] [PATCH 4/7] gnu: Add sonic-visualiser Lilah Tascheter via Guix-patches via
2022-10-27 18:57   ` ( via Guix-patches via [this message]
2022-10-01  0:22 ` [bug#58208] [PATCH 5/7] gnu: Add VAMP plugins to VAMP_PATH Lilah Tascheter via Guix-patches via
2022-10-27 18:59   ` ( via Guix-patches via
2022-10-01  0:22 ` [bug#58208] [PATCH 6/7] gnu: Add vamp-aubio-plugins Lilah Tascheter via Guix-patches via
2022-10-27 19:05   ` ( via Guix-patches via
2022-10-27 19:12   ` ( via Guix-patches via
2022-10-01  0:22 ` [bug#58208] [PATCH 7/7] gnu: Add nnls-chroma Lilah Tascheter via Guix-patches via
2022-10-27 19:11   ` ( via Guix-patches via
2023-06-02  5:56 ` [bug#58208] [PATCH v2 0/9] Add Sonic Visualiser and VAMP plugins Lilah Tascheter via Guix-patches via
2023-06-02  5:56   ` [bug#58208] [PATCH v2 1/9] gnu: Add oggz Lilah Tascheter via Guix-patches via
2023-06-02  5:56   ` [bug#58208] [PATCH v2 2/9] gnu: libkate: Add optional input oggz Lilah Tascheter via Guix-patches via
2023-06-02  5:56   ` [bug#58208] [PATCH v2 3/9] gnu: Add libfishsound Lilah Tascheter via Guix-patches via
2023-06-02  5:56   ` [bug#58208] [PATCH v2 4/9] gnu: Add rubberband-next Lilah Tascheter via Guix-patches via
2023-06-02  5:56   ` [bug#58208] [PATCH v2 5/9] gnu: Update vamp Lilah Tascheter via Guix-patches via
2023-06-02  5:56   ` [bug#58208] [PATCH v2 6/9] gnu: Add sonic-visualiser Lilah Tascheter via Guix-patches via
2023-06-02  5:56   ` [bug#58208] [PATCH v2 7/9] gnu: Register VAMP_PATH with host Lilah Tascheter via Guix-patches via
2023-06-02  5:56   ` [bug#58208] [PATCH v2 8/9] gnu: Add vamp-aubio-plugins Lilah Tascheter via Guix-patches via
2023-06-02  5:56   ` [bug#58208] [PATCH v2 9/9] gnu: Add nnls-chroma Lilah Tascheter via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CNWXOGHX6LG2.WQL3LUULNS8F@guix-framework \
    --to=guix-patches@gnu.org \
    --cc=58208@debbugs.gnu.org \
    --cc=lilah@lunabee.space \
    --cc=ludo@gnu.org \
    --cc=paren@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).