unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: "Felix Lechner" <felix.lechner@lease-up.com>
Cc: 58768@debbugs.gnu.org
Subject: [bug#58768] Patch attached
Date: Tue, 25 Oct 2022 17:07:50 +0100	[thread overview]
Message-ID: <CNV4TTJK0DV8.31R94HQSBR3F0@guix-framework> (raw)
In-Reply-To: <CAFHYt54bnt3WDaCOn-32sF+sUKt+dxX=5Yk1rrgjRDT7vuSW4w@mail.gmail.com>

Heya,

On Tue Oct 25, 2022 at 2:39 PM BST, Felix Lechner wrote:
> The patch was rebased for the recent acceptance of one prerequisite,
> namely Patch#58659.

Cool. Shouldn't that have been in this patch series, though? Also, it's
better to use the procedure described here and in the manual's Contributing
section for sending patches, rather than sending them as attachments; it
makes them much easier to reply to: <https://issues.guix.gnu.org/58648#1>

By the way, each package should be in its own patch, not one mega-patch.

> Thanks for that hint too! Oddly, both 'guix build' and 'guix lint'
> found the variables without it but the new file is gone, anyway.

They will find it, but you won't be able to compile the file with
``make'', so ``guix pull'' won't be able to compile it (which it does to
make loading faster).

    -- (




  reply	other threads:[~2022-10-25 16:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-25  0:23 [bug#58768] [PATCH] gnu: Add gocryptfs Felix Lechner via Guix-patches via
2022-10-25  0:25 ` [bug#58768] Patch attached Felix Lechner via Guix-patches via
2022-10-25  6:30   ` ( via Guix-patches via
2022-10-25 13:39     ` Felix Lechner via Guix-patches via
2022-10-25 16:07       ` ( via Guix-patches via [this message]
2022-10-27 16:48         ` Felix Lechner via Guix-patches via
2022-10-25 19:27 ` [bug#58768] [PATCH 1/9] gnu: Add go-github-com-hanwen-go-fuse-v2 Felix Lechner via Guix-patches via
2022-10-25 19:27   ` [bug#58768] [PATCH 2/9] gnu: Add go-github-com-jacobsa-crypto Felix Lechner via Guix-patches via
2022-10-25 19:27   ` [bug#58768] [PATCH 3/9] gnu: Add go-github-com-jacobsa-oglematchers Felix Lechner via Guix-patches via
2022-10-25 19:27   ` [bug#58768] [PATCH 4/9] gnu: Add go-github-com-jacobsa-oglemock Felix Lechner via Guix-patches via
2022-10-25 19:27   ` [bug#58768] [PATCH 5/9] gnu: Add go-github-com-jacobsa-ogletest Felix Lechner via Guix-patches via
2022-10-25 19:27   ` [bug#58768] [PATCH 6/9] gnu: Add go-github-com-jacobsa-reqtrace Felix Lechner via Guix-patches via
2022-10-25 19:27   ` [bug#58768] [PATCH 7/9] gnu: Add go-github-com-pkg-xattr Felix Lechner via Guix-patches via
2022-10-25 19:27   ` [bug#58768] [PATCH 8/9] gnu: Add go-github-com-rfjakob-eme Felix Lechner via Guix-patches via
2022-10-25 19:27   ` [bug#58768] [PATCH 9/9] gnu: Add gocryptfs Felix Lechner via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CNV4TTJK0DV8.31R94HQSBR3F0@guix-framework \
    --to=guix-patches@gnu.org \
    --cc=58768@debbugs.gnu.org \
    --cc=felix.lechner@lease-up.com \
    --cc=paren@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).