unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: zimon.toutoune@gmail.com, 58648@debbugs.gnu.org
Subject: [bug#58648] [PATCH 1/1] doc: contributing: Expand "Sending a Patch Series".
Date: Thu, 20 Oct 2022 09:59:21 +0100	[thread overview]
Message-ID: <CNQML0VB39DG.1B0OXJ6642WUZ@guix-framework> (raw)
In-Reply-To: <87a65qkh52.fsf@gmail.com>

Heya Simon,

On Thu Oct 20, 2022 at 9:56 AM BST, zimoun wrote:
> On mer., 19 oct. 2022 at 23:00, "\( via Guix-patches" via <guix-patches@gnu.org> wrote:
> > +@example
> > +$ git format-patch -$N -o outgoing --cover-letter
> > +@end example
>
> Here…
>
> > +
> > +@quotation Note
> > +The @code{git send-email} command is provided by the @code{send-email}
> > +output of the @code{git} package, i.e. @code{git:send-email}.
> > +@end quotation
> > +
> > +This command makes patches out of the last @var{N} commits, and writes
> > +them to @code{.patch} files in @code{outgoing/}, along with an automatically
> > +generated cover letter.  We can then send the cover letter to the Guix
> > +mailing list.
>
> …or in these explanations, I would also suggest the option ’--base’; as
> recommended by item #1 in subsection «Submitting Patches».

Oh, cool, I didn't know about ``--base'' :) I'll add that in.

> > +At some point, the Debbugs mailer will reply to your cover letter mail
> > +with an acknowledgement, which contains the issue number of your patchset.
> > +You should now send the rest of the patches to this issue thread, using
> > +the @code{@var{ISSUE_NUMBER}@@debbugs.gnu.org} address.
>
> I agree that ISSUE_NUMBER is a better name than NNN or else.  Therefore,
> maybe it could be worth to also tweak it in the section Teams.

Okay.

> > +The use of the @code{etc/teams.scm} script to notify the appropriate team
> > +members (@pxref{Teams}) is recommended when submitting patches, to maximize
> > +the chances of your patch series being reviewed quickly.
>
> I would advertise about Teams early in this section.  Maybe in the first
> paragraph.

Alright!

    -- (




  reply	other threads:[~2022-10-20  9:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-19 21:57 [bug#58648] [PATCH 0/1] doc: contributing: Expand "Sending a Patch Series" ( via Guix-patches via
2022-10-19 22:00 ` [bug#58648] [PATCH 1/1] " ( via Guix-patches via
2022-10-20  8:56   ` zimoun
2022-10-20  8:59     ` ( via Guix-patches via [this message]
2022-10-20 14:13 ` [bug#58648] [PATCH v2] " ( via Guix-patches via
2022-10-22 11:21   ` Liliana Marie Prikler
2022-10-22 11:30     ` ( via Guix-patches via
2022-10-22 12:20       ` Liliana Marie Prikler
2022-10-28 14:41         ` zimoun
2022-10-25 18:42 ` [bug#58648] [PATCH v3] " ( via Guix-patches via
2022-10-25 19:18   ` Liliana Marie Prikler
2022-10-25 19:23     ` ( via Guix-patches via
2022-10-28 14:04     ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CNQML0VB39DG.1B0OXJ6642WUZ@guix-framework \
    --to=guix-patches@gnu.org \
    --cc=58648@debbugs.gnu.org \
    --cc=paren@disroot.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).