From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UAcvLoz8Q2OGdAAAbAwnHQ (envelope-from ) for ; Mon, 10 Oct 2022 13:05:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 4AxFLYz8Q2PScwAAG6o9tA (envelope-from ) for ; Mon, 10 Oct 2022 13:05:48 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 53560EE71 for ; Mon, 10 Oct 2022 13:05:48 +0200 (CEST) Received: from localhost ([::1]:59058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohqbT-00039l-GW for larch@yhetil.org; Mon, 10 Oct 2022 07:05:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohqYp-00014u-E1 for guix-patches@gnu.org; Mon, 10 Oct 2022 07:03:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47162) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohqYp-0002i1-5u for guix-patches@gnu.org; Mon, 10 Oct 2022 07:03:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohqYp-0006w2-0q for guix-patches@gnu.org; Mon, 10 Oct 2022 07:03:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58408] [PATCH] gnu: Add doctl. Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Oct 2022 11:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58408 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Matthew James Kraai" , <58408@debbugs.gnu.org> Received: via spool by 58408-submit@debbugs.gnu.org id=B58408.166539975926592 (code B ref 58408); Mon, 10 Oct 2022 11:03:02 +0000 Received: (at 58408) by debbugs.gnu.org; 10 Oct 2022 11:02:39 +0000 Received: from localhost ([127.0.0.1]:46233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohqYR-0006uq-6U for submit@debbugs.gnu.org; Mon, 10 Oct 2022 07:02:39 -0400 Received: from knopi.disroot.org ([178.21.23.139]:36326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohqYP-0006uh-6n for 58408@debbugs.gnu.org; Mon, 10 Oct 2022 07:02:37 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 81C644CAD5; Mon, 10 Oct 2022 13:02:35 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id h4SXK-CVN7Nc; Mon, 10 Oct 2022 13:02:34 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1665399718; bh=gHUHEC9eZQsrKyLVD4K03mqIJmK/UEomqk6/F2ERbNQ=; h=Date:Subject:From:To:References:In-Reply-To; b=QIs8FG7wsS/yKaKWbnsT2nSsmRSBT0R2Td8g01HRXvQkfVqr2uV7o0vdbbEiGXe49 5dykp6v+1GRsFCPL1/MKDK3/bwdf24Od838wB+nLrG5bi7kQ94+7SCgHOg2yUemkO5 gwphhOipWuTwY+KqC38H1/C0iLbPY4D1JSIjpAnPJ/ZknUB4FWo8ksn1+eS5dJ1lDM XjJVm2KHdXkjvbxJoGEwLOJijUOpQcAxYj3PJ+D7N3lWuq1qmpa+B6FpyvxgzlJp2y abn/Dvrh+QxHFwnyrr9tJ6B7bUZOuUDqYwghBboxcLsXRlyFpu25k+4IOuUPOeuAhF m62OzMikQwOWA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 10 Oct 2022 12:01:58 +0100 Message-Id: References: <20221010095456.23196-1-kraai@ftbfs.org> In-Reply-To: <20221010095456.23196-1-kraai@ftbfs.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: "\(" X-ACL-Warn: , "\( via Guix-patches" From: "\( via Guix-patches" via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665399948; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=utXpidFxjWYgTf8cZzDKNbgPWdeUi6e5oWd+8uuNNgI=; b=Mr5lNQDKbkhB1pA2desJNfo+88vVeaQ3V0aB3Adhhc6/jNlQTdwhCJPiauaa5Eiaj3WHF3 BSBnPqmI9duslZFPdNCwqN5C+iV9csNFUN7vQHfzKJZUtdu1NcXr2wkAyRk8M3wfjJKcdc jhcq/lwFuT/KaoOsGQTJ2L08f3RaHMZDNXNRGa/ACGADBCO0WhFYxe1p4DJ1D9kb5nsXk5 tRn19BLujfH+vIWQgPayIWcCmdto8CCPzXwVEtAjYoNgK0ThXb+gzwk7mPO0sVM9w1ssRY 0DpZB3KnG07KLec/iR+ttANS+Zcu1OXQs3AdXg5vIhW033yRQIxmpQ6bVJzv9Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665399948; a=rsa-sha256; cv=none; b=dIYk42OFfJQwx1K/qp+kGGBt+s5MnO7ckA5VXPWlgeKcQQwbO1NLDNzU1PGT7M9hz1G7vt ehBWaoIblFr6bNnzGPKFX5LOhD+Gfu7I40sjCBxSZQV+ManqOJ/hkjX1gbcsIqttiem9Nr 7xsC58w5WnsECBP2XSl/DPBo/6GokVI4AqnHH330AHZ9JYpVVTlRj3TRKXK/CMOIh6RLSw qjPK8UUtULNnsX5oYfHjO7pQBVNnqyRkyDSG/WkoW+mHA57BIontEG4NvYSSbF815F9Dod FB6DBNmTFolIBYyoxekifym+vKx14+QcpIvadyk6EYYhqMzzFcg9YzR2GV1nYg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=QIs8FG7w; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.38 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=QIs8FG7w; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 53560EE71 X-Spam-Score: -2.38 X-Migadu-Scanner: scn0.migadu.com X-TUID: wcmnJBLw6o1p Hey Matthew, On Mon Oct 10, 2022 at 10:54 AM BST, Matthew James Kraai wrote: > * gnu/packages/doctl.scm: New file. > * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. You sure there's no better place to put it than a new file? Maybe ``gnu/packages/admin.scm''? > + #:use-module (guix download) Since you're using git-fetch, you shouldn't need this module, right? > + (arguments > + `(#:build-flags '(,(string-append "-ldflags=3D-X github.com/digital= ocean/doctl.Label=3Drelease" > + " -X github.com/digitalocean/doct= l.Major=3D" > + (first (string-split version #\.)= ) > + " -X github.com/digitalocean/doct= l.Minor=3D" > + (second (string-split version #\.= )) > + " -X github.com/digitalocean/doct= l.Patch=3D" > + (third (string-split version #\.)= ))) So, this whole thing would be better formatted with "new style" arguments (using ``list'' and gexps). Like this: (arguments (list #:build-flags #~(list (string-append ...)) #| et cetera |#)) This would also allow you to remove the unquote in ``,go-1.19''. Note that = only ``#:build-flags'' needs the gexp ``#~'' in this arguments list. > + #:go ,go-1.19 Might be best to put this above build-flags. > + #:import-path "github.com/digitalocean/doctl/cmd/doctl" The import-path is usually at the top of the arguments list. > + #:unpack-path "github.com/digitalocean/doctl")) And the unpack-path is usually directly after the import-path. > + (description > + "doctl provides a unified command line interface to the DigitalOcea= n API.") Change ``doctl'' to ``@code{doctl}''. -- (