[bug#58162] [PATCH] gnu: Add qdmr

["\( via Guix-patches" via <guix-patches@gnu.org>]

Hey!

On Thu Sep 29, 2022 at 2:57 AM BST, Ryan Tolboom wrote:
> +    (native-inputs (list qttools-5))
> +    (inputs (list qtbase-5 qtserialport qtlocation yaml-cpp libusb))

Usually inputs and native-inputs come after arguments.

> +    (arguments
> +     `(#:tests? #f ;No tests
> +       #:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'fix-paths
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (substitute* "lib/CMakeLists.txt"
> +                        (("DESTINATION \"/etc/udev/")
> +                         (string-append "DESTINATION \""
> +                                        (assoc-ref outputs "out") "/lib/udev/"))))))))

Try using the new gexp style for arguments:

  (arguments
   (list #:tests? #f ;no tests
         #:phases
         #~(modify-phases %standard-phases
             (add-after 'unpack 'patch-paths
               (lambda _
                 (substitute* "lib/CMakeLists.txt"
                   (("(DESTINATION \")/etc/udev/" _ directive)
                    (string-append directive #$output "/lib/udev/"))))))))

> +    (description
> +     "qdmr is a graphical user interface (GUI) application that allows one to
> +program several types of DMR radios.  To this end, it aims at being a more
> +universal codeplug programming software (CPS) compared to the device and even
> +revision specific CPSs provided by the manufacturers.  The goal of this project
> +is to provide a single, comfortable, well-documented and platform-independent
> +CPS for several types of (mainly Chinese) DMR radios.
> +
> +To install the qdmr udev rules, you must extend @code{udev-service-type} with this
> +package.  E.g.: @code{(udev-rules-service 'qdmr qdmr)}")

IMO this is too long and markety :) Also, I don't think you should mention
services in a package description.

> +    (home-page "https://dm3mat.darc.de/qdmr/")

Home-page usually goes directly before synopsis.

    -- (