unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 57031@debbugs.gnu.org
Subject: [bug#57031] [PATCH] scripts: Show a hint the first time some commands are run as root.
Date: Sun, 11 Sep 2022 14:05:28 +0100	[thread overview]
Message-ID: <CMTLE8655ZLJ.FFMSVME9LBAV@guix-aspire> (raw)
In-Reply-To: <87tu5l1q8g.fsf_-_@gnu.org>

Hey Ludo,

On Mon Sep 5, 2022 at 10:11 PM BST, Ludovic Courtès wrote:
> One nitpick: Could you make moving the hint code from shell.scm to
> ui.scm a separate commit?

Sure!

> > +         (display-hint (G_ "`guix pull' is user-specific, not system-wide;
> > +running it as root will only affect the `root' user.")))
>
> Please use Texinfo markup in hints: @command{guix pull}, etc.  (Likewise
> for the second hint.)

Oh, I didn't realize you could do that.

> > +(define* (guix-package* opts #:key (root-hint? #f))
> >    "Run the 'guix package' command on OPTS, an alist resulting for command-line
> > -option processing with 'parse-command-line'."
> > +option processing with 'parse-command-line'.  If ROOT-HINT? is #T, a hint is
> > +shown on the first usage of this procedure that informs users about Guix's
> > +support for per-user package management."
> >    (with-error-handling
> > +    (when (and root-hint?
> > +               (not (hint-given? 'package-root-hint))
> > +               (= (getuid) 0))
>
> Unless I’m mistaken, ‘root-hint?’ is always true; should we just remove
> it?

No, it's not always true; we don't use `#:root-hint #t' in `guix search' and
`guix show', so that `sudo guix show foobar' doesn't trigger the root hint.

> BTW, when running ‘sudo guix install’, the hint is going to
> ~root/.cache/guix, right?

Probably -.o.-

    -- (




  reply	other threads:[~2022-09-11 13:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-07 11:14 [bug#57031] [PATCH] scripts: Show a hint the first time some commands are run as root ( via Guix-patches via
2022-08-07 11:19 ` [bug#57031] [PATCH v2] " ( via Guix-patches via
2022-08-07 11:22   ` ( via Guix-patches via
2022-09-05 21:11   ` [bug#57031] [PATCH] " Ludovic Courtès
2022-09-11 13:05     ` ( via Guix-patches via [this message]
2022-09-11 19:59 ` [bug#57031] [PATCH v2 1/2] ui: Make one-time hint API public ( via Guix-patches via
2022-09-11 19:59   ` [bug#57031] [PATCH v2 2/2] scripts: Warn the first time pull or package is run as root ( via Guix-patches via
2022-10-26 18:14     ` zimoun
2022-10-27  5:52       ` ( via Guix-patches via
2022-10-27  8:23         ` zimoun
2022-10-28 14:33           ` ( via Guix-patches via
2022-10-27 19:42 ` [bug#57031] [PATCH v3 1/2] ui: Make one-time hint API public ( via Guix-patches via
2022-10-27 19:42   ` [bug#57031] [PATCH v3 2/2] scripts: Warn the first time pull or package is run as root ( via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CMTLE8655ZLJ.FFMSVME9LBAV@guix-aspire \
    --to=guix-patches@gnu.org \
    --cc=57031@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=paren@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).