From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UPAqF+59HGPNbAAAbAwnHQ (envelope-from ) for ; Sat, 10 Sep 2022 14:07:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id vnYTF+59HGOifQEAauVa8A (envelope-from ) for ; Sat, 10 Sep 2022 14:07:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DFB3E12270 for ; Sat, 10 Sep 2022 14:07:09 +0200 (CEST) Received: from localhost ([::1]:58214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWzGO-0003bi-U7 for larch@yhetil.org; Sat, 10 Sep 2022 08:07:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWzGI-0003ZW-8C for guix-patches@gnu.org; Sat, 10 Sep 2022 08:07:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48061) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWzGH-0002Un-VK for guix-patches@gnu.org; Sat, 10 Sep 2022 08:07:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oWzGH-0003P7-L0 for guix-patches@gnu.org; Sat, 10 Sep 2022 08:07:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44518] gnu: Add matterhorn. Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 10 Sep 2022 12:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44518 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: elaexuotee@wilsonb.com, 44518@debbugs.gnu.org X-Debbugs-Original-To: , Received: via spool by submit@debbugs.gnu.org id=B.166281161513074 (code B ref -1); Sat, 10 Sep 2022 12:07:01 +0000 Received: (at submit) by debbugs.gnu.org; 10 Sep 2022 12:06:55 +0000 Received: from localhost ([127.0.0.1]:36760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWzGB-0003Oo-HI for submit@debbugs.gnu.org; Sat, 10 Sep 2022 08:06:55 -0400 Received: from lists.gnu.org ([209.51.188.17]:43122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWzG7-0003Od-H9 for submit@debbugs.gnu.org; Sat, 10 Sep 2022 08:06:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWzG7-0003N3-0q for guix-patches@gnu.org; Sat, 10 Sep 2022 08:06:51 -0400 Received: from knopi.disroot.org ([178.21.23.139]:51806) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWzG4-0002Tr-Iw for guix-patches@gnu.org; Sat, 10 Sep 2022 08:06:50 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id F36744A021; Sat, 10 Sep 2022 14:06:45 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g2k1XTZ0Q5Rz; Sat, 10 Sep 2022 14:06:44 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1662811600; bh=Z5MjcK0tDUjQt4knxawY3nyw8PLGIrEXRbbbjRjVxYM=; h=Date:Subject:From:To:References:In-Reply-To; b=VPVZOOKeSqChQ2jNFCO/K8RyaB5622xRZwvejuOEVjht7jBHtSQwz7OZGznQS8JlJ DNeq8poJZyqH8hV6K4HSyns4v0/hW6gMZhtlZvs3jkF9vqYWpAUHddslNpLPQjqAuP VSwMQSGf5TinIDeX2iIzynn5eJ1AGZL3FK4YtPGsh2A54C7OOPBB13Uj9dcf3kzkAU Etug+/6k/RS5FnhIjvG94OrZM6rO6nwUgdFWFjEoL86zHSGihluFrC8XJ+l61H/FP3 chhiELN+t899fpx7bDtaKtgXJwvwzF5Fg3JGYl21ajqyOAcpKYZl3OziVwYcz7MC6v 9Xy/XQ0gaaxNA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 10 Sep 2022 13:06:40 +0100 Message-Id: References: <2674A0N1F01CQ.3GO4FVW1X3O76@wilsonb.com> In-Reply-To: <2674A0N1F01CQ.3GO4FVW1X3O76@wilsonb.com> Received-SPF: pass client-ip=178.21.23.139; envelope-from=paren@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_ONE_CHAR=1.224, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: "\(" X-ACL-Warn: , "\( via Guix-patches" From: "\( via Guix-patches" via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662811630; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=haDZpNeROaw2CJU/SixMAd9jxJeeaGf7oO7QNOgrGeE=; b=Dz0yI7Wtrfkpo20tbWt1G/PVqY/dT5FGVcKf7BjlmEQQDzXhTsBBeKX0c4pdHu0RmLnUbN IULOnxLfammfNnPanyOZmn/96UQP/rIuSKugR+MItPMgC+xerVliDb8QpXi7gmhO5B7TnL GNU3ynqMforjljkTs/TKxHJfjmIf06nsGIbcHX8MjH5Iw8dY5HAZ13oUOFvxCCFh72MJJS DYTuQQlwx2/bX3khtsW0D/ChyYix7z0bE8EQ29M045uBqyBNZ/+sAk2sWok9JPNoqS4G/L f1IPMS0ByOr4V0eFMHH5a2zp3ZYkwnQ6KBfeKdl50E+PVr7wX8WgB7r9N0go+w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662811630; a=rsa-sha256; cv=none; b=dgi26dkGQTjHc5YY001fF4b4nkxOzsgPinhPut1KX6q8yZdxcs/DQTn1oSfn0rI4KPxIQ4 UfEpfS8zo2iglaIBFVpilj4lH67N/JYFjEb2QfUS9lDH13N9w1kH6EqhCWL6ZP2gHIo/6H ZuBw/NiPAHgMu8+VD0e3KM+X4DMi1BHjzuTbYu2tI4621B6WqrFqQdKf/iagfpO66Ep3G6 7ho+y0iiwErWHJrelITtSKAeT+EY7ZfcMcj/KFJA61OGjZfUH3ZFKN65EA1jZXcYTLOkkY qbe13UnwdLn2qufeC1jqA4yTutY2AlZU6LgsZ1nVVjG2vAHFOPtpKaapdDvDBw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=VPVZOOKe; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.99 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=VPVZOOKe; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DFB3E12270 X-Spam-Score: -0.99 X-Migadu-Scanner: scn1.migadu.com X-TUID: EW2b5i76WKMv Hi, This patch must have slipped through the cracks, but it was mentioned on IRC today, so I decided to do a little review :) First of all, (1) You should have one commit per package. (2) It's better, though not required, to use the procedure described here[1= ] to send patches, instead of using attachments. This makes it much easie= r to annotate the patch with review comments, at least here in aerc :) [1] https://paste.sr.ht/~unmatched-paren/9114b1fa3d2088c7c71307dcae0d9e2b36= 20eb0c > + (inputs > + `(("ghc-random" ,ghc-random) > + ("ghc-quickcheck" ,ghc-quickcheck) > + ("ghc-semigroupoids" ,ghc-semigroupoids))) You should use the "new style" of inputs: > + (inputs > + (list ghc-random > + ghc-quickcheck > + ghc-semigroupoids)) Same for any native- and propagated- inputs. > + (arguments > + `(#:cabal-revision > + ("3" "1ndz5x6njl35h73il5c6qpaqd4ynvg21n6k7sb8aq09gfbg544d8"))) There's also a new arguments style: > + (arguments > + (list #:cabal-revision > + (list "3" "1ndz5x6njl35h73il5c6qpaqd4ynvg21n6k7sb8aq09gfbg544= d8"))) > + (description > + "This library is intended to be a comprehensive solution to parsing= and > +selecting quality-indexed values in HTTP headers. It is capable of pars= ing > +both media types and language parameters from the Accept and Content hea= der > +families, and can be extended to match against other accept headers as w= ell. > +Selecting the appropriate header value is achieved by comparing a list o= f > +server options against the quality-indexed values supplied by the client= .") This is a wee bit too long IMO. -- (