From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: elaexuotee@wilsonb.com, 44518@debbugs.gnu.org
Subject: [bug#44518] gnu: Add matterhorn.
Date: Sat, 10 Sep 2022 13:06:40 +0100 [thread overview]
Message-ID: <CMSPINIXM5VA.GR7957O7UF4M@guix-aspire> (raw)
In-Reply-To: <2674A0N1F01CQ.3GO4FVW1X3O76@wilsonb.com>
Hi,
This patch must have slipped through the cracks, but it was mentioned
on IRC today, so I decided to do a little review :)
First of all,
(1) You should have one commit per package.
(2) It's better, though not required, to use the procedure described here[1]
to send patches, instead of using attachments. This makes it much easier
to annotate the patch with review comments, at least here in aerc :)
[1] https://paste.sr.ht/~unmatched-paren/9114b1fa3d2088c7c71307dcae0d9e2b3620eb0c
> + (inputs
> + `(("ghc-random" ,ghc-random)
> + ("ghc-quickcheck" ,ghc-quickcheck)
> + ("ghc-semigroupoids" ,ghc-semigroupoids)))
You should use the "new style" of inputs:
> + (inputs
> + (list ghc-random
> + ghc-quickcheck
> + ghc-semigroupoids))
Same for any native- and propagated- inputs.
> + (arguments
> + `(#:cabal-revision
> + ("3" "1ndz5x6njl35h73il5c6qpaqd4ynvg21n6k7sb8aq09gfbg544d8")))
There's also a new arguments style:
> + (arguments
> + (list #:cabal-revision
> + (list "3" "1ndz5x6njl35h73il5c6qpaqd4ynvg21n6k7sb8aq09gfbg544d8")))
> + (description
> + "This library is intended to be a comprehensive solution to parsing and
> +selecting quality-indexed values in HTTP headers. It is capable of parsing
> +both media types and language parameters from the Accept and Content header
> +families, and can be extended to match against other accept headers as well.
> +Selecting the appropriate header value is achieved by comparing a list of
> +server options against the quality-indexed values supplied by the client.")
This is a wee bit too long IMO.
-- (
next prev parent reply other threads:[~2022-09-10 12:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 12:53 [bug#44518] gnu: Add matterhorn elaexuotee--- via Guix-patches via
2022-09-10 12:06 ` ( via Guix-patches via [this message]
2022-09-12 16:47 ` Maxime Devos
2022-11-04 15:11 ` Mathieu
2024-07-22 11:27 ` [bug#44518] [PATCH v3 00/25] Add matterhorn package Romain GARBAGE
2024-07-22 11:27 ` [bug#71938] [PATCH v3 01/25] gnu: Add ghc-crypton Romain GARBAGE
2024-07-22 11:27 ` [bug#44518] [PATCH v3 02/25] gnu: Add ghc-crypton-x509 Romain GARBAGE
2024-07-22 11:28 ` [bug#44518] [PATCH v3 03/25] gnu: Add ghc-crypton-x509-store Romain GARBAGE
2024-07-22 11:28 ` [bug#44518] [PATCH v3 04/25] gnu: Add ghc-crypton-x509-system Romain GARBAGE
2024-07-22 11:28 ` [bug#71938] [PATCH v3 05/25] gnu: Add ghc-crypton-x509-validation Romain GARBAGE
2024-07-22 11:28 ` [bug#44518] [PATCH v3 06/25] gnu: Add ghc-tls-1.9 Romain GARBAGE
2024-07-22 11:28 ` [bug#44518] [PATCH v3 07/25] gnu: Add ghc-crypton-connection Romain GARBAGE
2024-07-22 11:28 ` [bug#71938] [PATCH v3 08/25] gnu: Add ghc-mattermost-api Romain GARBAGE
2024-07-22 11:28 ` [bug#44518] [PATCH v3 09/25] gnu: Add ghc-mattermost-api-qc Romain GARBAGE
2024-07-22 11:28 ` [bug#71938] [PATCH v3 10/25] gnu: Add ghc-modern-uri Romain GARBAGE
2024-07-22 11:28 ` [bug#44518] [PATCH v3 11/25] gnu: Add ghc-aspell-pipe Romain GARBAGE
2024-07-22 11:28 ` [bug#71938] [PATCH v3 12/25] gnu: Add ghc-bimap Romain GARBAGE
2024-07-22 11:28 ` [bug#71938] [PATCH v3 13/25] gnu: Add ghc-checkers Romain GARBAGE
2024-07-22 11:28 ` [bug#71938] [PATCH v3 14/25] gnu: Add ghc-monad-parallel Romain GARBAGE
2024-07-22 11:28 ` [bug#44518] " Romain GARBAGE
2024-07-22 11:28 ` [bug#71938] [PATCH v3 15/25] gnu: ghc-text-zipper: Update to 0.13 Romain GARBAGE
2024-07-22 11:28 ` [bug#44518] [PATCH v3 16/25] gnu: Add ghc-stm-delay Romain GARBAGE
2024-07-22 11:28 ` [bug#44518] [PATCH v3 17/25] gnu: Add ghc-unique Romain GARBAGE
2024-07-22 11:28 ` [bug#44518] [PATCH v3 18/25] gnu: Add ghc-unix-compat-7 Romain GARBAGE
2024-07-22 11:28 ` [bug#71938] [PATCH v3 19/25] gnu: Add ghc-vty-crossplatform Romain GARBAGE
2024-07-22 11:28 ` [bug#71938] [PATCH v3 20/25] gnu: Add ghc-vty-unix Romain GARBAGE
2024-07-22 11:28 ` [bug#71938] [PATCH v3 21/25] gnu: Add ghc-vty-6 Romain GARBAGE
2024-07-22 11:28 ` [bug#44518] [PATCH v3 22/25] gnu: Add ghc-hclip Romain GARBAGE
2024-07-22 11:28 ` [bug#71938] [PATCH v3 23/25] gnu: Add ghc-brick Romain GARBAGE
2024-07-22 11:28 ` [bug#71938] [PATCH v3 24/25] gnu: Add ghc-brick-skylighting Romain GARBAGE
2024-07-22 11:28 ` [bug#71938] [PATCH v3 25/25] gnu: Add matterhorn Romain GARBAGE
2024-07-22 14:26 ` [bug#44518] [PATCH v3 00/25] Add matterhorn package Ricardo Wurmus
2024-07-22 22:31 ` bug#44518: " Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CMSPINIXM5VA.GR7957O7UF4M@guix-aspire \
--to=guix-patches@gnu.org \
--cc=44518@debbugs.gnu.org \
--cc=elaexuotee@wilsonb.com \
--cc=paren@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).