unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: "Ricardo Wurmus" <rekado@elephly.net>, <57257@debbugs.gnu.org>,
	<iyzsong@member.fsf.org>
Subject: [bug#57257] [PATCH 00/31] Update LXQt to 1.1.0
Date: Sun, 21 Aug 2022 12:03:33 +0100	[thread overview]
Message-ID: <CMBNNFRCREYU.3CAMETDP00FVO@guix-aspire> (raw)
In-Reply-To: <877d313lpw.fsf@elephly.net>

On Sun Aug 21, 2022 at 11:55 AM BST, Ricardo Wurmus wrote:
> - this diff looks wrong to me:
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
> index 08e33ca0e3..d2cbd1e131 100644
> --- a/gnu/packages/lxqt.scm
> +++ b/gnu/packages/lxqt.scm
> @@ -843,32 +843,31 @@ (define-public libfm-qt
>  (define-public pcmanfm-qt
>    (package
>      (name "pcmanfm-qt")
> […]
> +    (arguments
> +     (list
> +      #:tests? #f                       ; no tests
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-before 'configure 'patch-settings.conf.in
> +            (lambda* (#:key inputs #:allow-other-keys)
> +              (let ((wallpaper (search-input-file inputs
> +                                "share/lxqt/wallpapers/waves-logo.png")))
> --8<---------------cut here---------------end--------------->8---
>
>   Shouldn’t it be "/share/lxqt…"?

No, this use of search-input-file is correct.

    -- (




  reply	other threads:[~2022-08-21 11:04 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17  3:20 [bug#57257] [PATCH 00/31] Update LXQt to 1.1.0 iyzsong--- via Guix-patches via
2022-08-17  3:24 ` [bug#57257] [PATCH 01/31] gnu: lxqt-build-tools: Update to 0.11.0 iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 02/31] gnu: libqtxdg: Update to 3.9.1 iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 03/31] gnu: Add qtxdg-tools iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 04/31] gnu: liblxqt: Update to 1.1.0 iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 05/31] gnu: libsysstat: Update to 0.4.6 iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 06/31] gnu: lxqt-about: Update to 1.1.0 iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 07/31] gnu: lxqt-admin: " iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 08/31] gnu: lxqt-config: " iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 09/31] gnu: lxqt-globalkeys: " iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 10/31] gnu: lxqt-notificationd: " iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 11/31] gnu: lxqt-openssh-askpass: " iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 12/31] gnu: lxqt-panel: " iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 13/31] gnu: lxqt-policykit: " iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 14/31] gnu: lxqt-powermanagement: " iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 15/31] gnu: lxqt-qtplugin: " iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 16/31] gnu: lxqt-runner: " iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 17/31] gnu: lxqt-session: Update to 1.1.1, don't hardcode /run/current-system iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 18/31] gnu: lxqt-sudo: Update to 1.1.0 iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 19/31] gnu: lxqt-themes: " iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 20/31] gnu: libfm-qt: " iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 21/31] gnu: pcmanfm-qt: " iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 22/31] gnu: compton-conf: Remove patch-source phase iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 23/31] gnu: lximage-qt: Update to 1.1.0 iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 24/31] gnu: obconf-qt: Update to 0.16.2 iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 25/31] gnu: pavucontrol-qt: Update to 1.1.0 iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 26/31] gnu: qps: Update 2.5.0 iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 27/31] gnu: qtermwidget: Update to 1.1.0 iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 28/31] gnu: qterminal: " iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 29/31] gnu: screengrab: Update to 2.4.0 iyzsong--- via Guix-patches via
2022-08-17  3:24   ` [bug#57257] [PATCH 30/31] gnu: lxqt-archiver: Update to 0.6.0 iyzsong--- via Guix-patches via
2022-08-17  3:25   ` [bug#57257] [PATCH 31/31] gnu: lxqt-connman-applet: Remove patch-translations-dir phase iyzsong--- via Guix-patches via
2022-08-21 10:55 ` [bug#57257] [PATCH 00/31] Update LXQt to 1.1.0 Ricardo Wurmus
2022-08-21 11:03   ` ( via Guix-patches via [this message]
2022-08-22  0:55   ` 宋文武 via Guix-patches via
2022-08-22  1:07 ` bug#57257: " 宋文武 via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CMBNNFRCREYU.3CAMETDP00FVO@guix-aspire \
    --to=guix-patches@gnu.org \
    --cc=57257@debbugs.gnu.org \
    --cc=iyzsong@member.fsf.org \
    --cc=paren@disroot.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).