From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: <matf@disr.it>, <56994@debbugs.gnu.org>
Subject: [bug#56994] [PATCH] Add nmail
Date: Fri, 05 Aug 2022 13:30:19 +0100 [thread overview]
Message-ID: <CLY3H5RT7TGF.2D2ROQS8D6IIP@guix-aspire> (raw)
In-Reply-To: <24b34888cb54d3702eaeebf40267d910be9b54bb.1659666096.git.matf@disr.it>
Nice to see you got it working :) Some stylistic nits:
On Fri Aug 5, 2022 at 3:21 AM BST, wrote:
> From: M <matf@disr.it>
>
> ---
You need to write a commit message following the project's conventions. In
this case, it'd be something like:
> gnu: packages: Add nmail.
>
> * gnu/packages/mail.scm: Reorder module imports. Remove
> duplicate imports.
> (nmail): New variable.
Refer to <https://www.gnu.org/prep/standards/html_node/Change-Logs.html>.
(No, I don't like it much either :))
> + (arguments
> + (list #:phases #~(modify-phases %standard-phases
> + (replace 'check
> + (lambda*
> + (#:key tests? #:allow-other-keys)
> + (when tests? (invoke "ctest" "--output-on-failure")))))))
This part should be reformatted like this:
> (arguments
> (list #:phases
> #~(modify-phases %standard-phases
> (replace 'check
> (lambda* (#:key tests? #:allow-other-keys)
> (when tests?
> (invoke "ctest" "--output-on-failure")))))))
> + (inputs (list libetpan
> + xapian
> + sqlite
> + cyrus-sasl
> + ncurses
> + openssl
> + file
> + (list util-linux "lib")))
And this as:
> (inputs
> (list cyrus-sasl
> file
> ncurses
> openssl
> sqlite
> (list util-linux "lib")
> xapian))
> + (native-inputs (list pkg-config))
> + (home-page "https://github.com/d99kris/nmail")
> + (synopsis "Terminal-based email client")
> + (description
> + "@command{nmail} is a terminal-based email client with a
> +@code{ncurses} user interface similar to @code{alpine} and @code{pine}.")
> + (license license:expat)))
> +
> (define-public nullmailer
> (package
> (name "nullmailer")
> --
> 2.34.0
Other than that, LGTM! :)
-- (
prev parent reply other threads:[~2022-08-05 12:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 2:21 [bug#56994] [PATCH] Add nmail matf
2022-08-05 12:30 ` ( via Guix-patches via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CLY3H5RT7TGF.2D2ROQS8D6IIP@guix-aspire \
--to=guix-patches@gnu.org \
--cc=56994@debbugs.gnu.org \
--cc=matf@disr.it \
--cc=paren@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).