From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YBlxLrbA6mKFTwEAbAwnHQ (envelope-from ) for ; Wed, 03 Aug 2022 20:38:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id OBprLrbA6mJpMQAA9RJhRA (envelope-from ) for ; Wed, 03 Aug 2022 20:38:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6388C4673 for ; Wed, 3 Aug 2022 20:38:46 +0200 (CEST) Received: from localhost ([::1]:42148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJJGX-0001Js-Hl for larch@yhetil.org; Wed, 03 Aug 2022 14:38:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJJFr-0001Ii-1R for guix-patches@gnu.org; Wed, 03 Aug 2022 14:38:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60193) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJJFq-0004vr-J0 for guix-patches@gnu.org; Wed, 03 Aug 2022 14:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJJFq-000210-8d for guix-patches@gnu.org; Wed, 03 Aug 2022 14:38:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55903] [bug#56939] [PATCH 31/41] gnu: Add go-github-com-google-shlex. Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Aug 2022 18:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55903 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Maxime Devos" , <56939@debbugs.gnu.org>, <55903@debbugs.gnu.org> Received: via spool by 55903-submit@debbugs.gnu.org id=B55903.16595518367687 (code B ref 55903); Wed, 03 Aug 2022 18:38:02 +0000 Received: (at 55903) by debbugs.gnu.org; 3 Aug 2022 18:37:16 +0000 Received: from localhost ([127.0.0.1]:49940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJJF5-0001zt-Gx for submit@debbugs.gnu.org; Wed, 03 Aug 2022 14:37:15 -0400 Received: from knopi.disroot.org ([178.21.23.139]:56778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJJF0-0001zd-Gj; Wed, 03 Aug 2022 14:37:14 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 0FD9340DED; Wed, 3 Aug 2022 20:37:09 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tTGfRY52VkfA; Wed, 3 Aug 2022 20:37:07 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659551823; bh=GOzUi5IyMYDFJ8Nz2/OIPE70UHSGzoBGOQHeu0ezRvA=; h=Date:To:Subject:From:References:In-Reply-To; b=Rji8lXxmfP5rCin8Bha80dkOeuwSJwItQV3/glw9qKSuAmanpnFf8XtflraxAtbhV 7kaYAO2zAAg9z0zSUmtPmcIE2dzml7U+QLsx5ZAOU+NiMJetmztLFKpWJUeJK6aaWu zzySBFpAjte08C5eVjzydalYAp9bsSZYh88DbA5rNvl+Cfg5yUBXQGFyhRRVEa3L8G TlMNm7Vzw1JB7CTs+NE7iwcBdTTOoa5KCcx8CLGqqL2uRlX6r7KvLLbcZy+gVxb7xW DhOmoUqzSCfZbj59dkiHSjSZxFo7XdzDUegZVXIW/jm1s5xgKu9WRDbChCqRcEii+2 TcfCN87jOzPYw== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 03 Aug 2022 19:37:03 +0100 Message-Id: References: <20220803120439.5108-1-paren@disroot.org> <20220803120439.5108-31-paren@disroot.org> <402d1704-1f18-3b6c-b0a4-2e6ac771093f@telenet.be> In-Reply-To: <402d1704-1f18-3b6c-b0a4-2e6ac771093f@telenet.be> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: "\(" X-ACL-Warn: , "\( via Guix-patches" From: "\( via Guix-patches" via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659551926; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+Zf+9L2VOmkDPogShPShJtghLwvDA8gfF//GCyhcoHY=; b=rm/NjB/8n5VFyO4dlyeinXLK3jb545uL+uVfM3zGRVS0ZzwwUP+mIKN56YV+xDaJICHaNh DZ1nwZKxOsCSI9yOC8fTOWbblyJ0T6nmUl1Qm3t96bOI3FuPxxnuUHqLrWzdW6xWld9B6/ rvVdizOc4zK8JOhQWKWuxmc5NSpQVqmdjkcmkh8V4IxW3EqLxTZMyPVkmx5BOi0PqxJO4K TCs395nBID7ogr3TK24rrosEI+MnZzv/shjbt7D37sDxUhAvOICisgJGi1VaXxD5lNIDZn puTyLsjhRYd6I+KwmkxnVdaOfeSoENyYN9KHSSwSr29aI2XjB1sx9X/L5B79kg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659551926; a=rsa-sha256; cv=none; b=I8+2UqNqj6jISsuDXrCK/b6hBw8aUyu920MqjyPqIxXEQcXeZAE+0L2blTimkYG7+IoZgl BTe2xCkxb/Uy9y3yi6uSOsQ5gxaaW3+Q+H1on1swrC2JzbtViR+QfUfuir0KOHPjxSLkm0 ktKs/bAziuk387Eoqi25ttJ/AHidesYPIu3tq44QUM7HZG86VaPUR8+2QBoVlM4KZ5bQkk PQhFmrgZfT96a1PlEtn0Vz5hhO1wZ1oB7WZAaJx1nyXohgg6liBiYtrNFTMl/cT726Nuyi wSEWtyjpZlDL8pCjlGfjN0jxpnDBSnN04V8XlccpzFGylD3yBfy/NNxgfvk/rw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=Rji8lXxm; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=Rji8lXxm; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6388C4673 X-Spam-Score: -1.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: BMp/wD8KWdM1 On Wed Aug 3, 2022 at 4:38 PM BST, Maxime Devos wrote: > Can we just substitute* in the appropriate library reference or whatever= =20 > is the Go equivalent instead of propagating?=C2=A0 Maybe in in configList= .go,=20 > we can replace -lnotmuch by -l/gnu/store/.../libnotmuch.so or add a=20 > -L/gnu/store/... there? Good point! I'll try that. > > * gnu/packages/golang.scm (go-github-com-google-shlex): New variable. > > --- > > gnu/packages/golang.scm | 23 +++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm > > index fd2335b61a..9959dd118c 100644 > > --- a/gnu/packages/golang.scm > > +++ b/gnu/packages/golang.scm > > @@ -10720,3 +10720,26 @@ (define-public go-github-com-lithammer-fuzzyse= arch > > "A speedy fuzzy matching package for Go inspired by the JavaScri= pt > > library bevacqua/fuzzysearch.") > > (license license:expat))) > > + > > +(define-public go-github-com-google-shlex > > + (package > > + (name "go-github-com-google-shlex") > > + (version "0.0.0-20191202100458-e7afc7fbc510") > > Why has the commit and description been changed since=20 > ? The change in synopsis seems good=20 > to me though. I never referenced that issue in the making of this patchset :) I'll change its description to that issue's version if you wish. > Also, there are multiple patches adding go-github-com-google-shlex now=20 > -- as I've asked in the past, can we stop doing that, or at least add a= =20 > pointer to the previous version to avoid double work for reviewers?=20 > Likewise for: > > * https://issues.guix.gnu.org/search?query=3Dgo-google-golang-org-proto= buf > * https://issues.guix.gnu.org/search?query=3Dgo-github-com-xo-terminfo > * https://issues.guix.gnu.org/search?query=3Dgo-github-com-go-ini-ini > * https://issues.guix.gnu.org/search?query=3Dgo-github-com-emersion-go-= pgpmail > * [...] Maybe we could merge the patches adding those duplicate packages standalone, without merging the other parts of the patchsets, so there would be no need for anyone to write them again in the future. > (*) To be clear, I consider it unlikely for me to seriously review Go=20 > stuff in the future, as the Go world is full of forks that make no=20 > attempt to contribute back to upstream, or many independent=20 > implementations (see e.g. terminfo and shlex) where a single or maybe=20 > two implementations would suffice, often there's a lack of attempting=20 > backwards compatibility and version numbers are often just 0.0.0, ... I know what you mean. It's a huge pain. -- (