From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WLK4LbqTp2ICgQEAbAwnHQ (envelope-from ) for ; Mon, 13 Jun 2022 21:44:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8GqkLbqTp2IMGAAAauVa8A (envelope-from ) for ; Mon, 13 Jun 2022 21:44:58 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8833E2716E for ; Mon, 13 Jun 2022 21:44:58 +0200 (CEST) Received: from localhost ([::1]:33256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0pzd-0000YP-Gd for larch@yhetil.org; Mon, 13 Jun 2022 15:44:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0pyk-0008NA-Uy for guix-patches@gnu.org; Mon, 13 Jun 2022 15:44:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0pyk-00043n-Kc for guix-patches@gnu.org; Mon, 13 Jun 2022 15:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o0pyk-0003pX-GX for guix-patches@gnu.org; Mon, 13 Jun 2022 15:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55903] [PATCH v2 02/35] gnu: Add go-github-com-creack-pty. Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 13 Jun 2022 19:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55903 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Maxime Devos" , <55903@debbugs.gnu.org> Received: via spool by 55903-submit@debbugs.gnu.org id=B55903.165514943014694 (code B ref 55903); Mon, 13 Jun 2022 19:44:02 +0000 Received: (at 55903) by debbugs.gnu.org; 13 Jun 2022 19:43:50 +0000 Received: from localhost ([127.0.0.1]:60569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0pyX-0003ow-TJ for submit@debbugs.gnu.org; Mon, 13 Jun 2022 15:43:50 -0400 Received: from knopi.disroot.org ([178.21.23.139]:51648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0pyV-0003ol-Qv for 55903@debbugs.gnu.org; Mon, 13 Jun 2022 15:43:48 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 4931C43B7C; Mon, 13 Jun 2022 21:43:47 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oavhKMO5exdk; Mon, 13 Jun 2022 21:43:46 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1655149426; bh=xp/fYy5RA08Hwpo7FtEAmkeqyoVs4/fTzDyoXFsE1vo=; h=Date:Subject:From:To:References:In-Reply-To; b=JbR/HGJRACL4io9Nd+MAGbSNOQNbWLfP+JnJ4bfZJT7581OIEAIODUxmg2vrEMqQj jLr+Ncc7/2AmwciyTMeLoLtpG/Sz4Z3g+Dl2nBCPNpOV6oac23md7zvqb+zxpWQ7LA Jhuuo82WVeQ7rRFcBQ8S7fG7g+XXUzc87jS0JVsPQeKK3cnl7VXGaRdg7qVetKV0tR TwDZ3bJueFZ5aQCab0hoZHlZNfQM9zQRqbzj2kfT3pORlYLtvvDHGKJqmHDt4GCy0y hYFjI30VneH8x/K7/QJTBNJRL8WG3V1qt0Yxvmo1NcG+9T8vPbv9NfZQS7oPkDmU/K nTz1y/9ZZfBvw== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 13 Jun 2022 20:43:45 +0100 Message-Id: References: <20220613065634.25256-1-paren@disroot.org> <20220613065634.25256-2-paren@disroot.org> <3acc3feb4252d47ba76dea7099ba6d3cc9bf005b.camel@telenet.be> In-Reply-To: <3acc3feb4252d47ba76dea7099ba6d3cc9bf005b.camel@telenet.be> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: "\(" X-ACL-Warn: , "\( via Guix-patches" From: "\( via Guix-patches" via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655149498; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xp/fYy5RA08Hwpo7FtEAmkeqyoVs4/fTzDyoXFsE1vo=; b=srNj4+JvFTi3XgcgUU5rPL3z28xquWe4M0GBS3ZZ+SJOVqWatbXDkIzcg75lVfEweoSSDV nyp2/qR6/YyxE8jSXlXxaywvh8EcfFxlZbugOeWWDdNAP3d6HHuWrSMyTNZub9XzBL6hRR XARqqpv+GIn8aFvU9pVJofJxm7rB4Tf2l0B5iO909pB5G109PqPzGEErDuhiaWRoHnrDki twfiZdvppPFGfaCT/saoljCHxSKdQjTf1g6s0vQ0sw4Oa2BlZKJFBd3n3aB5HIuqdp4QIB hDukLZ0WYow/NGI46qXHbNfHPOu3YwJiMnAu+yr6hwjZYCu8ltwHYsiZ3FJXjQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655149498; a=rsa-sha256; cv=none; b=UMpKEHiJJnE9fhHZj7AWltNVgUsAEIDlMARxEN75+lJpDN5tXKQaA+JHUxBe3tdeore1uS b/fyP0ge4Z6hrp8JTKKLbIXFIo9kEKTQRosYTcug4OoJVBLAHuQuTO3sTKHi5C4HIm0my/ nl/tTSRl3B5r+/DVibtRdUakxevMVH6RfKWg9oqI7lcJqYhtTQlWr46XQ2wDoLkVPvBjCc xG98MloIQIWLVDUZrWAVdnSMDvGWcuL5U8XViir7OMkIPdkEWLK3P2NtoocU+yAiK45F/l k4DR0IAanlC1NEhFGmHhzK8cWq2F5hY+mg4GhMuB/0XpxW+dAq4hQ+MAOoeEVw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b="JbR/HGJR"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.59 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b="JbR/HGJR"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8833E2716E X-Spam-Score: -3.59 X-Migadu-Scanner: scn0.migadu.com X-TUID: Lp3zGRR914zB On Mon Jun 13, 2022 at 8:43 AM BST, Maxime Devos wrote: > This looks like 'go-target' in (guix build-system go)? > (Haven't looked at the rest of the revised patches) > [...] > You can avoid global state here by using call-with-output-file. Okay, I've addressed the issues you raised and made some last-minute formatting modifications. Thanks again for the review!