From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yLX3KkPdpWIMCQEAbAwnHQ (envelope-from ) for ; Sun, 12 Jun 2022 14:34:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id cC/0KkPdpWL+agEA9RJhRA (envelope-from ) for ; Sun, 12 Jun 2022 14:34:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5E45EEF7F for ; Sun, 12 Jun 2022 14:34:11 +0200 (CEST) Received: from localhost ([::1]:35316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0MnB-0007YQ-Uu for larch@yhetil.org; Sun, 12 Jun 2022 08:34:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0Mn4-0007YF-Fn for guix-patches@gnu.org; Sun, 12 Jun 2022 08:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32873) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0Mn4-0002bF-7q for guix-patches@gnu.org; Sun, 12 Jun 2022 08:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o0Mn4-0007Bm-2f for guix-patches@gnu.org; Sun, 12 Jun 2022 08:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55903] [PATCH 02/41] gnu: Add go-github-com-creack-pty. Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 12 Jun 2022 12:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55903 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Maxime Devos" , <55903@debbugs.gnu.org> Received: via spool by 55903-submit@debbugs.gnu.org id=B55903.165503720627587 (code B ref 55903); Sun, 12 Jun 2022 12:34:02 +0000 Received: (at 55903) by debbugs.gnu.org; 12 Jun 2022 12:33:26 +0000 Received: from localhost ([127.0.0.1]:55003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0MmT-0007At-Uv for submit@debbugs.gnu.org; Sun, 12 Jun 2022 08:33:26 -0400 Received: from knopi.disroot.org ([178.21.23.139]:56512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0MmS-0007Am-MT for 55903@debbugs.gnu.org; Sun, 12 Jun 2022 08:33:25 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 0487D43CE9; Sun, 12 Jun 2022 14:33:24 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pNTkISh55f1d; Sun, 12 Jun 2022 14:33:23 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1655037203; bh=b5rTKa/dN7jjRmF4Sj3hK7AjYGCk3xux1KUYSMJzV3Y=; h=Date:To:Subject:From:References:In-Reply-To; b=Hr/7xI7dIjIgPvi7wF5ivpM4PuLlvwhw46r6xzXPekAdl0bVRgO+u00nGRsJSSPRo GIyV0CDhOPHb/revaIevBwbL/M2nYNnx6QROqGxnCBYwZLNaZZo15MmJl0zzc4WXZF yt9X48FtV+3H1AIZ2tSlAQ/M+Bd/hT1QeABZMk0E4uuh4iRVIAHS+atPza/dNcuUcU 8FUbNL9fk9Q6gB6VW/+Urr5x77P0TKTqflfLw4r50Ii5WbIkGYO9I8zN3h7qhpvOWy Os3kZut780lG4x1n//0MMWYSfJMWSi7uR7UxmwFtxTQlZCLTVLqipPJgstV40BOFeU 4JDHrfu8YNiaQ== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 12 Jun 2022 13:33:22 +0100 Message-Id: References: <20220611191653.15471-1-paren@disroot.org> <20220611191653.15471-2-paren@disroot.org> <62368a0ba241a2d35115051cd6aa82efdf102407.camel@telenet.be> In-Reply-To: <62368a0ba241a2d35115051cd6aa82efdf102407.camel@telenet.be> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: "\(" X-ACL-Warn: , "\( via Guix-patches" From: "\( via Guix-patches" via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655037251; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=b5rTKa/dN7jjRmF4Sj3hK7AjYGCk3xux1KUYSMJzV3Y=; b=ru/iMDV5ZQqXr1/nvFIv0PFI0PCrVSDhce3rZcRdww24mpxa/lRGAg3wLBhDOAaOCsYe3M /ESeA4t5trcFLEYyp3aMTk6wRICcOUXlcu6NBHsYPOkEbvL2zvIxa6OSOdazVQdMMNm9ly TjyaF3QDvm0l1Nm6ZxeFVtsdDNp70eiqH73RHkhiaFidq61L2BEnf240mDuOrZCYPoVt3e wawZf25RnVq8Y/8NaL1zSnhf84kcqj6p5KQ3Xwz/LRH8LXX75vaekGx/xLr2jKEk+RzE7f iOFUOwWnA/tzY4TBMT26fkYQ8iYhZJVYzK9EdJovgN+Ii/6SDjFcfRFJgGQWqA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655037251; a=rsa-sha256; cv=none; b=lXjiUbcoyvYUrKSImbx3PKSVDDB3edjaVM3vDBKsMkVqZuFxVpkUpiu4vXPCFEaxjna75w oy2JhiA6v27HiUgjRFz7en2XZ0zqRcTzvx/HbEhuhe66Q5PjV1vpSUEls9TPNt7Hq+5iic c9wZjY1+hZjT2l4le0kb4nztR3PCn5RxpYoobLZFj2kYqv8XI4AqZhuKsoqHRXypUX+zkG Q0d2nvGIYbviP0CltpQbKFXizpaBUF4FGzHnMx8PDkAXS7Cxln1d0l/NWO2phPeKFdi7UZ 1cUHmggt24gTKiopZbkDypbtTJn7Wqu+HdXyGLhfFBw9LGjaoGfh37lhKwvbWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b="Hr/7xI7d"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.99 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b="Hr/7xI7d"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5E45EEF7F X-Spam-Score: -2.99 X-Migadu-Scanner: scn0.migadu.com X-TUID: 8QZ3F21JylzL On Sat Jun 11, 2022 at 11:38 PM BST, Maxime Devos wrote: > In the previous patch series, =E2=80=98go-git-sr-ht-sircmpwn-pty=E2=80=99= was used Presumably sircmpwn-pty was a temporary fork done for one reason or another. The go.mod now uses creack-pty. > Likewise, why the change from sircmpwn/aerc to ~rjarry/aerc? Drew DeVault stopped maintaining aerc, so rjarry forked it -.o.- > Likewise, why has the 'wrap-program' been dropped in aerc? Not sure why that wrap-program was there in the first place. Maybe aerc invoked some ncurses program at one point? Strange thing to do. Anyway, the PATH change isn't required anymore, so the wrap-program isn't either. aerc *does* invoke colordiff for displaying some messages, but I'm pretty sure that invoked programs shouldn't=20 > Please mention such things in the cover letter. This patchset was actually done from scratch; I didn't include any of the original code, and I hadn't actually looked at it, since aerc has changed quite a lot.