unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "King, Spencer via Guix-patches" via <guix-patches@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>,
	"74124-done@debbugs.gnu.org" <74124-done@debbugs.gnu.org>
Cc: "laurent.gatto@gmail.com" <laurent.gatto@gmail.com>,
	"zimon.toutoune@gmail.com" <zimon.toutoune@gmail.com>
Subject: [bug#74124] [PATCH] gnu: Add r-shinyvalidate.
Date: Fri, 3 Jan 2025 18:23:11 +0000	[thread overview]
Message-ID: <CH3PR02MB974602EDECD4A2135FC9D79390152@CH3PR02MB9746.namprd02.prod.outlook.com> (raw)
In-Reply-To: <87o70n69o4.fsf@elephly.net>

[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]

Hi Ricardo,

Thank you for the quick response. Is r-testthat now necessary across the board for all R packages? I do have a couple of other outstanding R patches that I can update if needed and ping the team.

Best,
Spencer
________________________________
From: Ricardo Wurmus <rekado@elephly.net>
Sent: Friday, January 3, 2025 12:20 PM
To: 74124-done@debbugs.gnu.org <74124-done@debbugs.gnu.org>
Cc: King, Spencer <spencer.king@wustl.edu>; laurent.gatto@gmail.com <laurent.gatto@gmail.com>; zimon.toutoune@gmail.com <zimon.toutoune@gmail.com>
Subject: [PATCH] gnu: Add r-shinyvalidate.

Hi Spencer,

> Pinging the R team since this patch has been unreviewed for a couple
> months. This is my first time pinging a specific team so please let me
> know if this is inappropriate or if there is something else I should
> do in the future.

My apologies for the delay.  I had not previously seen this patch.
Pinging the team (even much sooner than you did) is certainly the right
thing to do.  It is also recommended to Cc the team when submitting the
patch.  (I don't know if you've done that.)

I've just applied the patch and made a few minor changes, including the
addition of r-testthat, which is now necessary with changes to the
r-build-system.

--
Ricardo

[-- Attachment #2: Type: text/html, Size: 3078 bytes --]

  reply	other threads:[~2025-01-03 18:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 22:35 [bug#74124] [PATCH] gnu: Add r-shinyvalidate King, Spencer via Guix-patches via
2025-01-03 17:55 ` [bug#74124] King, Spencer via Guix-patches via
2025-01-03 18:20 ` bug#74124: [PATCH] gnu: Add r-shinyvalidate Ricardo Wurmus
2025-01-03 18:23   ` King, Spencer via Guix-patches via [this message]
2025-01-03 19:56     ` [bug#74124] " Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH3PR02MB974602EDECD4A2135FC9D79390152@CH3PR02MB9746.namprd02.prod.outlook.com \
    --to=guix-patches@gnu.org \
    --cc=74124-done@debbugs.gnu.org \
    --cc=laurent.gatto@gmail.com \
    --cc=rekado@elephly.net \
    --cc=spencer.king@wustl.edu \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).