From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:45812)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hXXH8-0005l7-3g
	for guix-patches@gnu.org; Sun, 02 Jun 2019 16:40:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hXX2M-0002n5-Gw
	for guix-patches@gnu.org; Sun, 02 Jun 2019 16:25:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:55661)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hXX2M-0002mx-DM
	for guix-patches@gnu.org; Sun, 02 Jun 2019 16:25:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hXX2M-0006Fd-6z
	for guix-patches@gnu.org; Sun, 02 Jun 2019 16:25:02 -0400
Subject: [bug#35935] [PATCH] guix: import: simplify recursive import
Resent-Message-ID: <handler.35935.B35935.155950705423970@debbugs.gnu.org>
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
From: Robert Vollmert <rob@vllmrt.net>
In-Reply-To: <87a7ez933m.fsf@gnu.org>
Date: Sun, 2 Jun 2019 22:23:56 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <CBFF786D-3925-46D1-95AF-D676A7F0D8F2@vllmrt.net>
References: <20190527200731.59990-1-rob@vllmrt.net> <87a7ez933m.fsf@gnu.org>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 35935@debbugs.gnu.org



> On 2. Jun 2019, at 21:52, Ludovic Court=C3=A8s <ludo@gnu.org> wrote:
> Robert Vollmert <rob@vllmrt.net> skribis:
>> * guix/import/utils.scm: Simplify recursive-import.
>                         ^
> Minor issue: please make sure to mention the modified entities here
> (procedures, variables, etc.); see
> <https://www.gnu.org/prep/standards/html_node/Change-Logs.html>.

Fixed, thanks for the heads up.

> I think Oleg worked on this part before; Oleg, could you comment
> and/or apply?
>=20
> =E2=80=98tests/import-utils.scm=E2=80=99 doesn=E2=80=99t seem to be =
testing this procedure,
> perhaps that=E2=80=99s something we should fix eventually.

Agreed. It does seem to be covered somewhat by tests/gem.scm.
I also tested it a bit by hand, with some haskell packages.