From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dma4D-0000KX-BA for guix-patches@gnu.org; Tue, 29 Aug 2017 02:32:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dma4A-0003hG-4I for guix-patches@gnu.org; Tue, 29 Aug 2017 02:32:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51358) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dma4A-0003hA-12 for guix-patches@gnu.org; Tue, 29 Aug 2017 02:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dma49-0002Oy-R9 for guix-patches@gnu.org; Tue, 29 Aug 2017 02:32:01 -0400 Subject: [bug#28185] [PATCH] build: emacs-build-system: Make the install phase more helpful. Resent-Message-ID: MIME-Version: 1.0 In-Reply-To: References: <20170822171303.21754-1-mail@cbaines.net> From: Jelle Licht Date: Tue, 29 Aug 2017 08:31:22 +0200 Message-ID: Content-Type: multipart/alternative; boundary="001a11465dd656369d0557de8f1b" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 28185@debbugs.gnu.org --001a11465dd656369d0557de8f1b Content-Type: text/plain; charset="UTF-8" 2017-08-29 8:25 GMT+02:00 Arun Isaac : > > Christopher Baines writes: > > > Modify the install phase to detect when nothing has been installed, and > error > > if this happens. This is preferable to continuing, and allowing the next > phase > > to fail. > > > > Also, when nothing can be found to be installed, print out each file > that was > > considered, along with the regular expressions that were used to include > and > > exclude it. > > > > * gnu/build/emacs-build-system.scm (install-file?): Add additional error > > checking and logging. > > --- > > guix/build/emacs-build-system.scm | 45 ++++++++++++++++++++++++++++-- > --------- > > 1 file changed, 32 insertions(+), 13 deletions(-) > > I feel that this adds a lot of complexity (lines of code) to the > emacs-build-system checking for an error that can be quite easily > identified and fixed otherwise. > > WDYT? Maybe, others can comment on this as well. > > > One the one hand, I agree with Arun, though errors in Guix can be a bit intimidating for newcomers. Do we want to focus on clear and correct error messages over concise code? --001a11465dd656369d0557de8f1b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


2017-08-29 8:25 GMT+02:00 Arun Isaac <arunisaac@systemreboot.= net>:

Christopher Baines writes:

> Modify the install phase to detect when nothing has been installed, an= d error
> if this happens. This is preferable to continuing, and allowing the ne= xt phase
> to fail.
>
> Also, when nothing can be found to be installed, print out each file t= hat was
> considered, along with the regular expressions that were used to inclu= de and
> exclude it.
>
> * gnu/build/emacs-build-system.scm (install-file?): Add additiona= l error
>=C2=A0 =C2=A0checking and logging.
> ---
>=C2=A0 guix/build/emacs-build-system.scm | 45 ++++++++++++++++++++= ++++++++-----------
>=C2=A0 1 file changed, 32 insertions(+), 13 deletions(-)

I feel that this adds a lot of complexity (lines of code) to the
emacs-build-system checking for an error that can be quite easily
identified and fixed otherwise.

WDYT? Maybe, others can comment on this as well.



One the one hand, I agree with Arun, t= hough errors in Guix can be a bit intimidating for newcomers.
Do we want to focus on clear and correct error messages over concise code?=

--001a11465dd656369d0557de8f1b--