unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Jelle Licht <jlicht@fsfe.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 27232@debbugs.gnu.org
Subject: [bug#27232] [PATCH] gnu: python-apsw: Build with all extensions.
Date: Thu, 27 Jul 2017 15:38:12 +0200	[thread overview]
Message-ID: <CAPsKtfL78HC9qPa8kFmvB-P4_4ORhwXM3D+oXRhdyXzzkc0tCA@mail.gmail.com> (raw)
In-Reply-To: <87lgnjwj6p.fsf@gnu.org>


[-- Attachment #1.1: Type: text/plain, Size: 641 bytes --]

I add this command in a phase after build, and adjusted the attached patch
accordingly.
If there are no further issues, I will commit this at the end of this week.


2017-07-20 11:29 GMT+02:00 Ludovic Courtès <ludo@gnu.org>:

> Hello,
>
> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
> > It works.  LGTM.
> >
> > I get the following message though:
> >
> >   Not doing LoadExtension test.  You need to compile the extension first
> >     gcc -fPIC -shared -o ./testextension.sqlext -I. -Isqlite3
> src/testextension.c
>
> Jelle, could you check and possibly commit this patch?
>
> Thanks!
>
> Ludo’.
>

[-- Attachment #1.2: Type: text/html, Size: 1092 bytes --]

[-- Attachment #2: 0001-gnu-python-apsw-Build-with-all-extensions.patch --]
[-- Type: text/x-patch, Size: 1282 bytes --]

From 3e2176ce3053c6aa6ec84352f417292ccf89e16e Mon Sep 17 00:00:00 2001
From: Jelle Licht <jlicht@fsfe.org>
Date: Sat, 22 Jul 2017 14:23:18 +0200
Subject: [PATCH] gnu: python-apsw: Build with all extensions.

* gnu/packages/python.scm (python-apsw)[phases]: Replace build phase; add flag
  to build all extensions. Add build-test-helper to allow testing of
  extensions.
---
 gnu/packages/python.scm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 7974dfa58..75046e845 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6025,6 +6025,16 @@ implementation of D-Bus.")
     (arguments
      `(#:phases
        (modify-phases %standard-phases
+         (replace 'build
+           (lambda _
+             (zero?
+              (system* "python" "setup.py" "build" "--enable-all-extensions"))))
+         (add-after 'build 'build-test-helper
+           (lambda _
+             (zero?
+              (system
+               (string-append "gcc -fPIC -shared -o ./testextension.sqlext"
+                              "-I. -Isqlite3 src/testextension.c") ))))
          (delete 'check)
          (add-after 'install 'check
            (lambda* (#:key inputs outputs #:allow-other-keys)
-- 
2.13.3


  reply	other threads:[~2017-07-27 13:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-04 12:49 bug#27232: [PATCH] gnu: python-apsw: Build with all extensions Jelle Licht
2017-06-04 16:19 ` Danny Milosavljevic
2017-07-20  9:29   ` [bug#27232] " Ludovic Courtès
2017-07-27 13:38     ` Jelle Licht [this message]
2017-09-08 15:51     ` Ludovic Courtès
2017-09-10 23:16       ` bug#27232: " Jelle Licht
2017-07-07 14:54 ` [bug#27232] " Ludovic Courtès
2017-07-08  0:10   ` Jelle Licht
2017-07-08 16:16     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPsKtfL78HC9qPa8kFmvB-P4_4ORhwXM3D+oXRhdyXzzkc0tCA@mail.gmail.com \
    --to=jlicht@fsfe.org \
    --cc=27232@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).