From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 0Nz8GbISAGf1GQAA62LTzQ:P1 (envelope-from ) for ; Fri, 04 Oct 2024 16:07:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 0Nz8GbISAGf1GQAA62LTzQ (envelope-from ) for ; Fri, 04 Oct 2024 18:07:14 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="Goyg/hrI"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=ZYb2V5Pb; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728058034; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=qFAPCt4B+CCpUMhapFuousGaIixEDvzDPKFloTAi5lQ=; b=mfyWPgmJjMT4nr+L/t6Pw8P4EXq4KPN6uUgO6Ff/E4mtCUbW/PXe49eeaiLKDBS+FTqwp1 y+CcQX93FpNjRNCTNv/qq7vN5K9KlZpP+I+nsN86KGRCHXTn2Hx1VTE537LX5IEWSPIUvQ EyS6ThjV4SNwP0ma2um8PcmK02gYogfF7sdNHJ/n5G3z5Avoa3EzoAw5KWmvrQgvc4H4wl QdT2AM9FQxixGWMcIzznqLYY1dC5/Bxw5l2hsOC7VzulsWPy3AmWoG2A1xx65h43qzHrFB ydG5vbrNRNuLgEtVNuayvvADNZ6gkN2KqH9uRJScX4uM9OHLiAYr6t9YafUBJg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="Goyg/hrI"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=ZYb2V5Pb; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728058034; a=rsa-sha256; cv=none; b=MBB/82bbzKAv19DtFTpBpTMmmqzyqWSM8LRPEdYV37DAt/pbypyhITI+LkRgxrrZrqsWbb cyLa9MhzLXVCV6ntKG2zJ2vvQjKPz1iuu87wu41CUJinR2r7ZrDtA7ZOfHCTLlDCGPy65d krDKyMpt8XcDJefeAjoPttlh5/mIKLLfcWs3ybZmWZkJVa0SIGl9zbneK9SzA9nQ2+jrS6 6q0hEfT5EeEPcz6Qy4EbbMdwSxK5wpUMIQKQKNg866TsskzhQnAvcjSg0oObFB56e+eo+4 bQO9p6huqSVq1SrBREn3G96UGndSOOxBrd7g4TCt4y6Qn7xg+zZV82Z5QNx/Ng== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C2F427DEE8 for ; Fri, 04 Oct 2024 18:07:13 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swkpY-0004Ih-RE; Fri, 04 Oct 2024 12:07:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swkpX-0004B3-5a for guix-patches@gnu.org; Fri, 04 Oct 2024 12:06:59 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1swkpW-0002Qk-SE for guix-patches@gnu.org; Fri, 04 Oct 2024 12:06:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=qFAPCt4B+CCpUMhapFuousGaIixEDvzDPKFloTAi5lQ=; b=Goyg/hrIRn3TSUF37ZrGQ8Z9/PyTzqC6+/cgjVUVVxfq+6QCa9UmKL1LWiTkWu7/2sTqEMWuGVDbjTaiD+Fs6BxQrpRz36FFo4NwjRrU4jz3K1haGLvgTj5xKK8S7TyDJToU01GazwMCBYRnQmmjOYaoGHVa+rZDeOzrRsc5pbfv6gFE9jxLw5Lwu7Bk+BqDnuY1JzthmXfi5cRAnRoHuE9qSPrWOJb/Yq3+oh65HO6vq68OTxMzv+Oldj5QxGva48wXwYrYXS82gMTf4YaNS+9hMv9POcTHOWndOWPkRn36CkGCMRwiHMApjRyyLzbhcCuGAX7dMzrsKA5nYFb2tg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1swkpZ-0006IE-Pk for guix-patches@gnu.org; Fri, 04 Oct 2024 12:07:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73135] [PATCH] Enable parallel tests for GTK Resent-From: The Man Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 04 Oct 2024 16:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73135 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 73135@debbugs.gnu.org Received: via spool by 73135-submit@debbugs.gnu.org id=B73135.172805801824179 (code B ref 73135); Fri, 04 Oct 2024 16:07:01 +0000 Received: (at 73135) by debbugs.gnu.org; 4 Oct 2024 16:06:58 +0000 Received: from localhost ([127.0.0.1]:36325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swkpW-0006Hu-5h for submit@debbugs.gnu.org; Fri, 04 Oct 2024 12:06:58 -0400 Received: from mail-oo1-f53.google.com ([209.85.161.53]:56608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swkpU-0006Hi-Qg for 73135@debbugs.gnu.org; Fri, 04 Oct 2024 12:06:57 -0400 Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-5e7a6de541cso1084218eaf.1 for <73135@debbugs.gnu.org>; Fri, 04 Oct 2024 09:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728057947; x=1728662747; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qFAPCt4B+CCpUMhapFuousGaIixEDvzDPKFloTAi5lQ=; b=ZYb2V5PbqVICM1Z3GxS3ourazJy/vI6+ru6jd9xw+xVLliUeSNdA3n+Dneo9bUWI6x sEIdjLxSjM/Rkx4Pqyqt8ZU+vo2zvYQrnH+qeJck6pAuKMTDcwTdRX5uF1LMZTwCJ7r8 KEJZhgXJAep3zJVGjIbvhsLb1C8VyuHwd1vnAj36HLEC2e00ShEK41tdjAvoP562sYFr jLE72a3df6/5Piw2irBaXH2Sn6dEEv1GMYMkh8fSGLJvK14iPU6O3cCpHnzvB1bjxd8S osgkIrcRuwmOBjYVOy48EE5bdDbcXP6wyk8Z//4WkUhXPBbISYucPeDhZzTnKNryPFUb mlQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728057947; x=1728662747; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qFAPCt4B+CCpUMhapFuousGaIixEDvzDPKFloTAi5lQ=; b=D6VsmS3mn9ebHVgw/QQ87X2vnyYaLzZu36CcH1v4nP0mDWRLyoZWTX6P4fGaMwXahC hGUtHHh/pM3Eh3ntf/6hBJkm38zHfPXHjT58puBNTmnrwwr4Zmgt8RQmMESLLfjfEvTM vXvxxn6t7c8TwiNCWStQ9f3Ti359DdLJqZQpGXxDFOmVytdZxxLfbiFA8nCGm6Dwr1W/ ZJZiuG3W3tF+66QSQfsfTjSnnzeIvk1wUI1eGQ456JgACb6CSv5mMwkc5r0uIImAoXVc aNYQ338ClXdfT63gDwgQZYvQ+j7nNvn5P9f3Lsg5EZR1+0Kycx8CwmpVrNASFRh9X7up PLoA== X-Gm-Message-State: AOJu0YzjqFSvIFXs8prbyX1R51q9kylpbJFYgET0DdICMUUTkWh/1t1G L2fUEdyuZtB6WpdkqrYqxaM4XS/TkmjE2U6DEnHM/+JWmvL4HtCOEfAz9x1179U0NS9/xPYNzWl j10JVADSS8lHeVCHEtJ634muIaaU= X-Google-Smtp-Source: AGHT+IEORnU4+eLAZrCZdJDvz4W++VHRMoHqU3+LmlLd5hROHW6kyD5LqlCtXkHpvYw1m0MFKIUg89eWQRGzlm0njBY= X-Received: by 2002:a05:6870:638a:b0:261:16da:decb with SMTP id 586e51a60fabf-287c1da6282mr2225044fac.11.1728057947388; Fri, 04 Oct 2024 09:05:47 -0700 (PDT) MIME-Version: 1.0 References: <8734lbsxw4.fsf@gnu.org> In-Reply-To: <8734lbsxw4.fsf@gnu.org> From: The Man Date: Fri, 4 Oct 2024 11:05:33 -0500 Message-ID: Content-Type: multipart/alternative; boundary="0000000000001b15220623a8d896" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 2.96 X-Spam-Score: 2.96 X-Migadu-Queue-Id: C2F427DEE8 X-TUID: YRemIng7UFDO --0000000000001b15220623a8d896 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sounds like a good idea to me. On Fri, Oct 4, 2024, 10:14 AM Ludovic Court=C3=A8s wrote: > Hi, > > The Man skribis: > > > In the middle of testing a set of patches that caused a large number of > > rebuilds, I noticed the gtk package was taking an obscenely long time t= o > > run checks. Upon inspection I found out it was not running tests as > > parallel. > > For example, https://ci.guix.gnu.org/build/5623913/details took >3000! > > seconds. > > The fix is obvious and will save time on future rebuilds. > > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm > > index 3d4766713d..f0f6a0cd9a 100644 > > --- a/gnu/packages/gtk.scm > > +++ b/gnu/packages/gtk.scm > > @@ -1195,6 +1195,7 @@ (define-public gtk > > (string=3D? (%current-system) > "aarch64-linux")) > > "--no-suite=3Dwayland_gles2_failing= " > > "--no-suite=3Dwayland_gles_failing"= )) > > + #:parallel-tests? #t > > I wonder why #:parallel-tests? defaults to #f in =E2=80=98meson-build-sys= tem=E2=80=99, > contrary to what other build systems do. > > I think we should create a branch where we change it to #t, and merge it > once we=E2=80=99re done rebuilding all the packages and fixing any releva= nt > failure. > > Would you like to give that a try? > > Thanks, > Ludo=E2=80=99. > --0000000000001b15220623a8d896 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Sounds like a good idea to me.


On Fri= , Oct 4, 2024, 10:14 AM Ludovic Court=C3=A8s <ludo@gnu.org> wrote:
H= i,

The Man <squishypinkelephant@gmail.com> skribis:

> In the middle of testing a set of patches that caused a large number o= f
> rebuilds, I noticed the gtk package was taking an obscenely long time = to
> run checks. Upon inspection I found out it was not running tests as > parallel.
> For example, https://ci.guix.gnu.org/bu= ild/5623913/details took >3000!
> seconds.
> The fix is obvious and will save time on future rebuilds.
> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> index 3d4766713d..f0f6a0cd9a 100644
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -1195,6 +1195,7 @@ (define-public gtk
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 (string=3D? (%current-system) "aarch64-linux"))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"--no-su= ite=3Dwayland_gles2_failing"
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"--no-su= ite=3Dwayland_gles_failing"))
> +=C2=A0 =C2=A0 =C2=A0 #:parallel-tests? #t

I wonder why #:parallel-tests? defaults to #f in =E2=80=98meson-build-syste= m=E2=80=99,
contrary to what other build systems do.

I think we should create a branch where we change it to #t, and merge it once we=E2=80=99re done rebuilding all the packages and fixing any relevant=
failure.

Would you like to give that a try?

Thanks,
Ludo=E2=80=99.
--0000000000001b15220623a8d896--