unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: The Man <squishypinkelephant@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 73135@debbugs.gnu.org
Subject: [bug#73135] [PATCH] Enable parallel tests for GTK
Date: Fri, 4 Oct 2024 11:05:33 -0500	[thread overview]
Message-ID: <CAPfwWahp2=ULn8v22ZcW-m7nqzjT=R3Sspc+yWpjKucGOGyAcA@mail.gmail.com> (raw)
In-Reply-To: <8734lbsxw4.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1420 bytes --]

Sounds like a good idea to me.

On Fri, Oct 4, 2024, 10:14 AM Ludovic Courtès <ludo@gnu.org> wrote:

> Hi,
>
> The Man <squishypinkelephant@gmail.com> skribis:
>
> > In the middle of testing a set of patches that caused a large number of
> > rebuilds, I noticed the gtk package was taking an obscenely long time to
> > run checks. Upon inspection I found out it was not running tests as
> > parallel.
> > For example, https://ci.guix.gnu.org/build/5623913/details took >3000!
> > seconds.
> > The fix is obvious and will save time on future rebuilds.
> > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> > index 3d4766713d..f0f6a0cd9a 100644
> > --- a/gnu/packages/gtk.scm
> > +++ b/gnu/packages/gtk.scm
> > @@ -1195,6 +1195,7 @@ (define-public gtk
> >                                          (string=? (%current-system)
> "aarch64-linux"))
> >                                     "--no-suite=wayland_gles2_failing"
> >                                     "--no-suite=wayland_gles_failing"))
> > +      #:parallel-tests? #t
>
> I wonder why #:parallel-tests? defaults to #f in ‘meson-build-system’,
> contrary to what other build systems do.
>
> I think we should create a branch where we change it to #t, and merge it
> once we’re done rebuilding all the packages and fixing any relevant
> failure.
>
> Would you like to give that a try?
>
> Thanks,
> Ludo’.
>

[-- Attachment #2: Type: text/html, Size: 2069 bytes --]

  reply	other threads:[~2024-10-04 16:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09  0:55 [bug#73135] [PATCH] Enable parallel tests for GTK The Man
2024-10-04 15:14 ` Ludovic Courtès
2024-10-04 16:05   ` The Man [this message]
2024-10-05 12:36     ` Maxim Cournoyer
2024-10-12  5:34       ` bug#73135: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPfwWahp2=ULn8v22ZcW-m7nqzjT=R3Sspc+yWpjKucGOGyAcA@mail.gmail.com' \
    --to=squishypinkelephant@gmail.com \
    --cc=73135@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).