From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEGyR-0002ME-01 for guix-patches@gnu.org; Sun, 21 Oct 2018 12:53:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gEGyM-0002fz-14 for guix-patches@gnu.org; Sun, 21 Oct 2018 12:53:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:58509) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gEGyL-0002ft-SZ for guix-patches@gnu.org; Sun, 21 Oct 2018 12:53:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gEGyL-0000mC-Ns for guix-patches@gnu.org; Sun, 21 Oct 2018 12:53:01 -0400 Subject: [bug#33099] [PATCH] I add r-aspi package appended to cran.scm file Resent-Message-ID: MIME-Version: 1.0 References: <8736t12frf.fsf@mdc-berlin.de> <87zhv81etw.fsf@mdc-berlin.de> In-Reply-To: <87zhv81etw.fsf@mdc-berlin.de> From: Laura Lazzati Date: Sun, 21 Oct 2018 13:52:06 -0300 Message-ID: Content-Type: multipart/alternative; boundary="0000000000001752330578bff7d9" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: =?UTF-8?Q?G=C3=A1bor?= Boskovits , 33099@debbugs.gnu.org --0000000000001752330578bff7d9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi! On Sat, Oct 20, 2018 at 6:35 PM Ricardo Wurmus wrote: > > Hi Laura, > > > I will apply all the changes and send the new version. > > Shall I send the modified patch to the debbugs mail that is in the CC o= f > > this mail? > > Yes, please. > > >> > > > > + (synopsis "Analysis of Symmetry of Parasitic Infections") > >> > > > > >> > > > Please use lowercase for all words except for the first. CRAN > >> synopses > >> > > > are usually in titlecase and the importer can=E2=80=99t automati= cally > figure > >> out > >> > > > which words should be converted, so this needs to be done > manually. > >> > > Sorry for this, I just copied the comments in cran's website, I'll chan= ge > > that. > > Did you not use the CRAN importer to generate this package definition? > If you did not then you=E2=80=99re in for a treat as =E2=80=9Cguix import= cran -r=E2=80=9D can > *recursively* generate package definitions for packages on CRAN, even if > there are dozens of dependencies. > I don't understand this part. I ran the commands but complains for few arguments. Ran guix import cran --help and read the doc. I can apply guix import cran -r p but not to whole r, don't know if that's OK to get the template. Or if it was OK running emacs cran.scm to make changes and then I should run guix import cran -r r-aspi to check everything is alright. As regards the other changes, I've already applied them to the r-aspi definiton. > >> > > > > + (license license:gpl3))) > >> > > > > >> > > > I checked the source files and noticed that it=E2=80=99s actuall= y GPL 3 or > >> > > > later. Here=E2=80=99s an except from the header of aspi.R: > >> > > I guess this mistake was because in one of the several times of running > > ./pre-inst-env guix build r-aspi I was getting an error about the gpl > > licence. I will change this too. > > If you used the importer this is not your fault. On CRAN the license is > listed as =E2=80=9CGPL-3=E2=80=9D which the importer turns into =E2=80=9C= gpl3=E2=80=9D. Often people > declare the license as just a single version even though their own > license headers permit later versions. > > PS: please try to reduce the amount of text you quote in replies. It=E2= =80=99s > best to only leave the relevant parts that you=E2=80=99re replying to :) > > -- > Ricardo > Regards :) Laura --0000000000001752330578bff7d9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

On Sat, Oct 20, 2018 at 6:35 PM Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

Hi Laura,

> I will apply all the changes and send the new version.
> Shall I send the modified patch to the debbugs mail that is in the CC = of
> this mail?

Yes, please.

>> > > > > +=C2=A0 =C2=A0 (synopsis "Analysis of Sym= metry of Parasitic Infections")
>> > > >
>> > > > Please use lowercase for all words except for the f= irst.=C2=A0 CRAN
>> synopses
>> > > > are usually in titlecase and the importer can=E2=80= =99t automatically figure
>> out
>> > > > which words should be converted, so this needs to b= e done manually.
>>
> Sorry for this, I just copied the comments in cran's website, I= 9;ll change
> that.

Did you not use the CRAN importer to generate this package definition?
If you did not then you=E2=80=99re in for a treat as =E2=80=9Cguix import c= ran -r=E2=80=9D can
*recursively* generate package definitions for packages on CRAN, even if there are dozens of dependencies.
I don't understa= nd this part. I ran the commands but complains for few arguments.
Ran guix import cran --help and read the doc.
I can apply g= uix import cran -r p<SOMEPACKAGE> but not to whole r, don't know = if that's OK to get the template.
Or if it was OK running= emacs cran.scm to make changes and then I should run guix import cran -r r= -aspi to check everything is alright.
As regards the other change= s, I've already applied them to the r-aspi definiton.
>> > > > > +=C2=A0 =C2=A0 (license license:gpl3)))
>> > > >
>> > > > I checked the source files and noticed that it=E2= =80=99s actually GPL 3 or
>> > > > later.=C2=A0 Here=E2=80=99s an except from the head= er of aspi.R:
>>
> I guess this mistake was because in one of the several times of runnin= g
> ./pre-inst-env guix build r-aspi I was getting an error about the gpl<= br> > licence. I will change this too.

If you used the importer this is not your fault.=C2=A0 On CRAN the license = is
listed as =E2=80=9CGPL-3=E2=80=9D which the importer turns into =E2=80=9Cgp= l3=E2=80=9D.=C2=A0 Often people
declare the license as just a single version even though their own
license headers permit later versions.

PS: please try to reduce the amount of text you quote in replies.=C2=A0 It= =E2=80=99s
best to only leave the relevant parts that you=E2=80=99re replying to :)
--
Ricardo
Regards :)
Laura
--0000000000001752330578bff7d9--