unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrew Whatson <whatson@gmail.com>
To: Thiago Jung Bauermann <bauermann@kolabnow.com>
Cc: 50131@debbugs.gnu.org
Subject: [bug#50131] [PATCH 3/3] gnu: Generate man pages for lxc.
Date: Fri, 27 Aug 2021 04:21:06 +0000	[thread overview]
Message-ID: <CAPE069cHUmXRM1dMTZ88HTkBxx8y3HP9gyEjVZOHmUjifN0izQ@mail.gmail.com> (raw)
In-Reply-To: <2518271.n39fte1hqX@popigai>

On Thu, 26 Aug 2021 at 15:37, Thiago Jung Bauermann
<bauermann@kolabnow.com> wrote:
>
> There’s no need to pass the prefix argument. ‘gnu-build-system’ already
> does it.

Thanks, fixed in the revised patch.

> > +         (add-before 'configure 'patch-docbook-dtd
> > +           (lambda _
> > +             ;; Fix incorrect DocBook DTD
> > +             (substitute* "configure"
> > +               (("\\\\\"-//Davenport//DTD DocBook V3\\.0//EN\\\\\"")
> > +                "\\\"-//OASIS//DTD DocBook XML\\\"
> > \\\"http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd\\\""))))
>
> Has this fix been submitted upstream, or is it already available in a newer
> lxc version? Ideally, we wouldn’t have to carry this change indefinitely.

The lxc configure script checks for both db2x_docbook2man and
docbook2man (in that order).  If it finds docbook2man, it assumes this
is an older tool and formats the documents with the wrong DTD.  I've
revised the docbook2x package to provide a db2x_docbook2man symlink as
it's possible other packages using docbook2x will make the same
assumption.  This means patching configure is no longure required.

> The same question would apply to the substitutions made in docbook2x, but
> that project seems abandoned so there’s no point.

Similar fixes for docbook2x are found in the arch & nix builds, and
actually some have been incorporated into its CVS repo but never been
released.  I haven't tried to get in touch with upstream, but I guess
it's worth a shot.

Thanks!




  reply	other threads:[~2021-08-27  4:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 12:03 [bug#50131] [PATCH 0/3] Add docbook2x and generate lxc man pages Andrew Whatson
2021-08-20 12:09 ` [bug#50131] [PATCH 1/3] gnu: Prefix licenses in docbook module Andrew Whatson
2021-08-20 12:09   ` [bug#50131] [PATCH 2/3] gnu: Add docbook2x Andrew Whatson
2021-08-26 15:36     ` Thiago Jung Bauermann via Guix-patches via
2021-08-20 12:09   ` [bug#50131] [PATCH 3/3] gnu: Generate man pages for lxc Andrew Whatson
2021-08-26 15:49     ` Thiago Jung Bauermann via Guix-patches via
2021-08-27  4:21       ` Andrew Whatson [this message]
2021-08-27  4:15   ` [bug#50131] [PATCH 2/3 v2] gnu: Add docbook2x Andrew Whatson
2021-08-27  4:15   ` [bug#50131] [PATCH 3/3 v2] gnu: Generate man pages for lxc Andrew Whatson
2021-08-27 17:48     ` Thiago Jung Bauermann via Guix-patches via
2021-09-13 10:30       ` bug#50131: [PATCH 0/3] Add docbook2x and generate lxc man pages Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPE069cHUmXRM1dMTZ88HTkBxx8y3HP9gyEjVZOHmUjifN0izQ@mail.gmail.com \
    --to=whatson@gmail.com \
    --cc=50131@debbugs.gnu.org \
    --cc=bauermann@kolabnow.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).