From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 4J61OfjhPmU0hAEAG6o9tA:P1 (envelope-from ) for ; Sun, 29 Oct 2023 23:51:37 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 4J61OfjhPmU0hAEAG6o9tA (envelope-from ) for ; Sun, 29 Oct 2023 23:51:37 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 891523A851 for ; Sun, 29 Oct 2023 23:51:36 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=deeplinks-com.20230601.gappssmtp.com header.s=20230601 header.b=s+YswbjX; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698619896; a=rsa-sha256; cv=none; b=DJTwOD0kUqHi/vTH4IgdKvkyctAWkYqd9wsMzD3Be9hbKhMU2Y3oyj29ECMlsF0Nt0Hi0/ J8N7581qXVo5BLVx+Ym2HLgy9jaMqlR/3qcyPRvaig83W8lTLJIa0cEqxFXCGEZs1p0cj2 X0Szb4hvzI4/SGHRa0vx4Pdv8PiN8zNG4uBiPih+m8U28SLfJJMcSVrrmXM2+53MbNx/aW SAazwATIaBNayG6T0vyYhM+qLOVj2nXJ45Lg5KPr5+No6jniNiTS5V/K5NXi57DhAr9QfN PV88aNJ+ysJ5lWqt5UFQbTAKsWn2yXGoSawr8odJLa6n03ZYnzNpQsLAQ5J68g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698619896; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=u5DkL/+3McTPZd2TpZqyZgHizOF2x6G7lkPUcYPleXQ=; b=jOidpUvgE4GOIEOqyFfJu3+/TjpZAu1CcFmlkbOd6JeDgqKe1jCbbP+FLQ12c1YVcdayoA x6d0fBqinDfqXEha7hPI0uny7SLw7X370d7/vF/mK9iFYoU9LW22fQhet9Sqc3bnWuveIr CRVOVUhjCo94y3wASg51wu5b+oK/EU/XXv/0ieS6H9kKLtf+GIaY9jUDhaS/drBOcBtTmB usLaqgHynpbjagI8iUebtOaTLY5q4kY/t3zublk61XD4eUF9vUnCYk99IwSrINJwh5+WEP hlMCkcx3HJZB2DXInorDqOKwkaqJe1qR5oucQrsaHtTa3FL8VJYfPLtUgkQFAg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=deeplinks-com.20230601.gappssmtp.com header.s=20230601 header.b=s+YswbjX; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxE4P-0002B8-Nr; Sun, 29 Oct 2023 18:15:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxE49-00028K-Mz for guix-patches@gnu.org; Sun, 29 Oct 2023 18:15:30 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qxE49-0001uD-F3 for guix-patches@gnu.org; Sun, 29 Oct 2023 18:15:29 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qxE4g-0005t2-6w for guix-patches@gnu.org; Sun, 29 Oct 2023 18:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66801] [PATCH va3e5ae0f..37252e07 01/32] rebar-build-system and packages. Resent-From: Pierre-Henry =?UTF-8?Q?Fr=C3=B6hring?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 29 Oct 2023 22:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66801 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 66801@debbugs.gnu.org Received: via spool by 66801-submit@debbugs.gnu.org id=B66801.169861773922575 (code B ref 66801); Sun, 29 Oct 2023 22:16:02 +0000 Received: (at 66801) by debbugs.gnu.org; 29 Oct 2023 22:15:39 +0000 Received: from localhost ([127.0.0.1]:43976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxE4J-0005rz-2k for submit@debbugs.gnu.org; Sun, 29 Oct 2023 18:15:39 -0400 Received: from mail-yw1-x1134.google.com ([2607:f8b0:4864:20::1134]:44455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxE4H-0005ri-FH for 66801@debbugs.gnu.org; Sun, 29 Oct 2023 18:15:38 -0400 Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-5ae143e08b1so33068457b3.1 for <66801@debbugs.gnu.org>; Sun, 29 Oct 2023 15:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=deeplinks-com.20230601.gappssmtp.com; s=20230601; t=1698617699; x=1699222499; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=u5DkL/+3McTPZd2TpZqyZgHizOF2x6G7lkPUcYPleXQ=; b=s+YswbjXnBAJ0iE3Y3VPJ1+doHRWf5TkgghwvIdCfGJSB2GOLtZ87JREBe/b89eFj7 F6iNoGsP9y9S1ildI5v8ik2lNEh7YxmG9wipIGB3iHNhwDKUI5B8Ks6L2YdrKxOBgZMC idv8NBlJF90pWfpFxTtZ+fOe6CzQ25IDxjKniNWtEz5WWSONVk8CjKJZRGW49nRFVd66 W3gGTY/pNwhXvG1iN3A8Y4sJlPNzjZlxMjh3dxemj/uV1ezDQwm65YHQyfVln8X8rsni 3GzJ+k3Me3Ym7rDj6TdCbwcsHEAd/nyd2Mmb22+Gu7pcPr4Qp8fF8YVmlt8eeFYdk4XC iJNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698617699; x=1699222499; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u5DkL/+3McTPZd2TpZqyZgHizOF2x6G7lkPUcYPleXQ=; b=mwV7EY3mfQmVtEpBwJmdWMw3ShYQSJ+kva7+Lq2OBVBIoCNEIqp1+dF86XEIseb4T+ NBv9vFmlNLRnyXqF69GT7mVWstfONUfv7iOnRXW45nlb4sOYtOkvv+pUKzwrAKGefV9t XpfA8NaOiNRJGuncw7lKCBscIruC2ukEyzGdOoc4FoCwiSaaxxpCr4a8rAj6FqlxpppI kwp424ZQ+6OVdR5fdh0rCpjT8GvhBiZDIAFwz0xRJSn6YSp3WgJCgnlxsIWgT6KkKEJp nLKbgwTY4D2at7GBBsTz8OdYGE9oWclygp8Qwrp2suG46Tgro4UNzq3OH8CBSxKDOfRr bMTA== X-Gm-Message-State: AOJu0Yw7/42vNB5PfIXZ618YL8Q/Wta6uNaheDF6dtRBK5I00Qy52FZr BjCaipAr2DKeQ7H7+0TKk9IpBD55EDe+tDNqxacEdw== X-Google-Smtp-Source: AGHT+IFgTW5ebVwH67F8GAyWaB1Ds2xqkShVa7ipInBleDno6atSZKkn9lY9t5ER3w+6ROJl5bBJcbOgQTeUUNsWmsQ= X-Received: by 2002:a81:4806:0:b0:5a7:fcae:f3e2 with SMTP id v6-20020a814806000000b005a7fcaef3e2mr9357708ywa.43.1698617698758; Sun, 29 Oct 2023 15:14:58 -0700 (PDT) MIME-Version: 1.0 References: <7ceab0dcbe069f664377786b5bb531e2196fffc1.camel@gmail.com> In-Reply-To: <7ceab0dcbe069f664377786b5bb531e2196fffc1.camel@gmail.com> From: Pierre-Henry =?UTF-8?Q?Fr=C3=B6hring?= Date: Sun, 29 Oct 2023 23:14:47 +0100 Message-ID: Content-Type: multipart/alternative; boundary="0000000000008b584b0608e240fd" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -2.10 X-Migadu-Queue-Id: 891523A851 X-Migadu-Spam-Score: -2.10 X-TUID: XAwe9D5eFH/Q --0000000000008b584b0608e240fd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > The middle should indicate a revision number and an optional branch > (as well as optional WIP and RFC). Since this goes to master (I > assume), it should just be v2, v3, =E2=80=A6 vN. DONE: Ok. If I understood correctly, it means that it should have been [PATCH v2]. So this time, it will be [PATCH v3]. > Emacs, Rust, etc., build systems just strip out the prefix. No need > to go all fancy regexpy :)=E4=BD=95=E3=81=A7=EF=BC=9F WAITING: Well, it makes the warning message completely explicit, for example: =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 =E2=94=82 AssertionWarning 4dcbff27 =E2=94=82 Assertion: re matches name. =E2=94=82 re =3D ^erlang-(.*) =E2=94=82 name =3D something-else =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 Is it OK if it stays like this? > I suggest not renaming these procedures. default-X reads more > naturally than X-default. DONE. > This reeks of the hack that we need for cargo-build-system, except > with a worse variable name. I strongly suggest looking into ways we > can do without it. WAITING: this idea came from a discussion with jpoiret. See: . It seems that the idea you suggest is to use `search-path-as-list' as hinted below. Is this correct? > Uhm, did you mean file-name-separator-string from Guile core? DONE: Great. That is what I was searching for; I'm not yet familiar with the standard library. > We have find-files? DONE: replaced. > Uhm, how are you improving the status quo here? WAITING: comment updated with: =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 =E2=94=82 ;; If these directories exist, then no error occurs. So, we mak= e sure =E2=94=82 ;; they exist. =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 Is this OK? > The canonical way is to use (getcwd) as HOME. You could also try > something like (canonicalize-path "../hexpm-home"). Anyhow, you might > want to try using a variable that is less global than HOME. DONE: HOME has been replaced by REBAR_CACHE_DIR. > I suggest not using French examples =E2=80=93 they are confusing between > French and German native speakers :) DONE: =C2=AB =E2=86=92 =E2=80=9C, =C2=BB =E2=86=92 =E2=80=9D > You might want to look into possible PATH variables or put these > sources into a special folder so that you can use search-path-as-list. WAITING: Perhaps an idea: 1) If we require all Erlang packages to have an output =E2=80=9Csrc=E2=80= =9D something like: /gnu/store/=E2=80=A6elixir-pkg-1.2.3/src/elixir/src/=E2=80=A6, 2) then (search-path-as-list '("src/elixir/src") '("/gnu/store=E2=80=A6elixir-pkg-1.2.3" =E2=80=A6)) would return '("/gnu/store=E2=80=A6elixir-pkg-1.2.3/src/elixir/src" =E2=80=A6) =E2=89= =A1 lst-src. 3) Given lst-src, it would be enough to install each source under _checkouts, i.e., _checkouts/lib-name/src. It is probably feasible to retrieve lib-name from somewhere. What do you think? > Also, IIUC, erlang-depends already does something rather similar. Is > there any reason it's broken for you? WAITING: Without that (i.e., _checkouts/lib-name/src), rebar3 will not compile things. Is this a satisfaying explaination? --0000000000008b584b0608e240fd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

> =C2=A0The middle should = indicate a revision number and an optional branch
> =C2=A0(as well as= optional WIP and RFC).=C2=A0 Since this goes to master (I
> =C2=A0as= sume), it should just be v2, v3, =E2=80=A6 vN.

DONE: Ok. If I unders= tood correctly, it means that it should have been
[PATCH v2]. So this ti= me, it will be [PATCH v3].

> Emacs, Rust, etc., build systems jus= t strip out the prefix.=C2=A0 No need
> to go all fancy regexpy :)=E4= =BD=95=E3=81=A7=EF=BC=9F

WAITING: Well, it makes the warning message= completely explicit, for
example:
=E2=94=8C=E2=94=80=E2=94=80=E2=94= =80=E2=94=80
=E2=94=82 AssertionWarning 4dcbff27
=E2=94=82 =C2=A0 Ass= ertion: re matches name.
=E2=94=82 =C2=A0 =C2=A0 re =3D ^erlang-(.*)
= =E2=94=82 =C2=A0 =C2=A0 name =3D something-else
=E2=94=94=E2=94=80=E2=94= =80=E2=94=80=E2=94=80
Is it OK if it stays like this?

> I sugg= est not renaming these procedures. =C2=A0default-X reads more
> natur= ally than X-default.

DONE.

> This reeks of the hack that w= e need for cargo-build-system, except
> with a worse variable name.= =C2=A0 I strongly suggest looking into ways we
> can do without it.
WAITING: this idea came from a discussion with jpoiret. See:
<<= a href=3D"https://logs.guix.gnu.org/guix/2023-10-24.log#180111">https://log= s.guix.gnu.org/guix/2023-10-24.log#180111>. It seems that
the ide= a you suggest is to use `search-path-as-list' as hinted below. Is
th= is correct?

> Uhm, did you mean file-name-separator-string from G= uile core?

DONE: Great. That is what I was searching for; I'm no= t yet familiar with
the standard library.

> We have find-files= ?

DONE: replaced.

> Uhm, how are you improving the status = quo here?

WAITING: comment updated with:
=E2=94=8C=E2=94=80=E2=94= =80=E2=94=80=E2=94=80
=E2=94=82 ;; =C2=A0 If these directories exist, th= en no error occurs. So, we make sure
=E2=94=82 ;; =C2=A0 they exist.
= =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80
Is this OK?

> Th= e canonical way is to use (getcwd) as HOME.=C2=A0 You could also try
>= ; something like (canonicalize-path "../hexpm-home").=C2=A0 Anyho= w, you might
> want to try using a variable that is less global than = HOME.

DONE: HOME has been replaced by REBAR_CACHE_DIR.

> I= suggest not using French examples =E2=80=93 they are confusing between
= > French and German native speakers :)

DONE: =C2=AB =E2=86=92 =E2= =80=9C, =C2=BB =E2=86=92 =E2=80=9D

> You might want to look into = possible PATH variables or put these
> sources into a special folder = so that you can use search-path-as-list.

WAITING: Perhaps an idea:1) If we require all Erlang packages to have an output =E2=80=9Csrc=E2=80= =9D something
=C2=A0 =C2=A0like: /gnu/store/=E2=80=A6elixir-pkg-1.2.3/sr= c/elixir/src/=E2=80=A6,
2) then (search-path-as-list '("src/eli= xir/src")
=C2=A0 =C2=A0'("/gnu/store=E2=80=A6elixir-pkg-1.= 2.3" =E2=80=A6)) would return
=C2=A0 =C2=A0'("/gnu/store= =E2=80=A6elixir-pkg-1.2.3/src/elixir/src" =E2=80=A6) =E2=89=A1 lst-src= .
3) Given lst-src, it would be enough to install each source under
= =C2=A0 =C2=A0_checkouts, i.e., _checkouts/lib-name/src. It is probably feas= ible to
=C2=A0 =C2=A0retrieve lib-name from somewhere.
What do you th= ink?

> Also, IIUC, erlang-depends already does something rather s= imilar.=C2=A0 Is
> there any reason it's broken for you?

W= AITING: Without that (i.e., _checkouts/lib-name/src), rebar3 will not
co= mpile things. Is this a satisfaying explaination?
--0000000000008b584b0608e240fd--