From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id OCWiKJXvVGWhMAEA9RJhRA:P1 (envelope-from ) for ; Wed, 15 Nov 2023 17:19:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id OCWiKJXvVGWhMAEA9RJhRA (envelope-from ) for ; Wed, 15 Nov 2023 17:19:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 671F725E1B for ; Wed, 15 Nov 2023 17:19:33 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=deeplinks-com.20230601.gappssmtp.com header.s=20230601 header.b=cGldhspu; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1700065173; a=rsa-sha256; cv=none; b=ULPvc10NI8RZOajf6WgmX9hEXhCH62SurW/Jau7voqLsjhPk5U4RGYgNfy8VB7sWISc+I8 HUL5d7SOsqTfkY1qZqoBC2fUMM1jG3WevEMdYITJwWgXHoI2IZ68c5fnIdpM6kRsasHCDe tl9ukW+DUi+3odRIbMPdHeYCfjkXI8MqdsSwHXWA8WE3EQuSWTYw2W9Pxo3YfaZ4rG3SHG TYCglZoNjy20N4tkyTUugToXKsZr2t1d3gKdzR2u+JIxsQ7dmMTvCXmOACnTzH7pmbZvk1 tDU3HJOsMoQmJjxz7k4A2DIhUQBwf/2nUlfVTt7J+l4mVdTmvpvtLkuPh5HWvw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=deeplinks-com.20230601.gappssmtp.com header.s=20230601 header.b=cGldhspu; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1700065173; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Lt4sH3Dq+7XE0YNkJx3cPMQBjqWa08gkZR74382CzTk=; b=W+VmWIkpRr8+bR/f3pFjWc4u+LCee6YcjE+T5z2TTWAYyeBw8gfbVYYAJP7jkA70ScDkhk fRVpkX6gMqb5s9volFIZ8JK+PSYmVyvO3DicSx25y/50uKBBdNn2/4T2e3rmt2KKhYuPwI ipupPl666jSFJuePJF86APvFNrgTLdApd0iXHwzoyKJ7/MjGP/HQndYrQDjeqm+rvbysgT IUoTVlPpamnhtFL4lhWLv2aGvjJGGxU9KX5zV8vjFomHM0yYjz1TUQQ+jyhwncO/BQ8T0u cTC5emUszBZexA4zvylP9mxazorQa6xYKatRel6j5VZUU7027cUMnWVLsKZDdQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3Ibn-0007h5-VR; Wed, 15 Nov 2023 11:19:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3Ibb-0007f0-M9 for guix-patches@gnu.org; Wed, 15 Nov 2023 11:19:13 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3IbX-0005jY-Q1 for guix-patches@gnu.org; Wed, 15 Nov 2023 11:19:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3IbW-0001pL-Bb for guix-patches@gnu.org; Wed, 15 Nov 2023 11:19:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#66801] ['PATCH v2' 01/14] build-system: Add mix-build-system. Resent-From: Pierre-Henry =?UTF-8?Q?Fr=C3=B6hring?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 15 Nov 2023 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66801 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 66801@debbugs.gnu.org Received: via spool by 66801-submit@debbugs.gnu.org id=B66801.17000651206989 (code B ref 66801); Wed, 15 Nov 2023 16:19:02 +0000 Received: (at 66801) by debbugs.gnu.org; 15 Nov 2023 16:18:40 +0000 Received: from localhost ([127.0.0.1]:53088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Ib9-0001of-Mp for submit@debbugs.gnu.org; Wed, 15 Nov 2023 11:18:40 -0500 Received: from mail-ua1-x930.google.com ([2607:f8b0:4864:20::930]:42347) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Ib6-0001oP-U1 for 66801@debbugs.gnu.org; Wed, 15 Nov 2023 11:18:37 -0500 Received: by mail-ua1-x930.google.com with SMTP id a1e0cc1a2514c-7baea76391dso600971241.1 for <66801@debbugs.gnu.org>; Wed, 15 Nov 2023 08:18:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=deeplinks-com.20230601.gappssmtp.com; s=20230601; t=1700065112; x=1700669912; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Lt4sH3Dq+7XE0YNkJx3cPMQBjqWa08gkZR74382CzTk=; b=cGldhspuDbzNJ6LrImXkdbJOZ9Gd+Zed15UAMyuLjZcJ4szgJWzARmm2Jr6zEhu54a pWM0ymD1Xfi96yvqI9sL/qs+pA6ZU6O4WvJwTt8xpty8bISFwC2HO0/dNkfw2xM7ll6w eLQIaS7yDsul+xRLBtMAuCiPU5ZVSHodJbfLll0V/1ygbb83MBlLFk07TWw2lk0wkLEw LA/w+aKbguDhjBX/7ryuphrKF76ksGL47rS1JzK+jIOD68d3nKSKWPR31mkOhGS/pwNU cOG+3PGk2K3MaDRxtbJdjtYrq3RreLem91wWJ8rhWXeUSClu/Q3QRPT3hpd5lOKl4sLh m0iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700065112; x=1700669912; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Lt4sH3Dq+7XE0YNkJx3cPMQBjqWa08gkZR74382CzTk=; b=hX9sDa5aaRhyGuT8yjiAeiFDb10jpO40MR9I7vCWITrFEwl7aCViOHfNnwdL90/9k9 rxx7F4HvxrLIIuH7gOdIXbhL+zfc1rUStqU0toDgAQbqmVDGdXXjHj1RVVDsAc60qmSh 78jzghu1f6AMV2RbhP9DH9myWp5IyDRhyr9ypi19JSHFZuGXCHEo9EKykRCsYzTFz5CP FSwTqJH49jCKJHJakivtlIeapflCUA9oWrZLifB5l1Z31wZ8zLT1LM4/MNB1ozPhFGvV nfd0SBmR5OlpcYo8u/083skEt9XfSod2P9V1idoH+h0HsBwkXERY9Uyq0dMbRsKc/en4 rwpw== X-Gm-Message-State: AOJu0YyOXxpz6Av8CTqVQCtu0xsQ3AiJLqVWMKnsRbe6lDcm+X3TKgv7 zUsql8rP3++WhCh6Mn2FE0c3xaGpGAeUomuc4sfNlNb4SGkd9AK2YdM= X-Google-Smtp-Source: AGHT+IFqibUujvga9R3hvyhIjnOSKk/RXQ1edKNfuSojZDEsozsC5CRa68T0c2FGCtapMk6jUKz3iSNSDnUw+OxfTng= X-Received: by 2002:a0d:d7d1:0:b0:5a1:d216:8d3 with SMTP id z200-20020a0dd7d1000000b005a1d21608d3mr3931095ywd.5.1700042266774; Wed, 15 Nov 2023 01:57:46 -0800 (PST) MIME-Version: 1.0 References: <26ef9c0f4bf2ff942ba2b42e1fadeb6174bbaa6a.1699906775.git.phfrohring@deeplinks.com> In-Reply-To: From: Pierre-Henry =?UTF-8?Q?Fr=C3=B6hring?= Date: Wed, 15 Nov 2023 10:57:35 +0100 Message-ID: Content-Type: multipart/alternative; boundary="0000000000006a1f75060a2defc1" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 671F725E1B X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.09 X-Spam-Score: -5.09 X-TUID: 9QJuEX/SIlJv --0000000000006a1f75060a2defc1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > No. Look at all the other build systems. None of them use submodules of (gnu > packages), for a good reason. Ok, I see. It would introduce circular dependencies. By "resolve," you mean something like: ~(resolve-interface '(gnu packages yyy))~. So, in our case it means: #+begin_src scheme (define (default-glibc-utf8-locales) (let* ((base (resolve-interface '(gnu packages base))) (glibc (module-ref base 'glibc)) (make-glibc-utf8-locales (module-ref base 'make-glibc-utf8-locales))) (make-glibc-utf8-locales glibc #:locales (list "en_US")))) (define (default-elixir-hex) (let ((elixir (resolve-interface '(gnu packages elixir)))) (module-ref elixir 'elixir-hex))) (define (default-rebar3) (let ((erlang (resolve-interface '(gnu packages erlang)))) (module-ref erlang 'rebar3))) #+end_src Then: #+begin_src scheme (define* (lower name #:key (elixir (default-elixir)) (elixir-hex (default-elixir-hex)) (glibc-utf8-locales (default-glibc-utf8-locales)) (rebar3 (default-rebar3)) =E2=80=A6 #:allow-other-keys #:rest arguments) =E2=80=A6) #+end_src Is this correct? > Not necessarily, but you want a different way of building $out/lib/elixir/X.Y/ > that doesn't leak through the function signature. Following ~python-build-system.scm~, it means something like: #+begin_src scheme (define (elixir-version elixir) (let* ((version (last (string-split elixir #\-))) (components (string-split version #\.)) (major+minor (take components 2))) (string-join major+minor "."))) (define (install-dir inputs outputs) "Return the path of the current output's Elixir library." (let ((out (assoc-ref outputs "out")) (elixir (assoc-ref inputs "elixir"))) (string-append out "/lib/elixir/" (elixir-version elixir) "/site-packages"))) #+end_src Is this correct? > Btw. I think that you're resolving transitive inputs twice; once on the build > system code and once by fattening the outputs. You probably only need either > of those, not both. Ah. Propagated inputs are propagated. Who would have thought? So, this is not necessary: #+begin_src scheme (define* (lower =E2=80=A6) =E2=80=A6 (define all-propagated-inputs ((compose (cut delete-duplicates <> equal?) (cut filter erlang-or-elixir-input? <>) (cut append-map package-transitive-propagated-inputs <>) (cut map cadr <>)) (append inputs native-inputs))) (define build-inputs `(=E2=80=A6 ,@all-propagated-inputs ,@inputs ,@native-inputs)) (bag =E2=80=A6 (build-inputs build-inputs) =E2=80=A6)) #+end_src I've just removed ~all-propagated-inputs~ and all packages build just fine. Is this what you meant? > Yep, that would work. Note that delete-duplicates is O(n^2), though. We have > a little bit of code where it's done in (I assume) O(n*log(n)) with vhashes. If ~all-propagated-inputs~ is removed, then the discussion of this comment is closed. --0000000000006a1f75060a2defc1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> No.=C2=A0 Look at all the other build systems.=C2=A0 = None of them use submodules of (gnu
> packages), for a good reason.
Ok, I see. It would introduce circular dependencies. By "resolve= ," you
mean something like: ~(resolve-interface '(gnu packages = yyy))~. So, in
our case it means:
#+begin_src scheme
(define (default-glibc-utf8-locales)
=C2=A0 (let* ((base (re= solve-interface '(gnu packages base)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0(glibc (module-ref base 'glibc))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0(make-glibc-utf8-locales (module-ref base 'make-glibc-utf8-locale= s)))
=C2=A0 =C2=A0 (make-glibc-utf8-locales glibc #:locales (list "= en_US"))))

(define (default-elixir-hex)
=C2=A0 (let ((elixir= (resolve-interface '(gnu packages elixir))))
=C2=A0 =C2=A0 (module-= ref elixir 'elixir-hex)))

(define (default-rebar3)
=C2=A0 (le= t ((erlang (resolve-interface '(gnu packages erlang))))
=C2=A0 =C2= =A0 (module-ref erlang 'rebar3)))
#+end_src

Then:
#= +begin_src scheme
(define* (lower name
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #:key
=C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (elixir (default-elixir))
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (elixir-hex (default-e= lixir-hex))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (gli= bc-utf8-locales (default-glibc-utf8-locales))
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (rebar3 (default-rebar3))
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =E2=80=A6
=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #:allow-other-keys #:rest arguments)=C2=A0 =E2=80=A6)
#+end_src

Is this correct?


&= gt; Not necessarily, but you want a different way of building $out/lib/elix= ir/X.Y/
> that doesn't leak through the function signature.
Following ~python-build-system.scm~, it means something like:
#+begin_= src scheme
(define (elixir-version elixir)
= =C2=A0 (let* ((version =C2=A0 =C2=A0 (last (string-split elixir #\-)))
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(components =C2=A0(string-split version #= \.))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(major+minor (take components 2))= )
=C2=A0 =C2=A0 (string-join major+minor ".")))

(define= (install-dir inputs outputs)
=C2=A0 "Return the path of the curren= t output's Elixir library."
=C2=A0 (let ((out (assoc-ref output= s "out"))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (elixir (assoc-ref input= s "elixir")))
=C2=A0 =C2=A0 (string-append out "/lib/elix= ir/" (elixir-version elixir) "/site-packages")))
#= +end_src

Is this correct?


> Btw. I think that you'= re resolving transitive inputs twice; once on the build
> system code= and once by fattening the outputs.=C2=A0 You probably only need either
= > of those, not both.

Ah. Propagated inputs are propagated. Who w= ould have thought? So, this is not necessary:
#+begin_src scheme
(define* (lower =E2=80=A6)
=C2=A0 =E2=80=A6
=C2= =A0 (define all-propagated-inputs
=C2=A0 =C2=A0 ((compose
=C2=A0 =C2= =A0 =C2=A0 (cut delete-duplicates <> equal?)
=C2=A0 =C2=A0 =C2=A0 = (cut filter erlang-or-elixir-input? <>)
=C2=A0 =C2=A0 =C2=A0 (cut = append-map package-transitive-propagated-inputs <>)
=C2=A0 =C2=A0 = =C2=A0 (cut map cadr <>))
=C2=A0 =C2=A0 =C2=A0(append inputs nativ= e-inputs)))

=C2=A0 (define build-inputs
=C2=A0 =C2=A0 `(=E2=80=A6=
=C2=A0 =C2=A0 =C2=A0 ,@all-propagated-inputs
=C2=A0 =C2=A0 =C2=A0 ,@= inputs
=C2=A0 =C2=A0 =C2=A0 ,@native-inputs))

=C2=A0 (bag =E2=80= =A6
=C2=A0 =C2=A0 =C2=A0 =C2=A0(build-inputs build-inputs)
=C2=A0 =C2= =A0 =C2=A0 =C2=A0=E2=80=A6))
#+end_src
I've just removed ~= all-propagated-inputs~ and all packages build just fine.

Is this wha= t you meant?


> Yep, that would work.=C2=A0 Note that delete-d= uplicates is O(n^2), though.=C2=A0 We have
> a little bit of code whe= re it's done in (I assume) O(n*log(n)) with vhashes.

If ~all-pro= pagated-inputs~ is removed, then the discussion of this comment is
close= d.

--0000000000006a1f75060a2defc1--