From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:51418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ghpkd-00026c-Jz for guix-patches@gnu.org; Fri, 11 Jan 2019 00:53:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ghpkc-0004VO-8S for guix-patches@gnu.org; Fri, 11 Jan 2019 00:53:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55162) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ghpkb-0004VA-V4 for guix-patches@gnu.org; Fri, 11 Jan 2019 00:53:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ghpkb-00016V-Mo for guix-patches@gnu.org; Fri, 11 Jan 2019 00:53:01 -0500 Subject: [bug#34034] [PATCH]: Add Bochs Resent-Message-ID: MIME-Version: 1.0 References: <20190110234228.GA28964@jasmine.lan> In-Reply-To: <20190110234228.GA28964@jasmine.lan> From: Guy fleury Date: Fri, 11 Jan 2019 06:52:31 +0100 Message-ID: Content-Type: multipart/mixed; boundary="000000000000de2cea057f284df1" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 34034@debbugs.gnu.org --000000000000de2cea057f284df1 Content-Type: multipart/alternative; boundary="000000000000de2ce7057f284def" --000000000000de2ce7057f284def Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable hi Le ven. 11 janv. 2019 =C3=A0 00:42, Leo Famulari a =C3= =A9crit : > On Thu, Jan 10, 2019 at 07:18:04PM +0100, Guy fleury wrote: > > From 0380fab2ad7195407fc29afb830a86dbfae03b3f Mon Sep 17 00:00:00 2001 > > From: guy fleury iteriteka > > Date: Thu, 10 Jan 2019 17:33:30 +0100 > > Subject: [PATCH] gnu: Add Bochs > > Thank you! > > > + (outputs '("out")) > > This is the default, so it's okay to leave it out. > > > + `(#:tests? #f)) ;; no tests exits > > "No tests exist" > > > + (inputs > > + `(("glib" ,glib) > > + ("gtk+" ,gtk+) > > + ("libxrandr" ,libxrandr))) > > I noticed that it doesn't keep references to glib and gtk+: > > ------ > $ guix gc --references $(./pre-inst-env guix build --no-grafts bochs) > /gnu/store/2dk55i5wdhcbh2z8hhn3r55x4873iyp1-libxext-1.3.3 > /gnu/store/3vlscch2sxybd34qx2ianpg92crm9akm-libxdmcp-1.1.2 > /gnu/store/4sqps8dczv3g7rwbdibfz6rf5jlk7w90-gcc-5.5.0-lib > /gnu/store/6lwn8v33r2z2l2pgky2dnzim3696dwnn-libbsd-0.9.1 > /gnu/store/8baabfjazsr7s4y0jig1sn84xnxf75xa-libx11-1.6.6 > /gnu/store/h90vnqw0nwd0hhm1l5dgxsdrigddfmq4-glibc-2.28 > /gnu/store/hnj08aavzpsi72wvi4qqrp5dqbyqxqqs-libxcb-1.13 > /gnu/store/mawqhgh0bdxpa4gjxs1fjyhwvv6i8w5g-libxau-1.0.8 > /gnu/store/mbbj3j86amqls868hip0l85q9lx8gbcn-libxrandr-1.5.1 > /gnu/store/x6fyr53k53sd5ghnh3abpnr1mqsy3xig-bochs-2.6.9 > /gnu/store/xrvwszmahcb7k2zcyag3vmqwswzrbvcg-libxrender-0.9.10 > ------ > thanks for this tips. > So, I think it's possible to omit those two inputs. > > > + "Bochs is an emulator which can emulate Intel x86 CPU, common I/O > > +devices, and a custom BIOS. It can also compiled to emulate many > different > > "It can also be compiled to ..." > > > +Bochs can running most Operating Systems inside the emulation includin= g > Linux, > > +DOS or Microsoft Windows.") > > "Bochs can run most operating systems ..." > > > + (license license:lgpl2.0))) > > I checked some of the source files and I think it is lgpl2.0+. > > Can you send an updated patch? :) > --000000000000de2ce7057f284def Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
hi

Le=C2=A0ven. 11 janv. 2019 =C3=A0=C2=A000:42, Leo Famulari <leo@famulari.name> a =C3=A9crit=C2=A0:=
On Thu, Jan 10, 2019 at 07:18:04PM +0100, Guy fl= eury wrote:
> From 0380fab2ad7195407fc29afb830a86dbfae03b3f Mon Sep 17 00:00:00 2001=
> From: guy fleury iteriteka <hoonandon@gmail.com>
> Date: Thu, 10 Jan 2019 17:33:30 +0100
> Subject: [PATCH] gnu: Add Bochs

Thank you!

> +=C2=A0 =C2=A0 (outputs '("out"))

This is the default, so it's okay to leave it out.

> +=C2=A0 =C2=A0 =C2=A0`(#:tests? #f)) ;; no tests exits

"No tests exist"

> +=C2=A0 =C2=A0 (inputs
> +=C2=A0 =C2=A0 =C2=A0`(("glib" ,glib)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0("gtk+" ,gtk+)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0("libxrandr" ,libxrandr)))

I noticed that it doesn't keep references to glib and gtk+:

------
$=C2=A0 guix gc --references $(./pre-inst-env guix build --no-grafts bochs)=
/gnu/store/2dk55i5wdhcbh2z8hhn3r55x4873iyp1-libxext-1.3.3
/gnu/store/3vlscch2sxybd34qx2ianpg92crm9akm-libxdmcp-1.1.2
/gnu/store/4sqps8dczv3g7rwbdibfz6rf5jlk7w90-gcc-5.5.0-lib
/gnu/store/6lwn8v33r2z2l2pgky2dnzim3696dwnn-libbsd-0.9.1
/gnu/store/8baabfjazsr7s4y0jig1sn84xnxf75xa-libx11-1.6.6
/gnu/store/h90vnqw0nwd0hhm1l5dgxsdrigddfmq4-glibc-2.28
/gnu/store/hnj08aavzpsi72wvi4qqrp5dqbyqxqqs-libxcb-1.13
/gnu/store/mawqhgh0bdxpa4gjxs1fjyhwvv6i8w5g-libxau-1.0.8
/gnu/store/mbbj3j86amqls868hip0l85q9lx8gbcn-libxrandr-1.5.1
/gnu/store/x6fyr53k53sd5ghnh3abpnr1mqsy3xig-bochs-2.6.9
/gnu/store/xrvwszmahcb7k2zcyag3vmqwswzrbvcg-libxrender-0.9.10
------
thanks for this tips.=C2=A0
So, I think it's possible to omit those two inputs.

> +=C2=A0 =C2=A0 =C2=A0"Bochs is an emulator which can emulate Inte= l x86 CPU, common I/O
> +devices, and a custom BIOS.=C2=A0 It can also compiled to emulate man= y different

"It can also be compiled to ..."

> +Bochs can running most Operating Systems inside the emulation includi= ng Linux,
> +DOS or Microsoft Windows.")

"Bochs can run most operating systems ..."

> +=C2=A0 =C2=A0 (license license:lgpl2.0)))

I checked some of the source files and I think it is lgpl2.0+.

Can you send an updated patch? :)
--000000000000de2ce7057f284def-- --000000000000de2cea057f284df1 Content-Type: text/x-patch; charset="UTF-8"; name="0001-gnu-Add-Bochs.patch" Content-Disposition: attachment; filename="0001-gnu-Add-Bochs.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jqrmk85m0 RnJvbSBlZDhjNGYxMGRkNjY5ZGU0MjUzOWRjNDQ0MzdjNTcyOTIzMGJlNTlkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBndXkgZmxldXJ5IGl0ZXJpdGVrYSA8aG9vbmFuZG9uQGdtYWls LmNvbT4KRGF0ZTogVGh1LCAxMCBKYW4gMjAxOSAxNzozMzozMCArMDEwMApTdWJqZWN0OiBbUEFU Q0hdIGdudTogQWRkIEJvY2hzCgotLS0KIGdudS9wYWNrYWdlcy92aXJ0dWFsaXphdGlvbi5zY20g fCAyOCArKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMjggaW5z ZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy92aXJ0dWFsaXphdGlvbi5zY20g Yi9nbnUvcGFja2FnZXMvdmlydHVhbGl6YXRpb24uc2NtCmluZGV4IDI3NGY4MjdjZC4uNmRlZGEy ZTg2IDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvdmlydHVhbGl6YXRpb24uc2NtCisrKyBiL2du dS9wYWNrYWdlcy92aXJ0dWFsaXphdGlvbi5zY20KQEAgLTEwLDYgKzEwLDcgQEAKIDs7OyBDb3B5 cmlnaHQgwqkgMjAxOCBEYW5ueSBNaWxvc2F2bGpldmljIDxkYW5ueW1Ac2NyYXRjaHBvc3Qub3Jn PgogOzs7IENvcHlyaWdodCDCqSAyMDE4IFNvdSBCdW5uYnUgPGl5enNvbmdAbWVtYmVyLmZzZi5v cmc+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTggSnVsaWVuIExlcGlsbGVyIDxqdWxpZW5AbGVwaWxs ZXIuZXU+Cis7OzsgQ29weXJpZ2h0IMKpIDIwMTkgR3V5IEZsZXVyeSBJdGVyaXRla2EgPGhvb25h bmRvbkBnbWFpbC5jb20+CiA7OzsKIDs7OyBUaGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4K IDs7OwpAQCAtMTA1OCwzICsxMDU5LDMwIEBAIGFuZCB0aGUgdXNlciBjYW4gc3BlY2lmeSBleGFj dGx5IHdoYXQgcGFydHMgb2YgdGhlIGZpbGVzeXN0ZW0gc2hvdWxkIGJlIHZpc2libGUKIGluIHRo ZSBzYW5kYm94LiAgQW55IHN1Y2ggZGlyZWN0b3JpZXMgc3BlY2lmaWVkIGlzIG1vdW50ZWQgbm9k ZXYgYnkgZGVmYXVsdCwKIGFuZCBjYW4gYmUgbWFkZSByZWFkb25seS4iKQogICAgIChsaWNlbnNl IGxpY2Vuc2U6bGdwbDIuMCspKSkKKworKGRlZmluZS1wdWJsaWMgYm9jaHMKKyAgKHBhY2thZ2UK KyAgICAobmFtZSAiYm9jaHMiKQorICAgICh2ZXJzaW9uICIyLjYuOSIpCisgICAgKHNvdXJjZQor ICAgICAob3JpZ2luCisgICAgICAgKG1ldGhvZCB1cmwtZmV0Y2gpCisgICAgICAgKHVyaSAoc3Ry aW5nLWFwcGVuZCAiaHR0cHM6Ly9zb3VyY2Vmb3JnZS5uZXQvcHJvamVjdHMvYm9jaHMvZmlsZXMv Ym9jaHMvIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgdmVyc2lvbiAiL2JvY2hzLSIgdmVy c2lvbiAiLnRhci5neiIpKQorICAgICAgIChzaGEyNTYKKyAgICAgICAgKGJhc2UzMgorICAgICAg ICAgIjEzNzljcTRjbmZwcmh3OG1naDYwaTBxOWo4Zno4ZDduM2Q1Zm5uMmc5ZmRpdjV6bmZuemYi KSkpKQorICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRz CisgICAgIGAoIzp0ZXN0cz8gI2YpKSA7OyBubyB0ZXN0cyBleGl0CisgICAgKGlucHV0cworICAg ICBgKCgibGlieHJhbmRyIiAsbGlieHJhbmRyKSkpCisgICAgKGhvbWUtcGFnZSAiaHR0cDovL2Jv Y2hzLnNvdXJjZWZvcmdlLm5ldC8iKQorICAgIChzeW5vcHNpcyAiRW11bGF0b3IgZm9yIHg4NiBQ QyIpCisgICAgKGRlc2NyaXB0aW9uCisgICAgICJCb2NocyBpcyBhbiBlbXVsYXRvciB3aGljaCBj YW4gZW11bGF0ZSBJbnRlbCB4ODYgQ1BVLCBjb21tb24gSS9PCitkZXZpY2VzLCBhbmQgYSBjdXN0 b20gQklPUy4gIEl0IGNhbiBhbHNvIGJlIGNvbXBpbGVkIHRvIGVtdWxhdGUgbWFueSBkaWZmZXJl bnQKK3g4NiBDUFVzLCBmcm9tIGVhcmx5IDM4NiB0byB0aGUgbW9zdCByZWNlbnQgeDg2LTY0IElu dGVsIGFuZCBBTUQgcHJvY2Vzc29ycy4KK0JvY2hzIGNhbiBydW4gbW9zdCBPcGVyYXRpbmcgU3lz dGVtcyBpbnNpZGUgdGhlIGVtdWxhdGlvbiBpbmNsdWRpbmcgTGludXgsCitET1Mgb3IgTWljcm9z b2Z0IFdpbmRvd3MuIikKKyAgICAobGljZW5zZSBsaWNlbnNlOmxncGwyLjArKSkpCi0tIAoyLjE5 LjIKCg== --000000000000de2cea057f284df1--