Hi Maxim,

Thank you for the review. I'll check that procedure and prepare simplified
v2 patch.

Oleg

On Tue, 21 Mar 2023, 19:24 Maxim Cournoyer, <maxim.cournoyer@gmail.com>
wrote:

> Hi,
>
> Sharlatan Hellseher <sharlatanus@gmail.com> writes:
>
> > * gnu/packages/astronomy.scm (phd2): New variable.
> > ---
> >  gnu/packages/astronomy.scm | 71 ++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 71 insertions(+)
> >
> > diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
> > index 46839c802f..66040ad5f5 100644
> > --- a/gnu/packages/astronomy.scm
> > +++ b/gnu/packages/astronomy.scm
> > @@ -678,6 +678,77 @@ (define-public gnuastro
> >  programs for the manipulation and analysis of astronomical data.")
> >      (license license:gpl3+)))
> >
> > +(define-public phd2
> > +  (package
> > +    (name "phd2")
> > +    (version "2.6.11")
> > +    (source
> > +     (origin
> > +       (method git-fetch)
> > +       (uri (git-reference
> > +             (url "https://github.com/OpenPHDGuiding/phd2")
> > +             (commit (string-append "v" version))))
> > +       (file-name (git-file-name name version))
> > +       (sha256
> > +        (base32 "0n87xsv9gzrwk1ygws4vw397ffq40xybp5b3c3bd5kcmff0avaw9"))
> > +       (modules '((guix build utils)))
> > +       (snippet
> > +        '(begin
> > +           ;; NOTE: Keep eye on the thirdparty directory as the bundled
> names
> > +           ;; change from relase to release.
> > +           ;;
> > +           ;; Remove bundles.
> > +           (with-directory-excursion "thirdparty"
> > +             (for-each delete-file-recursively
> > +                       '("HID_Utilities"
> > +                         "MallincamGuider-OSX-dylib-source.zip"
> > +                         "VidCapture"
> > +                         "cfitsio-3.47-patched.tar.gz"
> > +                         "cfitsio-README-PHD2.txt"
> > +                         "cfitsio-snprintf.patch"
> > +                         "eigen-eigen-67e894c6cd8f.tar.bz2"
> > +                         "gettext-0.14.4-bin.zip"
> > +                         "gettext-0.14.4-dep.zip"
> > +                         "gtest-1.7.0.zip"
> > +                         "indiclient-44aaf5d3-win32.zip"
> > +                         "libcurl-7.54.0-win32.zip"
> > +                         "libdc1394-2.2.2.tar.gz"
> > +
>  "libindi-58b26c584049e1b9ecd55aa5f4a225677a417898.tar.gz"
> > +                         "libusb-1.0.21.tar.bz2"
> > +                         "openssag")))))))
>
> To make maintenance easier, perhaps you could reuse the 'delete-all-but'
> procedure from turbovnc or similar?  This has the benefit of listing
> what is kept (more transparent), and if the things we do care for change
> names, we will know.
>
> Could you please send a v2 with this suggestion implemented?
>
> --
> Thanks,
> Maxim
>