unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Sharlatan Hellseher <sharlatanus@gmail.com>
To: 69827@debbugs.gnu.org
Subject: [bug#69827] [PATCH 1/3] build-system/go: Add subdir parameter to go-version->git-ref.
Date: Wed, 4 Sep 2024 20:18:32 +0100	[thread overview]
Message-ID: <CAO+9K5q6oOCgZX2uDVjkRrTjQSncAu74OwJ08ufvLtHKhejC4g@mail.gmail.com> (raw)
In-Reply-To: <bfb6cb47bc6e2a05846653ca0b07470d4ae8ae05.1710584715.git.cdo@mutix.org>


[-- Attachment #1.1: Type: text/plain, Size: 661 bytes --]

Hi,

It's time to proper review your proposal :-)

I faced with obstacles of monorepo during review  process, especially where
nested path (subdir) has more than one level.

Let's have look at https://github.com/Azure/azure-sdk-for-go
which is required for restic update.

I will apply your patches and play with importing/upgrading projects like
restic to check how it feels.

Related issues:
- https://issues.guix.gnu.org/72963, requires
https://github.com/charmbracelet/x - monorepo
- https://issues.guix.gnu.org/63019, requires
https://github.com/Azure/azure-sdk-for-go - monorepo
- updating aws-sdk-go-v2 https://github.com/aws/aws-sdk-go-v2

Thanks,
Oleg

[-- Attachment #1.2: Type: text/html, Size: 1388 bytes --]

[-- Attachment #2: Screenshot_20240904-200044.png --]
[-- Type: image/png, Size: 144457 bytes --]

  parent reply	other threads:[~2024-09-04 19:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-16 10:26 [bug#69827] [PATCH 1/3] build-system/go: Add subdir parameter to go-version->git-ref Christina O'Donnell
2024-03-16 10:30 ` [bug#69827] [PATCH 2/3] import/go: Account for monorepo modules in the Go importer Christina O'Donnell
2024-03-16 10:30 ` [bug#69827] [PATCH 3/3] import/go: Add diagnostics Christina O'Donnell
2024-03-16 10:45 ` [bug#69827] Fixing the go importer so that it can import modules located in a monorepo Christina O'Donnell
2024-04-16 19:05 ` [bug#69827] [PATCH 1/3] build-system/go: Add subdir parameter to go-version->git-ref Sharlatan Hellseher
2024-05-11 12:04 ` Christina O'Donnell
2024-09-04 19:18 ` Sharlatan Hellseher [this message]
2024-09-07 14:28 ` Sharlatan Hellseher
2024-09-10 12:21   ` Simon Tournier
2024-09-15 20:40 ` bug#69827: " Sharlatan Hellseher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAO+9K5q6oOCgZX2uDVjkRrTjQSncAu74OwJ08ufvLtHKhejC4g@mail.gmail.com \
    --to=sharlatanus@gmail.com \
    --cc=69827@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).