unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Sharlatan Hellseher <sharlatanus@gmail.com>
To: Nicolas Graves <ngraves@ngraves.fr>
Cc: 66180-done@debbugs.gnu.org
Subject: [bug#66180] [PATCH 00/19] Sort packages in node-xyz.scm
Date: Sun, 18 Feb 2024 14:48:13 +0000	[thread overview]
Message-ID: <CAO+9K5pqwWaCJ9oOCh=Bp644u_WZub2KbA+udqLSawwsrOyoGw@mail.gmail.com> (raw)
In-Reply-To: <87edd9lubm.fsf@ngraves.fr>

Hi Nicolas,

From recent split job for golang I may say that the order and placement of the
inherited package is very important.

There are two simple rules I've followed:

- inherited package needs to be in the same Guile module
- inherited package needs to follow the one which it's inherited from

Take a look at golang-xyz.scm, it's freshly created, alphabetically sorted and
all inherited packages following 2 mentioned rules.

--
Oleg

On Sun, 18 Feb 2024 at 14:29, Nicolas Graves <ngraves@ngraves.fr> wrote:
>
> On 2024-02-18 15:23, Nicolas Graves wrote:
>
> > On 2024-02-18 13:06, Sharlatan Hellseher wrote:
> >
> >> Hi Nicolas,
> >>
> >> I've checked packages order once again and found that some of them still
> >> need to be re-allocated but due to inheritance it can't be done easily.
> >>
> >> e.g. package node-serialport needs to be the one from the rest are inheritated.
> >>
> >> - node-serialport-binding-abstract
> >> - node-serialport-bindings
> >> - node-serialport-parser-byte-length
> >> - node-serialport-parser-cctalk
> >> - node-serialport-parser-delimiter
> >> - node-serialport-parser-inter-byte-timeout
> >> - node-serialport-parser-readline
> >> - node-serialport-parser-ready
> >> - node-serialport-parser-regex
> >> - node-serialport-stream
> >>
> >> May you check it please in the next round?
> >
> > Will do.
>
> I'm not sure how to do that though with these inheritance issues. Do you
> have an example in Guix source where this kind of things is done?
> >
> >>
> >> I've used Emacs' occur, search for define-public, copied to an empty
> >> buffer A and in buffer B sorted lines, then run buffer-diff on A and B.
> >> --8<---------------cut here---------------start------------->8---
> >> diff -u --label \#\<buffer\ \*new\*\<3\>\> --label \#\<buffer\ \*new\*\<4\>\> /tmp/buffer-content-SbBuJ0 /tmp/buffer-content-bu3SO4
> >> --- #<buffer *new*<3>>
> >> +++ #<buffer *new*<4>>
> >> @@ -30,17 +30,17 @@
> >>  define-public node-safe-stable-stringify
> >>  define-public node-segfault-handler
> >>  define-public node-semver
> >> +define-public node-serialport
> >>  define-public node-serialport-binding-abstract
> >> +define-public node-serialport-bindings
> >> +define-public node-serialport-parser-byte-length
> >> +define-public node-serialport-parser-cctalk
> >>  define-public node-serialport-parser-delimiter
> >> +define-public node-serialport-parser-inter-byte-timeout
> >>  define-public node-serialport-parser-readline
> >> -define-public node-serialport-bindings
> >> -define-public node-serialport-parser-regex
> >>  define-public node-serialport-parser-ready
> >> -define-public node-serialport-parser-inter-byte-timeout
> >> -define-public node-serialport-parser-cctalk
> >> -define-public node-serialport-parser-byte-length
> >> +define-public node-serialport-parser-regex
> >>  define-public node-serialport-stream
> >> -define-public node-serialport
> >>  define-public node-sqlite3
> >>  define-public node-stack-trace
> >>  define-public node-statsd-parser
> >> --8<---------------cut here---------------end--------------->8---
> >>
> >> Your servcie is pushed as aede3fa122..345a54ff4c to master.
> >>
> >> --
> >> Oleg
>
> --
> Best regards,
> Nicolas Graves



-- 
VCS: https://github.incerto.xyz/; https://git.sr.ht/~hellseher/
GPG: 9847 81DE 689C 21C2 6418 0867 76D7 27BF F62C D2B5

… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.




      reply	other threads:[~2024-02-18 14:50 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-24 12:47 [bug#66180] [PATCH 00/19] Sort packages in node-xyz.scm Nicolas Graves via Guix-patches via
2023-09-24 12:50 ` [bug#66180] [PATCH 01/19] gnu: node-bindings: Move package in alphabetical order Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 02/19] gnu: node-util-deprecate: " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 03/19] gnu: node-once: " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 04/19] gnu: node-ieee754: " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 05/19] gnu: node-inherits: " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 06/19] gnu: node-safe-buffer: " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 07/19] gnu: node-string-decoder: " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 08/19] gnu: node-readable-stream: " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 09/19] gnu: node-irc and node-irc-colors: Move " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 10/19] gnu: node-nan: Move package " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 11/19] gnu: node-addon-api: " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 12/19] gnu: node-sqlite3: " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 13/19] gnu: node-file-uri-to-path: " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 14/19] gnu: node-segfault-handler: " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 15/19] gnu: node-ms: " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 16/19] gnu: node-debug: " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 17/19] gnu: node-serialport packages: Move packages " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 18/19] gnu: node-semver: Move package " Nicolas Graves via Guix-patches via
2023-09-24 12:50   ` [bug#66180] [PATCH 19/19] gnu: packages: node-xyz: Add alphatical order header Nicolas Graves via Guix-patches via
2024-02-04 12:40 ` [bug#66180] [PATCH v2 01/20] gnu: node-bindings: Move package in alphabetical order Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 02/20] gnu: node-util-deprecate: " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 03/20] gnu: node-once: " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 04/20] gnu: node-ieee754: " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 05/20] gnu: node-inherits: " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 06/20] gnu: node-safe-buffer: " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 07/20] gnu: node-string-decoder: " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 08/20] gnu: node-readable-stream: " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 09/20] gnu: node-irc and node-irc-colors: Move " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 10/20] gnu: node-nan: Move package " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 11/20] gnu: node-addon-api: " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 12/20] gnu: node-sqlite3: " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 13/20] gnu: node-file-uri-to-path: " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 14/20] gnu: node-segfault-handler: " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 15/20] gnu: node-ms: " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 16/20] gnu: node-debug: " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 17/20] gnu: packages: node-xyz: Add alphatical order header Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 18/20] gnu: node-semver: Move package in alphabetical order Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 19/20] gnu: node-path-key: " Nicolas Graves via Guix-patches via
2024-02-04 12:40   ` [bug#66180] [PATCH v2 20/20] gnu: node-serialport-*: Move packages " Nicolas Graves via Guix-patches via
2024-02-10 16:16 ` [bug#66180] [PATCH 00/19] Sort packages in node-xyz.scm Sharlatan Hellseher
2024-02-18 12:02   ` ngraves--- via Guix-patches via
2024-02-18 12:02   ` ngraves--- via Guix-patches via
2024-02-18 13:06 ` bug#66180: " Sharlatan Hellseher
2024-02-18 14:23   ` [bug#66180] " Nicolas Graves via Guix-patches via
2024-02-18 14:29     ` Nicolas Graves via Guix-patches via
2024-02-18 14:48       ` Sharlatan Hellseher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAO+9K5pqwWaCJ9oOCh=Bp644u_WZub2KbA+udqLSawwsrOyoGw@mail.gmail.com' \
    --to=sharlatanus@gmail.com \
    --cc=66180-done@debbugs.gnu.org \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).