From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2J4gGMG+1GGtYgAAgWs5BA (envelope-from ) for ; Tue, 04 Jan 2022 22:40:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id j7SYFcG+1GF1AwAA9RJhRA (envelope-from ) for ; Tue, 04 Jan 2022 22:40:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 696C43AF5B for ; Tue, 4 Jan 2022 22:40:14 +0100 (CET) Received: from localhost ([::1]:53560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4rXQ-0006DT-Dw for larch@yhetil.org; Tue, 04 Jan 2022 16:40:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4rXH-00068z-Dv for guix-patches@gnu.org; Tue, 04 Jan 2022 16:40:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n4rXH-0001Q2-4a for guix-patches@gnu.org; Tue, 04 Jan 2022 16:40:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n4rXF-0001zO-Pi for guix-patches@gnu.org; Tue, 04 Jan 2022 16:40:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51765] Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 04 Jan 2022 21:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51765 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51765@debbugs.gnu.org Cc: Vinicius Monego Received: via spool by 51765-submit@debbugs.gnu.org id=B51765.16413323807612 (code B ref 51765); Tue, 04 Jan 2022 21:40:01 +0000 Received: (at 51765) by debbugs.gnu.org; 4 Jan 2022 21:39:40 +0000 Received: from localhost ([127.0.0.1]:38905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4rWt-0001yi-OR for submit@debbugs.gnu.org; Tue, 04 Jan 2022 16:39:40 -0500 Received: from mail-wr1-f44.google.com ([209.85.221.44]:45764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4rWr-0001yW-Rg for 51765@debbugs.gnu.org; Tue, 04 Jan 2022 16:39:38 -0500 Received: by mail-wr1-f44.google.com with SMTP id v7so78710863wrv.12 for <51765@debbugs.gnu.org>; Tue, 04 Jan 2022 13:39:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wWmYA2+eKnSuOCmuOcCxeOwXmGe+v85vgZFMH4x5qiQ=; b=W8b1p5QQTXMG8zltlc1l2XYOUcETJL/dX9o6ChKrU0135y7ciSrVYZjdICuD5sXWOA FmWhvu4t1uvuDOFNoe6DdzfOfronwfBJ4S8aelC8DOSp6UzYf14lDQShRht3VRGV3YNQ nDHw9uGq/AXOr1qjyphciZvHdWAA4nU12yXPp4LesE7mvcDsbdZAVoIy1GyXtfiw4Umj q4e8Xz+NnXgGWvvk2XXByGtVX/kCKAr9X0Orkdoq2qSHxJahVm8nyuQtBq3pvnukA630 aYykoRqSnUsI/gArufDeqewmG/YlfY2RH2VyeheJ9rGBj1mVjOmU9q5x4uZcYI9TQA1P YbBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wWmYA2+eKnSuOCmuOcCxeOwXmGe+v85vgZFMH4x5qiQ=; b=xlxGkGaaAk593drFXNnaAUu5t7A9d2F/woot/BmE1aa1QNW0+NwQ1nc4Q4qNn/b1TC eC60GB761YTiNLWkTCqRzif6pZzKNUdeFbi88XqGZr9xFNCse7Mh+PidwS/jeON5gyb5 JWNLZNAQUgW9Eue0XIBR/uEB91EmKSniBBekNlbrE12BNaR9gu9dTCvEVcg63eSGjMzT L8yVOzsfZ5j0kHU0zwcWcHDc7iSC2hQ6nViQj4KohvWxC+Rd/A4sZfi0EkrdlSOkq+G9 Z/y+xE91Myz/wpOLEiR1uchmUDXjbU+TggoRY7d5I42remAgq9wmyLMwYLhg3XxxyuCo ZDpg== X-Gm-Message-State: AOAM533rUti+70UiGwiaHOzfyNx+4PCLBcLhdYDhR7tuzA7sQATfNYtU yvPxbqia4ctOcxX8KjPg7RefiUTdKGjXqpUc4DP0HTDHEPA= X-Google-Smtp-Source: ABdhPJwyMli4rt9D4j9m539sMBQ6aoY4sHj65Vft4JcbjFf2YEZSz1eC46Fct35yKHWdLh43Su2k/M8xmfDLCAASrPs= X-Received: by 2002:a5d:5604:: with SMTP id l4mr10800448wrv.414.1641332371970; Tue, 04 Jan 2022 13:39:31 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Sharlatan Hellseher Date: Tue, 4 Jan 2022 21:39:21 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641332414; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=wWmYA2+eKnSuOCmuOcCxeOwXmGe+v85vgZFMH4x5qiQ=; b=ZOrCDvAlICWpLXa2g49jDwbOlTyfZwr5NcHkMo/pWBIFO6m9XwBGLSA3WNMoqf/ZIo/M6j BsGBrJd2wQ53FKYuE2iSPygFn1KR9DdUpZzBo+0OVd0mOxBUlD+CHiFuDI0dWX+bIjNbEE k7IfEmN9RjDbb64X9NiE7LedV1XaffELEYPjvXwe5jDAbSmtMszOiLC0Y+IA4ef9UU3uf+ 5DL7nJBT3ZiR9OEW9nklIqLOjim0DJ8OaLe3yHDuh85r2ffT1DdHHXpQ37SPomXtN9uTaV Xbw6PH+bfjfvs0MiSfpQ9MZYJoNowwjpFailmNV9NkGvkuOayvM/wJctLQW62A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641332414; a=rsa-sha256; cv=none; b=CJPsZvCxbrCR7tdT774m96wfS5+3DhmycSXjJtqaaEsVUARGRi3eWtYRnMi9cYu8HCYyCL W/YX48v/TODiIMO6DWuwVNGd+oCr1weoNgzaZ5utlPNwKIsaK/KkACoqETwtF0OAqgnpu+ ArbkMWnWQGDxnIE97BK/a3ZvJi3PeLGWBV9+NQPGcGiBX0dJdJLVWElQIy32RXzTBiDaIm 4xilUoJk0Y1s86pkv6Q80pLM13nsg4ra6czFe0LfTvXY/vjFxkOeHf8LJLEs0sp9EK/FJk C2tJknfEts9MV6YKbRUE2Z86MYqnA6jcqatExoNUe6Hwn6zozLSDimSQfN8dtA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=W8b1p5QQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.49 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=W8b1p5QQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 696C43AF5B X-Spam-Score: -1.49 X-Migadu-Scanner: scn1.migadu.com X-TUID: 0hNUBIZhuf82 Hi! Thank you for fead back @Vinicius Monego ! I've added aditional changes to all mentioned patches but I've not created patch list from scratch. Let me know if would be easy to merge patches first. Sharlatan Hellseher (5): gnu: asdf-transform-schemas: Enable tests gnu: asdf-coordinates-schemas: Enable tests gnu: asdf-astropy: Enable tests gnu: asdf-wcs-schemas: Enable tests gnu: gwcs: Refactor package gnu/packages/astronomy.scm | 101 +++++++++++++++++++++---------------- 1 file changed, 57 insertions(+), 44 deletions(-) base-commit: 4c812db049d5c9f2c438748e180f9486ad221b0a prerequisite-patch-id: 56820d9ea09a7a53f0c576466db455e706707db2 prerequisite-patch-id: ad03d8286b6789e5c16216f66766ffa403ba2e87 prerequisite-patch-id: 7ada40e42ec009357b74914aa3ed3e31bc0924aa prerequisite-patch-id: 18f6a0a2503f7359d051f10cfe01e421a3c20511 prerequisite-patch-id: dabf500576aec3742492c67f9a80fabf56872502 prerequisite-patch-id: ee0536ce1c726c3c7cea82067b7bc983d785139c On Tue, 4 Jan 2022 at 02:41, Vinicius Monego wrote: > > Hi Sharlatan, > > I am commenting on the second patch and will comment on the others in > this same message. > > > + (arguments > > + (list > > + ;; FIXME: (Sharlatan-20211229T160902+0000): tests run via tox > > + #:tests? #f)) > > The procedure is more or less the same for all Astropy related > packages. They use tox as an abstraction for pytest. You can run tests > by overriding the check phase: > > > (arguments > > `(#:phases > > (modify-phases %standard-phases > > (replace 'check > > (lambda* (#:key inputs outputs tests? #:allow-other-keys) > > (when tests? > > (add-installed-pythonpath inputs outputs) > > (invoke "python" "-m" "pytest"))))))) > > I also had to add a few more native inputs: > > > (native-inputs > > (list python-jsonschema > > python-numpy > > python-pytest > > python-pyyaml > > python-semantic-version > > python-setuptools-scm)) > > It should work all the same for the remaining packages in the series. > > There's no need to add a comment about the copyright holder: > > > + ;; Copyright (C) 2021 Association of Universities for Research > > in Astronomy (AURA) > > + ;; > > https://github.com/asdf-format/asdf-transform-schemas/blob/master/LICEN= SE > > Some of the other patches like 3 and 4 do not follow description > standards like missing full sentences and full stop. You can run `guix > lint` in the packages to catch some linting errors. > > In patch 6, gexp is being used without ungexp. In that case it > shouldn't be used. `(arguments (list ...))` should be `(arguments `())` > when gexp isn't being used, same for the other patches too. gwcs > license is bsd-3 according to copyright headers and the LICENSE file in > the license/ directory. Inputs in patches 5 and 6 may also have to be > propagated if they are libraries. > --=20 =E2=80=A6 =D0=BD=D0=B0=D1=88 =D1=80=D0=B0=D0=B7=D1=83=D0=BC - =D0=BF=D1=80= =D0=B5=D0=B2=D0=BE=D1=81=D1=85=D0=BE=D0=B4=D0=BD=D0=B0=D1=8F =D0=BE=D0=B1= =D1=8A=D1=8F=D1=81=D0=BD=D0=B8=D1=82=D0=B5=D0=BB=D1=8C=D0=BD=D0=B0=D1=8F = =D0=BC=D0=B0=D1=88=D0=B8=D0=BD=D0=B0 =D0=BA=D0=BE=D1=82=D0=BE=D1=80=D0=B0= =D1=8F =D1=81=D0=BF=D0=BE=D1=81=D0=BE=D0=B1=D0=BD=D0=B0 =D0=BD=D0=B0=D0=B9=D1=82=D0=B8 =D1=81=D0=BC=D1=8B=D1=81=D0=BB =D0=BF=D0=BE= =D1=87=D1=82=D0=B8 =D0=B2 =D1=87=D0=B5=D0=BC =D1=83=D0=B3=D0=BE=D0=B4=D0=BD= =D0=BE, =D0=B8=D1=81=D1=82=D0=BE=D0=BB=D0=BA=D0=BE=D0=B2=D0=B0=D1=82=D1=8C = =D0=BB=D1=8E=D0=B1=D0=BE=D0=B9 =D1=84=D0=B5=D0=BD=D0=BE=D0=BC=D0=B5=D0=BD, = =D0=BD=D0=BE =D1=81=D0=BE=D0=B2=D0=B5=D1=80=D1=88=D0=B5=D0=BD=D0=BD=D0=BE =D0=BD=D0=B5 = =D0=B2 =D1=81=D0=BE=D1=81=D1=82=D0=BE=D1=8F=D0=BD=D0=B8=D0=B8 =D0=BF=D1=80= =D0=B8=D0=BD=D1=8F=D1=82=D1=8C =D0=BC=D1=8B=D1=81=D0=BB=D1=8C =D0=BE =D0=BD= =D0=B5=D0=BF=D1=80=D0=B5=D0=B4=D1=81=D0=BA=D0=B0=D0=B7=D1=83=D0=B5=D0=BC=D0= =BE=D1=81=D1=82=D0=B8.