From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EPjOBcy0qmBXKAEAgWs5BA (envelope-from ) for ; Sun, 23 May 2021 22:02:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 8DF9Acy0qmCaDwAA1q6Kng (envelope-from ) for ; Sun, 23 May 2021 20:02:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6B36510937 for ; Sun, 23 May 2021 22:02:19 +0200 (CEST) Received: from localhost ([::1]:38742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lkuIk-0006Gk-1n for larch@yhetil.org; Sun, 23 May 2021 16:02:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkuIU-0006GX-08 for guix-patches@gnu.org; Sun, 23 May 2021 16:02:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lkuIT-0005dG-QN for guix-patches@gnu.org; Sun, 23 May 2021 16:02:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lkuIT-0005aX-NU for guix-patches@gnu.org; Sun, 23 May 2021 16:02:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48046] [PATCH]: Gnu add astropy Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 23 May 2021 20:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48046 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego Cc: 48046@debbugs.gnu.org Received: via spool by 48046-submit@debbugs.gnu.org id=B48046.162180007919491 (code B ref 48046); Sun, 23 May 2021 20:02:01 +0000 Received: (at 48046) by debbugs.gnu.org; 23 May 2021 20:01:19 +0000 Received: from localhost ([127.0.0.1]:41799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkuHn-00053v-5k for submit@debbugs.gnu.org; Sun, 23 May 2021 16:01:19 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:40846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkuHl-0004xY-37 for 48046@debbugs.gnu.org; Sun, 23 May 2021 16:01:18 -0400 Received: by mail-wr1-f47.google.com with SMTP id z17so26316087wrq.7 for <48046@debbugs.gnu.org>; Sun, 23 May 2021 13:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=VhupdRUJvGDzBHxqSTX8y7dnu9BNX+Bw9NdvK7ewaiw=; b=i2+KzFgHUK2wZZAFpgnAn9ul81vfjdUsfx5Q3yFQ4UPeE95nwfal4zCuwUnbi46YoO 7DSiNH4h52I+zW7CYgp9P/1BeOrwBP5Tf3Qgz6FiKwpNy0xVGLd6ujfQkiww+He3aHk3 etdljbWTCrGZIAafbDzWBZFcilWmPyOdluJMd0Ai6EWObffOh8bbkEUXKPspoVCxnGpz at/bM8vzREOj9/EcfmM8QJnoS+lbQlKSeTxVwysPYYnsrP4SBbXI4I8lXDtKLU3HkHmz 5NtvsE2Zs4nvfyo/YsH2rforfifRbxXuZbwaMBLFREACp3hU0ZSAPFDM5crvKOxvGpdw yyQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VhupdRUJvGDzBHxqSTX8y7dnu9BNX+Bw9NdvK7ewaiw=; b=b+RbDDQMmVJ1atj/RVYJPwpmth390zort+YcGCs6f6l5zhhpwvVki7MWEr4o04h/iX U6M/fJyenvMmBCVNEogUWnJZd8EC345+fMBA4hkxqSyQHeXoP+zk7RaVWZSyC04TsaXq tB/qIPdzOoD8sDYmdxfoJSuDPnz3BdcZBZYUxZmchQpbcIkmESOPWyYjLMh3bRVXZ46i O/H1s7tUQcwdyFVjI4Q8cgrI3OD1SyB96yNdWQM8xk8JWUnrMzLwGkgHdlT8fq4wkBmn QGGW6YV/olVO4sK7IvNsYZRQuGFBiA7QzLVXDKSx4zLgfkSbxIW2d21HE/tOPSImXoN+ 1iSQ== X-Gm-Message-State: AOAM533PU3EGjrMXj/bEt2Tc7iaiBQQTjByINxFPe732RfAUsTP8EA8f 15Y1K84NYAGZQDRZO9OLJRNugkCz6bsmKKBAzB4= X-Google-Smtp-Source: ABdhPJyYpF4f9WNYdN5OWGHujIfSOIXQlayz7d08HEC+iR3na1jS87KZGpH0P7lfxMRM9ozoigfT2c0ebWbY5Xkym4Q= X-Received: by 2002:adf:e48b:: with SMTP id i11mr19174905wrm.228.1621800071203; Sun, 23 May 2021 13:01:11 -0700 (PDT) MIME-Version: 1.0 References: <7055d87cdde449415e62f0b0c15d96deb378af67.camel@posteo.net> In-Reply-To: <7055d87cdde449415e62f0b0c15d96deb378af67.camel@posteo.net> From: Sharlatan Hellseher Date: Sun, 23 May 2021 20:01:00 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621800139; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=VhupdRUJvGDzBHxqSTX8y7dnu9BNX+Bw9NdvK7ewaiw=; b=JOHMApyBciOCfj8LD2bpFBq4jovAho/tqAHTergsFwYg1tLpPgIwBxAnkc3sEcf5Q6/MpA AuKM5eBCVkoUGnbv6cFXF6nnf3wO9/yrb/6zZNdLPGnjRn3EhOPNW9PPgC4luM9va+EkD1 kg+6HvgY//ss41Z/MMTKKKTttQ3gNXapbllfEgOWkwy9/COTmsCBLT2Hn1lQZH/ClSfhSh wVx1Ur+a5YtsB7n5pF/Cl1ZGwVA1PN90lN8WOUu+pBnZt/OYrOo82u+fE0GF8SeXdnP7Ui 3cfPv2b+dyVy3kWkyC/qUu2J8Hbf/FzmoKJa1FpzHGCx1pcBrzC4O0teeupiLQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621800139; a=rsa-sha256; cv=none; b=CfkiESaiWNGmXm4LFCaagBMKgCrv7XfFISp8Jez5PN105Bv0krgFc9IqDnslMGLml3S8Yn q7L2xsPOPTCei4B7AKw+NkhuSVelfBgQEYHaM84kWcnto4igy5FPhOOLt+L13SuGAtp/bJ v90Jb/nNyKPt6RS4tQPMuVWJE4J8VeWPv8SfR3b4dE1kesylhOuR1kGd2ml1mCCljTyVHh KDFYcbZfWtQO5O6NpuF9aTLsuax/Dtodv7BkNDB4dwjAdc7ELxBF9XF0dqQVr1a6DrTnCT MFN8min/6IrXYHKZxrabB0vxKxLf1nfHooleHdjmtSxAzhrzfj/l9DwLr5HmvA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=i2+KzFgH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=i2+KzFgH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 6B36510937 X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: WUnFc4JAAWTl Hi Vinicius, It' fantastic! Thanks for your feedback and modification, I'm absolutely ok with them. When astropy is accepted it will open a way for other astronomical packages which are depend on it, and I've noticed some other packages in master require astropy for tests so it would beneficial to have it merged :)! On Sun, 23 May 2021 at 17:54, Vinicius Monego wrote: > > Hi Sharlatan, > > Thanks for continuing the work on the astropy package, I managed to > finish it this time. I am resending your patch with the following > modifications: > > - Moved the package definition from the bottom to the middle of the > file (to avoid merge conflicts) > - Removed all optional inputs and propagated the remaining. I left only > those listed in install_requires, setup_requires, test_requires and > test[extras] in setup.cfg > - Changed synopsis and description > - Changed package labels to match the package name > - Made the compiler file writable instead of deleting it > - Deleted the makdir-astropy phase (it wasn't needed) > - Added license for the jquery bundle that is not replaced > > and then I made my own improvements on that patch: enabling tests and > unbundling some external libraries. > > I removed the optional packages because astropy is a core package, > which will be a dependency for its many extensions. It's important that > it builds with a high probability of success or the chain will break. > Some of its optional dependencies, e.g. Pandas, have a broken build in > aarch64 at the moment. The "full" astropy package could be installed > easily from a manifest file and the tests can run again with > astropy.test(). > > > the project heavily depends on TOX which requires pip to install > > missing dependencies for itself. > > I don't think that a project can heavily depend on tox, all it does is > manage a virtual environment with dependencies to run the tests. Guix > does the same so tox is redundant here. Tests will still run with the > testing framework. > > Two more suggestions for future Python patches: > > > + (replace 'check > > + (lambda* (#:key inputs outputs #:allow-other-keys) > > + (add-installed-pythonpath inputs outputs) > > + (invoke "pytest" "-vv"))) > > When a project contains tests as part of the application code, as in > Astropy, tests should run with "pytest --pyargs module". See Pytest > Integration Pratices: > https://docs.pytest.org/en/documentation-restructure/background/goodpract= ices.html > > It's also good practice in Guix to use (when tests?) when overriding > the check phase to allow --without-tests=3Dpkg. > > > ImportError: You appear to be trying to import astropy from within a > > source checkout or from an editable installation without building the > > extension modules first. Either run: > > I fixed this error by running the second command before the tests. > > If you don't mind the modifications I did, I will call this patchset > complete and wait for a committer to review. > > Vinicius --=20 =E2=80=A6 =D0=BD=D0=B0=D1=88 =D1=80=D0=B0=D0=B7=D1=83=D0=BC - =D0=BF=D1=80= =D0=B5=D0=B2=D0=BE=D1=81=D1=85=D0=BE=D0=B4=D0=BD=D0=B0=D1=8F =D0=BE=D0=B1= =D1=8A=D1=8F=D1=81=D0=BD=D0=B8=D1=82=D0=B5=D0=BB=D1=8C=D0=BD=D0=B0=D1=8F = =D0=BC=D0=B0=D1=88=D0=B8=D0=BD=D0=B0 =D0=BA=D0=BE=D1=82=D0=BE=D1=80=D0=B0= =D1=8F =D1=81=D0=BF=D0=BE=D1=81=D0=BE=D0=B1=D0=BD=D0=B0 =D0=BD=D0=B0=D0=B9=D1=82=D0=B8 =D1=81=D0=BC=D1=8B=D1=81=D0=BB =D0=BF=D0=BE= =D1=87=D1=82=D0=B8 =D0=B2 =D1=87=D0=B5=D0=BC =D1=83=D0=B3=D0=BE=D0=B4=D0=BD= =D0=BE, =D0=B8=D1=81=D1=82=D0=BE=D0=BB=D0=BA=D0=BE=D0=B2=D0=B0=D1=82=D1=8C = =D0=BB=D1=8E=D0=B1=D0=BE=D0=B9 =D1=84=D0=B5=D0=BD=D0=BE=D0=BC=D0=B5=D0=BD, = =D0=BD=D0=BE =D1=81=D0=BE=D0=B2=D0=B5=D1=80=D1=88=D0=B5=D0=BD=D0=BD=D0=BE =D0=BD=D0=B5 = =D0=B2 =D1=81=D0=BE=D1=81=D1=82=D0=BE=D1=8F=D0=BD=D0=B8=D0=B8 =D0=BF=D1=80= =D0=B8=D0=BD=D1=8F=D1=82=D1=8C =D0=BC=D1=8B=D1=81=D0=BB=D1=8C =D0=BE =D0=BD= =D0=B5=D0=BF=D1=80=D0=B5=D0=B4=D1=81=D0=BA=D0=B0=D0=B7=D1=83=D0=B5=D0=BC=D0= =BE=D1=81=D1=82=D0=B8.