From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GPI2J+Liy1+KdQAA0tVLHw (envelope-from ) for ; Sat, 05 Dec 2020 19:43:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id G07YIuLiy19nCQAAB5/wlQ (envelope-from ) for ; Sat, 05 Dec 2020 19:43:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 55D6F9404FF for ; Sat, 5 Dec 2020 19:43:30 +0000 (UTC) Received: from localhost ([::1]:43152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kldSr-0001JC-AL for larch@yhetil.org; Sat, 05 Dec 2020 14:43:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kldSS-0001Gi-Uu for guix-patches@gnu.org; Sat, 05 Dec 2020 14:43:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36711) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kldSQ-0001yI-6q for guix-patches@gnu.org; Sat, 05 Dec 2020 14:43:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kldSQ-0002ZM-3V for guix-patches@gnu.org; Sat, 05 Dec 2020 14:43:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45011] [PATCH] add emacs-project and dependency Resent-From: Jonathan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Dec 2020 19:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45011 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 45011@debbugs.gnu.org Received: via spool by 45011-submit@debbugs.gnu.org id=B45011.16071973239791 (code B ref 45011); Sat, 05 Dec 2020 19:43:02 +0000 Received: (at 45011) by debbugs.gnu.org; 5 Dec 2020 19:42:03 +0000 Received: from localhost ([127.0.0.1]:48253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kldRP-0002XX-PS for submit@debbugs.gnu.org; Sat, 05 Dec 2020 14:42:03 -0500 Received: from mail-ua1-f65.google.com ([209.85.222.65]:36320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kldRO-0002XJ-KB for 45011@debbugs.gnu.org; Sat, 05 Dec 2020 14:41:59 -0500 Received: by mail-ua1-f65.google.com with SMTP id q68so3087290uaq.3 for <45011@debbugs.gnu.org>; Sat, 05 Dec 2020 11:41:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T9WQrol5T0bIlknT2aIugZ673q8ikWKhryxb+x78ALI=; b=nmPSsp2WYSgZvFXaUdD9UBnpumHiPuuTA7kE0jE4h96MNFTyUpFNMZ1kaVa01MceVX geRArUqWQvJbSPuHomNlyjbuG3E+GC92X+uz2f5OsNzlW7GRAIPLq+Jpo6JUf+6DliBA YrDGwQJ3Za77y0CsK49WVzwKcDOsAOt+nD6TLqLiqwFqGFLs9jaBbuIETy3w9RSazgAb byZB7IYebKGGBKvi6e3rCDViSrnY3/KHB8WXc5bv6PKHTd6eDhsoF91xiSbC16Gni/Kr TIuUKzwPx2dTI267tADbCsd7WU6GgaQfN/qhuxYy85bn3HCi3l0BLD7/Uabx8B5yJsgR NbGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T9WQrol5T0bIlknT2aIugZ673q8ikWKhryxb+x78ALI=; b=htOP8HPtGzfzlvX4xFV7DTaFoVimx1aI/tAP+rkkxgmwYEWzVxPRIS/fjzzLh25gzp zFXd6uQ8oD6D+ZCA4rfMYyFoeAnBnN8olSU/h6fjzrEYRYvsnhNYzJBDZKUWYGEA43s/ eiM6w1Q2+FjhzmMc69cA9QehhoGpvzn7lwOkNOJ+k90dOf4HyzP5CrBNB1STO/MYgcRh R0ELzuI6hV76rc/wd/nHo5KxJhvvMSKBOvgFVM1WDbcBFqybn3l8qLwY4ee2n19m/sNP gJ5bj2KHwYgxwn0i9TxwGfzUky8OjaYEon3T/vKWvtCdcoFyx1EUJkizXzu14zuhCyhz 2sKw== X-Gm-Message-State: AOAM530kj9wuZG9D4uvu/EryVS2Eyhv9MbTDDnNSkxgbSW9p0lLu5Q7C PE7oKzvHTujoVyro47Dw4gndRKGWcC+3gLdLl+o= X-Google-Smtp-Source: ABdhPJzZLRyiCtdyLTjJG3/NycaAS8Ji+sN8Xh+jv8xBZMcrlpY0YB8rcMR+I7ELpacS17ywLdjJr4bLisyCKIlr/Bc= X-Received: by 2002:ab0:7811:: with SMTP id x17mr8346332uaq.51.1607197313056; Sat, 05 Dec 2020 11:41:53 -0800 (PST) MIME-Version: 1.0 References: <87lfedpby8.fsf@nicolasgoaziou.fr> In-Reply-To: <87lfedpby8.fsf@nicolasgoaziou.fr> From: Jonathan Date: Sat, 5 Dec 2020 13:41:42 -0600 Message-ID: Content-Type: multipart/alternative; boundary="000000000000edc36605b5bcc8da" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.20 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=nmPSsp2W; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 55D6F9404FF X-Spam-Score: -1.20 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: yhYrSdX416Yc --000000000000edc36605b5bcc8da Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable --- gnu/packages/emacs-xyz.scm | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 5eb8f7c1ea..8a3414d123 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -86,6 +86,7 @@ ;;; Copyright =C2=A9 2020 Tim Howes ;;; Copyright =C2=A9 2020 Noah Landis ;;; Copyright =C2=A9 2020 Nicol=C3=B2 Balzarotti +;;; Copyright =C2=A9 2020 Jonathan Rostran ;;; ;;; This file is part of GNU Guix. ;;; @@ -25754,3 +25755,33 @@ syntax highlighting and UI components.") "This Emacs package provides a Janet REPL to evaluate @code{janet-mode} s-expression.") (license license:expat)))) + +(define-public emacs-xref + (package + (name "emacs-xref") + (version "1.0.3") + (source + (origin + (method url-fetch) + (uri (string-append + "https://elpa.gnu.org/packages/xref-" + version + ".el")) + (sha256 + (base32 + "1r531gl73y1br8g4n77gxbyj26yiaw7snjad21fgs5m80cka8fi3")))) + (build-system emacs-build-system) + (home-page + "http://elpa.gnu.org/packages/xref.html") + (synopsis "Cross-referencing commands") + (description + "NOTE: The xref API is still experimental and can change in major, +backward-incompatible ways. Everyone is encouraged to try it, and +report to us any problems or use cases we hadn't anticipated, by +sending an email to emacs-devel, or `M-x report-emacs-bug'. + +This file provides a somewhat generic infrastructure for cross +referencing commands, in particular \"find-definition\". + +See the etags and elisp-mode implementations for full examples.") + (license license:gpl3+))) --=20 2.29.2 On Fri, Dec 4, 2020 at 2:12 PM Nicolas Goaziou wrote: > Hello, > > Jonathan writes: > > > gnu/packages/emacs-xyz.scm | 61 ++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 61 insertions(+) > > Thank you! > > Could you write a commit message to introduce your changes? You can look > at those starting with "Add ..." in the code base. > > Also, could you split it into two patches, one for each package? > > > + (synopsis "Operations on the current project") > > + (description > > + "NOTE: The project API is still experimental and can change in majo= r, > > +backward-incompatible ways. Everyone is encouraged to try it, and > > +report to us any problems or use cases we hadn't anticipated, by > > +sending an email to emacs-devel, or `M-x report-emacs-bug'. > > + > > +This file contains generic infrastructure for dealing with > > +projects, some utility functions, and commands using that > > +infrastructure.") > > The synopsis could be clarified, so could the description. In > particular, the latter explains what the library is about. > > > + (description > > + "NOTE: The xref API is still experimental and can change in major, > > +backward-incompatible ways. Everyone is encouraged to try it, and > > +report to us any problems or use cases we hadn't anticipated, by > > +sending an email to emacs-devel, or `M-x report-emacs-bug'. > > + > > +This file provides a somewhat generic infrastructure for cross > > +referencing commands, in particular \"find-definition\". > > + > > +See the etags and elisp-mode implementations for full examples.") > > Ditto. > > Could you send an updated patch? > > Regards, > -- > Nicolas Goaziou > --000000000000edc36605b5bcc8da Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
---
=C2=A0gnu/packages/emacs-xyz.scm | 31 +++++++++++++= ++++++++++++++++++
=C2=A01 file changed, 31 insertions(+)

diff --= git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5eb8= f7c1ea..8a3414d123 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/= packages/emacs-xyz.scm
@@ -86,6 +86,7 @@
=C2=A0;;; Copyright =C2=A9 2= 020 Tim Howes <timhowes@lavabit.= com>
=C2=A0;;; Copyright =C2=A9 2020 Noah Landis <noahlandis@posteo.net>
=C2=A0;;; Cop= yright =C2=A9 2020 Nicol=C3=B2 Balzarotti <nicolo@nixo.xyz>
+;;; Copyright =C2=A9 2020 Jonathan Rostra= n <rostranjj@gmail.com>=C2=A0;;;
=C2=A0;;; This file is part of GNU Guix.
=C2=A0;;;
@@ -= 25754,3 +25755,33 @@ syntax highlighting and UI components.")
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 "This Emacs package provides a Janet REPL to = evaluate @code{janet-mode}
=C2=A0s-expression.")
=C2=A0 =C2=A0 = =C2=A0 =C2=A0(license license:expat))))
+
+(define-public emacs-xref<= br>+ =C2=A0(package
+ =C2=A0(name "emacs-xref")
+ =C2=A0(ve= rsion "1.0.3")
+ =C2=A0(source
+ =C2=A0 =C2=A0(origin
+ = =C2=A0 =C2=A0 =C2=A0(method url-fetch)
+ =C2=A0 =C2=A0 =C2=A0(uri (strin= g-append
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "https://elpa.gnu.org/packages/xref-&= quot;
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 version
+ =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ".el"))
+ =C2=A0 =C2=A0 =C2= =A0(sha256
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0(base32
+ =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0"1r531gl73y1br8g4n77gxbyj26yiaw7snjad21fgs5m80cka8fi3= "))))
+ =C2=A0(build-system emacs-build-system)
+ =C2=A0(home-pa= ge
+ =C2=A0 =C2=A0"http://elpa.gnu.org/packages/xref.html")
+ =C2=A0(synopsis &= quot;Cross-referencing commands")
+ =C2=A0(description
+ =C2=A0 = =C2=A0"NOTE: The xref API is still experimental and can change in majo= r,
+backward-incompatible ways.=C2=A0 Everyone is encouraged to try it, = and
+report to us any problems or use cases we hadn't anticipated, b= y
+sending an email to emacs-devel, or `M-x report-emacs-bug'.
+<= br>+This file provides a somewhat generic infrastructure for cross
+refe= rencing commands, in particular \"find-definition\".
+
+See= the etags and elisp-mode implementations for full examples.")
+ = =C2=A0(license license:gpl3+)))
--
2.29.2

On Fri, Dec 4, 2020 at = 2:12 PM Nicolas Goaziou <mail@= nicolasgoaziou.fr> wrote:
Hello,

Jonathan <rostr= anjj@gmail.com> writes:

>=C2=A0 gnu/packages/emacs-xyz.scm | 61 ++++++++++++++++++++++++++++++++= ++++++
>=C2=A0 1 file changed, 61 insertions(+)

Thank you!

Could you write a commit message to introduce your changes? You can look at those starting with "Add ..." in the code base.

Also, could you split it into two patches, one for each package?

> +=C2=A0 (synopsis "Operations on the current project")
> +=C2=A0 (description
> +=C2=A0 =C2=A0"NOTE: The project API is still experimental and ca= n change in major,
> +backward-incompatible ways.=C2=A0 Everyone is encouraged to try it, a= nd
> +report to us any problems or use cases we hadn't anticipated, by<= br> > +sending an email to emacs-devel, or `M-x report-emacs-bug'.
> +
> +This file contains generic infrastructure for dealing with
> +projects, some utility functions, and commands using that
> +infrastructure.")

The synopsis could be clarified, so could the description. In
particular, the latter explains what the library is about.

> +=C2=A0 (description
> +=C2=A0 =C2=A0 "NOTE: The xref API is still experimental and can = change in major,
> +backward-incompatible ways.=C2=A0 Everyone is encouraged to try it, a= nd
> +report to us any problems or use cases we hadn't anticipated, by<= br> > +sending an email to emacs-devel, or `M-x report-emacs-bug'.
> +
> +This file provides a somewhat generic infrastructure for cross
> +referencing commands, in particular \"find-definition\". > +
> +See the etags and elisp-mode implementations for full examples."= )

Ditto.

Could you send an updated patch?

Regards,
--
Nicolas Goaziou
--000000000000edc36605b5bcc8da--