From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aL+HKELvNGJlwgAAgWs5BA (envelope-from ) for ; Fri, 18 Mar 2022 21:44:50 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id CHUrJULvNGL/HQEAauVa8A (envelope-from ) for ; Fri, 18 Mar 2022 21:44:50 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1F93535C63 for ; Fri, 18 Mar 2022 21:44:50 +0100 (CET) Received: from localhost ([::1]:42812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVJSq-0000lL-EL for larch@yhetil.org; Fri, 18 Mar 2022 16:44:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVJR8-00065d-6R for guix-patches@gnu.org; Fri, 18 Mar 2022 16:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36369) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVJR7-0006K2-SC for guix-patches@gnu.org; Fri, 18 Mar 2022 16:43:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVJR7-0002c1-Qc for guix-patches@gnu.org; Fri, 18 Mar 2022 16:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#32947] Add java-xalan. Resent-From: Frank Pursel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Mar 2022 20:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32947 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 32947@debbugs.gnu.org Received: via spool by 32947-submit@debbugs.gnu.org id=B32947.16476361529997 (code B ref 32947); Fri, 18 Mar 2022 20:43:01 +0000 Received: (at 32947) by debbugs.gnu.org; 18 Mar 2022 20:42:32 +0000 Received: from localhost ([127.0.0.1]:58499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVJQd-0002bA-HV for submit@debbugs.gnu.org; Fri, 18 Mar 2022 16:42:32 -0400 Received: from mail-ej1-f53.google.com ([209.85.218.53]:33322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVJQc-0002ax-1U for 32947@debbugs.gnu.org; Fri, 18 Mar 2022 16:42:30 -0400 Received: by mail-ej1-f53.google.com with SMTP id pv16so19305159ejb.0 for <32947@debbugs.gnu.org>; Fri, 18 Mar 2022 13:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SnjD44Zo9z3c91bop7k8FCu1awIFnt9e8Bx38Ipnj28=; b=OEYirMPO1lkH5CNW+hiXsoNEVjJhPOslXp7VuS8nlxEDUqTUGRIrm+tBQePgBgHpA7 ltx039Gwu7GYMc3Dhomp91az6SkKPrrKubLsHWy791v4Dpx+sTr+xLvVhKckMt3LItCK xuE6l/P5STEo7JajZA2G2GTKP+QvFBzmiTVSzkpAx0uSqsqJ6u5jqaeIFB0c5ot4wGh4 xyoPKYbJ2JVNB9o9hM8lr58Ukm7xVhGOETHrEo93WJHOwduFRX0eka8PBxaWbWy71nQK 27YJ8TYpYm5NfHkuAGlmsifP3zwRSzkc+00N3x69klCo/7PvuHy0yARDMG3vawSpA/ap 5HCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SnjD44Zo9z3c91bop7k8FCu1awIFnt9e8Bx38Ipnj28=; b=2zw7nO7rmf42jTlOdhOj9JomsVItJAL/fiWW7TdBdiq/eiP7tcy5zRZAUWHm/x4+wY NIKkQBsbVYqN0HcaJ5GmD5D4p4RgZS5fKkRPrL5MWmlMUoklg9tGOLQtCXS6nF4dQjlq tzl5sKFyg+DO0Sh3wH4gXwjIFyEKxHodnOnUDwf7SABxlfteSimkd22l2Fj0sKWZA4OR 6/P9VAhCzx70gJDq8thZkST9RU080Gx1cyOKEcZfCc5QYyNewFJnxc/C8jDDBAxv3Bcl jQAPZaKB86V1pRxqWbCXH+hs8KqGMt1JAFTqoGB98OlLGdnn3et61SHPBtH1qZR+/y5+ RfXQ== X-Gm-Message-State: AOAM530jpYAMYhMvW2dLd4bJ7RMoZRQj9iH9hGxgJv3x6GIl82ZhYhnu rMFWDwzfjzin2dvPTKoqPv//nq5mhHM68GMyDB0= X-Google-Smtp-Source: ABdhPJyFStjC9da6IdoNjNwnlV2zE+F4nIcwbMvku4c1JrTQkuu95C4NNAbH3WRCzYSnO8YvE9YZmXg0j/ZoQqd+r/Y= X-Received: by 2002:a17:907:869f:b0:6da:888b:4258 with SMTP id qa31-20020a170907869f00b006da888b4258mr10787936ejc.720.1647636143884; Fri, 18 Mar 2022 13:42:23 -0700 (PDT) MIME-Version: 1.0 References: <87y217gjfa.fsf@Ginko.local.i-did-not-set--mail-host-address--so-tickle-me> In-Reply-To: From: Frank Pursel Date: Fri, 18 Mar 2022 20:42:11 +0000 Message-ID: Content-Type: multipart/alternative; boundary="00000000000013548c05da842fa9" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647636290; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=SnjD44Zo9z3c91bop7k8FCu1awIFnt9e8Bx38Ipnj28=; b=KelEJiEOuPlS9w6qAo9NK8SQioebHogM4vx0QkWtj1rt9vbn/b/Kx9FWBpl8hUTK42uOzX HGqHGbZkICJA+MHHlpJnvbhhhfFTC0Kt+F/j10pC94AOUOxB2j/vAVMxnlgk9qhVhDXWJY FOhVx+jgwf0aVIFF1iigja760AozBDhKHpeQ7pxjcYHQ7MTmSGrFQFM8bHuigpB3hezhYl 35Ui8Hgb05fFhwY6/H4e1MaFo4jvDw6RmNipQ6W9QWdi1pbc+0Y937QyY5hH3x9wwrNlxF xOPaU/Lbft61GZpvjR6SQ1j3uj925tzOSAFX+Qqtpi1D3MIzIN21iL519+XWaA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647636290; a=rsa-sha256; cv=none; b=c+DQi1jKrGXAKpG1lwN8kyTayurdY6PTisdCuGHRp8PEDQZqdKA1xd2EIhYKjkoXv8lpKC L130zL7FlIVCkEiYq1Pqz1tOEnwRLlLV4qXgzW6TnOYeYOUs9UWraO3RagiXnyte/uVbzF M982OHQgXh7VBjSYMjNEFgiLkLkjGjX0QNgtcEppndChY1QlCbxXZSc8vAL6GM7yJYXx/T QOHZAJ4O26slsmanCyz4ANLR/BfVc7QrrqEwpQgZUjbHH9YtaEG4mVRC9+ZVyD65451+hC ER4dx+9NUhRdSVU9UXytTyziKaaeD81Q+K2vTaPyBqU3M9muIoqQBs9+wK8mJQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=OEYirMPO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.96 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=OEYirMPO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1F93535C63 X-Spam-Score: 5.96 X-Migadu-Scanner: scn1.migadu.com X-TUID: OkJMcwlP1P78 --00000000000013548c05da842fa9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Very thorough! Apache is a bit sloppy, '(for-each delete-file (find-file...) is the minimalistic scheme we adore and I'll be happy to post a revised patch with all of that but I may wait until you've finished the source review because there is no telling what else has Apache has packed in there. Please let me know. Thanks, Frank On Fri, Mar 18, 2022 at 8:07 PM Maxime Devos wrote= : > Frank Pursel schreef op vr 18-03-2022 om 19:16 [+0000]: > > + (origin > > + (method url-fetch) > > + (uri (string-append > "mirror://apache/xalan/xalan-j/source/xalan-j_" > > + (string-replace-substring > > + version "." "_") > > + "-src.tar.gz")) > > + (sha256 > > + (base32 "166vg9i11qzi0vbv09abfb50q8caq8wr6zrwg0cwqws9k394l62w"= )) > > + (modules '((guix build utils))) > > + (snippet '(begin > > + ;; Removing bundled jars > > + (for-each > > + (lambda (f) > > + (delete-file f)) > > + (find-files "." "\\.(jar|tar\\.gz)$")))))) > > Can be simplified to: > > (snippet '(for-each delete-file (delete-files "." > "\\.(jar|tar\\.gz)$"))) > > Also, xalan-j_2_7_2/samples/AppletXMLtoHTML/rabbitwhorn.jpg is an > (uncoloured) > picture of a rabbit from Alice in Wonderland (not asl2.0). According to > , > the copyright has been expired. As such, perhaps the 'license' field > needs to be changed to > > (license (list license:asl2.0 ; almost everything > ;; samples/AppletXMLtoHTML/rabbitwhorn.jpg, according to > ;; < > https://commons.wikimedia.org/wiki/File:Alice_par_John_Tenniel_37.png> > license:public-domain)) > > Aside from that, LGTM. I've been reading the source code, not seeing > anything > =E2=80=98suspicous=E2=80=99 (malware etc.) so far (I'm currently at > xalan-j_2_7_2/src/org/apache/xalan/templates/FuncKey.java, 25%). > > Greetings, > Maxime. > --00000000000013548c05da842fa9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Very thorough!=C2=A0 Apache is a bit sloppy,=C2=A0 &#= 39;(for-each delete-file (find-file...) is the minimalistic scheme we adore= and I'll be happy to post a revised patch with all of that but I may w= ait until you've finished the source review because there is no telling= what else has Apache has packed in there.=C2=A0 Please let me know.

Thanks,
Frank

On Fri, Mar 18, 202= 2 at 8:07 PM Maxime Devos <max= imedevos@telenet.be> wrote:
Frank Pursel schreef op vr 18-03-2022 om 19:16 [+0000]:<= br> > +=C2=A0=C2=A0=C2=A0=C2=A0 (origin
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (method url-fetch)
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (uri (string-append "mirror= ://apache/xalan/xalan-j/source/xalan-j_"
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (string-replace-substring
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 version "." "_")
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 "-src.tar.gz"))
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (sha256
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (base32 "166vg9i11qzi= 0vbv09abfb50q8caq8wr6zrwg0cwqws9k394l62w"))
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (modules '((guix build utils= )))
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (snippet '(begin
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; Removing bundled jars
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (for-each
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (lambda (f)
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (delete-file f))<= br> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (find-files "." &qu= ot;\\.(jar|tar\\.gz)$"))))))

Can be simplified to:

=C2=A0 =C2=A0 (snippet '(for-each delete-file (delete-files ".&quo= t; "\\.(jar|tar\\.gz)$")))

Also, xalan-j_2_7_2/samples/AppletXMLtoHTML/rabbitwhorn.jpg is an (uncolour= ed)
picture of a rabbit from Alice in Wonderland (not asl2.0).=C2=A0 According = to
<https://commons.wikimedia.o= rg/wiki/File:Alice_par_John_Tenniel_37.png>,
the copyright has been expired.=C2=A0 As such, perhaps the 'license'= ; field
needs to be changed to

=C2=A0 (license (list license:asl2.0 ; almost everything
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; samples/Ap= pletXMLtoHTML/rabbitwhorn.jpg, according to
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; <https://commons.wikimedia.org/wiki/Fi= le:Alice_par_John_Tenniel_37.png>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0license:publi= c-domain))

Aside from that, LGTM.=C2=A0 I've been reading the source code, not see= ing anything
=E2=80=98suspicous=E2=80=99 (malware etc.) so far (I'm currently at
xalan-j_2_7_2/src/org/apache/xalan/templates/FuncKey.java, 25%).

Greetings,
Maxime.
--00000000000013548c05da842fa9--