From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YGnKFpVQo2LxJwAAbAwnHQ (envelope-from ) for ; Fri, 10 Jun 2022 16:09:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id cLTEFpVQo2IAEQEAauVa8A (envelope-from ) for ; Fri, 10 Jun 2022 16:09:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D13E43A77B for ; Fri, 10 Jun 2022 16:09:24 +0200 (CEST) Received: from localhost ([::1]:42900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzfKF-00080e-VD for larch@yhetil.org; Fri, 10 Jun 2022 10:09:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzfG5-0003qB-GW for guix-patches@gnu.org; Fri, 10 Jun 2022 10:05:09 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57033) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzfG2-0005Sq-62 for guix-patches@gnu.org; Fri, 10 Jun 2022 10:05:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzfG1-0008Kl-UI for guix-patches@gnu.org; Fri, 10 Jun 2022 10:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55874] [PATCH] Add timewarrior 1.4.3 Resent-From: Zac Berkowitz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 10 Jun 2022 14:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55874 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55874@debbugs.gnu.org Received: via spool by 55874-submit@debbugs.gnu.org id=B55874.165486986331986 (code B ref 55874); Fri, 10 Jun 2022 14:05:01 +0000 Received: (at 55874) by debbugs.gnu.org; 10 Jun 2022 14:04:23 +0000 Received: from localhost ([127.0.0.1]:50930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzfFO-0008Jq-Tc for submit@debbugs.gnu.org; Fri, 10 Jun 2022 10:04:23 -0400 Received: from mail-il1-f169.google.com ([209.85.166.169]:40653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzfFL-0008Jb-5H for 55874@debbugs.gnu.org; Fri, 10 Jun 2022 10:04:22 -0400 Received: by mail-il1-f169.google.com with SMTP id h18so20980968ilj.7 for <55874@debbugs.gnu.org>; Fri, 10 Jun 2022 07:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rGRIwL1j8PIiMEyQT5mcDF46Kg6asVyniYzvbdklTr4=; b=Ml3SM7gbpa5AXtdMDB9aD2sltjPSi9Ct3NyZF3wPkQWLbO1S/cToXJ0vTk5wn0Hat9 V2K9C5W7kaF/ZYJqu+9rPmQ1QwriNbY989LqC/E7R/O5F9R1dFU6OZUmNKBI0ISqSdCy vTouJdVqNJIYBWbiU31ogLlULlwnUDI3aHmzY7XHLGnspE6dfENXwXadzmdydF79vyI1 2UjOHj2fxjQQfYlQyWOF7Oh9NE1O3QL/JBHZBkk9+26+RJonznAGGrv7AIwPNUk5LDIc 89knKgEzhXlLLWGI3eNMcTp9hYBsthXVClz2EOPv1nrZ54ieT6+G2HKDMkZfQ//kT8Lx 9KGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rGRIwL1j8PIiMEyQT5mcDF46Kg6asVyniYzvbdklTr4=; b=YAb0erjAcXuqaJznC13sizEjBNksaZWYNwVRZjLpABN111zsLNNIYCJPCWH3KaXNtO nm2L9BnGabxFZ0M2Caup8f+gpVWNmnvV5hOnV8rUnxB+fzdOOZy40dquexwzpD47Nffy YQavsXEP3oszAvawAmsQmXQtY5cbkgN4xE37Ij+XtkZSZch1bUrISGe0cf1iZ+pygnZS qkkH2bhPT5PY09WOWGnOAeUUjzwtXn5dt/ejJF8apK5anXXJr05woHuoeNAfe7jkkZ3U jsEt4siHzn3WKZRUt1SSQXhEFKrfthKFBBUCcqEDhSB8ds1XFzgIqyBgBIesApywOiih vv4w== X-Gm-Message-State: AOAM530gUovDLbS47NJcR0POmYaJVyjayarhzHMHodGc7qYf5WuiFTeZ UqYygStGJrIpOp5CoMUufDrJIc/0XZmuepOt/4E= X-Google-Smtp-Source: ABdhPJx8CExJfYrFve377u2+OTdBJpeEM4eAQHqpWBoR1IHXfMEBfzKdwkK0OM6pfFG4KF1Cr+rjnln/ZxsSS1LxI0M= X-Received: by 2002:a05:6e02:174c:b0:2d3:c1e2:36fe with SMTP id y12-20020a056e02174c00b002d3c1e236femr27480430ill.121.1654869853263; Fri, 10 Jun 2022 07:04:13 -0700 (PDT) MIME-Version: 1.0 References: <56ba51f3df6a70e78518630ad45c3dfc07fdd2a9.camel@telenet.be> In-Reply-To: From: Zac Berkowitz Date: Fri, 10 Jun 2022 10:04:02 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654870165; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=rGRIwL1j8PIiMEyQT5mcDF46Kg6asVyniYzvbdklTr4=; b=MSzfsbqYOo4X6IgM+qRnuY9c/pzXGtiqrBqEBRQA2IcuYkSuphQeMHpJoKZQ/w09ffyLYF 8YYdSyNWHgELatvZ3B43Z+oawXFy1QB1ynk5vayuBNqaMFVJoCVnNb5qjIrCzk0MP3+slu //xS20mMjFjoNYioCoWvjTbB2EQNZFAlBXO5PISqDSjMP5tpe4Cdfg9EH3rLav7B34hq5M fteOt9jqu6O3rvmAGAVecHZbUvnBRpyIgPJKqN7zhhWqlau/XqaJdAK04vC+KQsUJXsT98 cbzD+0dQJ+ePZ4KaCkwe/VQbA5fnw6GFvsmbmwy5WNflpj/i34WCP1YUpiLUDg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654870165; a=rsa-sha256; cv=none; b=axqmKGMeHigXPnB7IYz1+xMbop5o0NHOTjsR1/Zg+M2ThK2P4gaaDLPlHOY3Ea5AhDQtIC YAv9eEFoxXMjKTvtX1zBEgtxdvaQpqECELvDjiGu2zHWz80tuu+03iD7jelP7QPZjp9ODg LrU+YWNimABVr/2BGQtp7sFnFDdxcVEtA+rHD5/a6rgT5KEoBtFyn6ffrLFHhwtzsgVf2y djBoCvgN9ZnkiuQ6nxS6ILCAcwQbtai17FoXdO7v7W3Ez/H44MDJovkePW5UwO5l4vlhpm 1x1FKn57Ph+HmeIVhJSCsbAc8vgqpC5FQwtHGUkzUC0yioCIdoQRGQgp/LeEpA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Ml3SM7gb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.52 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Ml3SM7gb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D13E43A77B X-Spam-Score: 7.52 X-Migadu-Scanner: scn1.migadu.com X-TUID: nZmIMR6lTozc Maxime, Ended up having a bit of time today to look through what you brought up. Thanks again for it! >> + (native-inputs >> + `(("ruby-asciidoctor" ,ruby-asciidoctor) >> + ("python" ,python))) > > According to Debian, additional (native-)inputs are required: > > https://salsa.debian.org/tasktools-team/timew/-/blob/master/debian/tests/control > > Are the tests actually run and can the man page be read? According to the source (https://github.com/GothenburgBitFactory/timewarrior/blob/develop/INSTALL) asciidoctor is required to build the docs, but python is not a requirement at runtime. I'm able to run the timew executable in a pure shell without moving python to the input list, so this seems to be a debian issue? The python scripts in ext/ are completely optional according to the README in that same directory. Like taskwarrior, timewarrior can execute python scripts as hooks in response to various commands, but they're not necessary for base use. Maybe this is why debian adds the python requirement? So hooks just work out of the box? How does guix deal with optional dependencies like this? Tests are run and pass, but that doesn't rule out determinism issues, I'll see what debian did to address that. man pages are not available, I'll correct that. >> + (native-inputs >> + `(("ruby-asciidoctor" ,ruby-asciidoctor) >> + ("python" ,python))) >> + (inputs >> + `(("gnutls" ,gnutls) >> + ("util-linux:lib" ,util-linux "lib"))) > > Nowadays, these can be simplified to. > > (native-inputs (list ruby-asciidoctor python)) > > Where did you learn about the old form? Wouldn't say "learn" - I'm very new to lisps! The code here is mostly adapted from taskwarrior (same developer) and other snippets from gnu/packages. I'm sure I grep'd for another package that required asciidoctor and adapted their portion of the code. >>+ (delete 'install-license-files) ; Already installed by >> package > > Not a problem I think -- at worst, the license file will appear twice, > but identical files are automatically deduplicated, and even if not, they > are relatively small files anyway. This is from taskwarrior from the same developer and has a similar build setup. Seems like both packages should be consistent, but I'm happy to remove this directive if needed. >> + (substitute* "src/commands/CMakeLists.txt" >> + (("/bin/sh") (which "sh")))))))) > > In this context, (which "sh") can maybe be simplified to just "sh", not > that it really matters. Ok. On Fri, Jun 10, 2022 at 3:49 AM Maxime Devos wrote: > > Zac Berkowitz schreef op do 09-06-2022 om 21:36 [-0400]: > > Maxime, > > > > Thanks for all of the great feedback -- seems like "works for me" > > wasn't nearly good enough in this case! I'll chip away at these > > issues next week when I've got some time. Is submitting a new patch > > on this bug # the best way forward? Or should I close this and open a > > new patch issue when it's ready? > > Send it as a v2 to 55874@, then all the relevant information is kept > together at . > > Greetings, > Maxime.