unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Joe Hillenbrand <joehillen@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: rekado@elephly.net, 32933@debbugs.gnu.org
Subject: [bug#32933] [PATCH] guix: add license prefix hackage imports
Date: Fri, 12 Oct 2018 10:55:30 -0700	[thread overview]
Message-ID: <CANJQ5C5PfMfM4dduVEiqnT36x_9ZpCQKN7DZtWGr2UHYA3EWDA@mail.gmail.com> (raw)
In-Reply-To: <87h8hri9sj.fsf@gnu.org>

Sorry, I meant to add justification in the commit message, but apparently I
forgot.

The motivation was to be consistent with the `gnu/packages/haskell.scm` which
uses the `license:` prefix. I noticed this when I imported a bunch of packages
and all of them were missing the prefix, which then had to be manually added.

On Fri, Oct 12, 2018 at 6:17 AM Ludovic Courtès <ludo@gnu.org> wrote:
>
> No strong opinion, but apparently none of the importers currently adds
> the ‘license:’ prefix and I’d rather keep that consistent, one way or
> another.

That's not entirely true. crate calls `spdx-string->license` which adds the
prefix, but it doesn't appear to actually work because it looks for the license
in the wrong part of the json output from crates.io.

I'd be happy to add it to the other importers as it looks like almost all of
`gnu/packages/*.scm` has the `license:` prefix. If so, should I do them all
in a new patch?

Thanks,
Joe

  reply	other threads:[~2018-10-12 17:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 16:17 [bug#32933] [PATCH] guix: add license prefix hackage imports Joe Hillenbrand
2018-10-12 13:17 ` Ludovic Courtès
2018-10-12 17:55   ` Joe Hillenbrand [this message]
2018-10-12 20:31     ` Ricardo Wurmus
2018-10-15  8:07       ` Ludovic Courtès
2018-10-15  9:47         ` Ricardo Wurmus
2018-10-15 13:42           ` Joe Hillenbrand
2018-10-15 13:47             ` Ricardo Wurmus
2021-12-21 17:18 ` bug#32933: " Xinglu Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANJQ5C5PfMfM4dduVEiqnT36x_9ZpCQKN7DZtWGr2UHYA3EWDA@mail.gmail.com \
    --to=joehillen@gmail.com \
    --cc=32933@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).