From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJ8HH-0000sv-4H for guix-patches@gnu.org; Sun, 26 Nov 2017 20:32:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJ8HC-0005mI-CJ for guix-patches@gnu.org; Sun, 26 Nov 2017 20:32:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:51131) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJ8HC-0005m6-7m for guix-patches@gnu.org; Sun, 26 Nov 2017 20:32:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eJ8HB-0005iP-U5 for guix-patches@gnu.org; Sun, 26 Nov 2017 20:32:01 -0500 Subject: [bug#29301] Fwd: [bug#29301] [PATCH] substitute* hard-coded paths with paths from "out" Resent-Message-ID: MIME-Version: 1.0 In-Reply-To: References: <8760accpzl.fsf@gmail.com> <87shd4odvl.fsf@gnu.org> From: Kristofer Buffington Date: Sun, 26 Nov 2017 20:31:52 -0500 Message-ID: Content-Type: multipart/alternative; boundary="001a114b14a2fb3783055eecdd48" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 29301@debbugs.gnu.org --001a114b14a2fb3783055eecdd48 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ---------- Forwarded message ---------- From: Kristofer Buffington Date: Sun, Nov 26, 2017 at 8:30 PM Subject: Re: [bug#29301] [PATCH] substitute* hard-coded paths with paths from "out" To: Ludovic Court=C3=A8s I will investigate. There are some hard coded paths in artanis/config.scm looking for the configuration file in /etc/artanis/artanis.conf -- I don't believe the --sysconfdir flag will have any impact on the hard-coded paths. Perhaps I should send a patch upstream to eliminate the hard paths? Then the substitute* would be unnecessary? Thanks! Kris On Thu, Nov 23, 2017 at 4:59 PM, Ludovic Court=C3=A8s wrote: > Hi Kristofer, > > Kristofer Buffington skribis: > > > * gnu/packages/guile.scm > > used substitute* to correct some hardcoded paths in the artanis package > > [...] > > > + (substitute* "artanis/config.scm" > > + (("/etc/artanis/artanis.conf") > > + (string-append out "/etc/artanis.conf")) > > + (("/etc/artanis/pages") > > + (string-append out "/etc/artanis"))) > > + (substitute* "etc/artanis/artanis.conf" > > + (("/etc/artanis/pages") > > + (string-append out "/etc/artanis"))) > > Shouldn=E2=80=99t we instead configure it with --sysconfdir=3D/etc? That= would > allow users to provide custom configuration files, whereas currently > OUTPUT/etc/artanis contains immutable configuration files. > > WDYT? > > Thanks, > Ludo=E2=80=99. > --001a114b14a2fb3783055eecdd48 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

---------- Forwarded messag= e ----------
From: Kristofer Buffington <kr= istoferbuffington@gmail.com>
Date: Sun, Nov 26, 2017 at 8:= 30 PM
Subject: Re: [bug#29301] [PATCH] substitute* hard-coded paths with= paths from "out"
To: Ludovic Court=C3=A8s <ludo@gnu.org>


I wi= ll investigate. There are some hard coded paths in artanis/config.scm looki= ng for the configuration file in /etc/artanis/artanis.conf -- I don't b= elieve the --sysconfdir flag will have any impact on the hard-coded paths. = Perhaps I should send a patch upstream to eliminate the hard paths? Then th= e substitute* would be unnecessary?

Thanks!
Kris

On Thu, Nov 23, 2017 at 4:59 PM= , Ludovic Court=C3=A8s <ludo@gnu.org> wrote:
Hi Kristofer,

Kristofer Buffington <kristoferbuffington@gmail.com> skribis:

> * gnu/packages/guile.scm
> used substitute* to correct some hardcoded paths in the artanis packag= e

[...]

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(substi= tute* "artanis/config.scm"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (("/etc/artanis/artanis.conf")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (string-append out "/etc/artanis.conf"))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (("/etc/artanis/pages")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (string-append out "/etc/artanis")))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(substi= tute* "etc/artanis/artanis.conf"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (("/etc/artanis/pages")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (string-append out "/etc/artanis")))

Shouldn=E2=80=99t we instead configure it with --sysconfdir=3D/etc?= =C2=A0 That would
allow users to provide custom configuration files, whereas currently
OUTPUT/etc/artanis contains immutable configuration files.

WDYT?

Thanks,
Ludo=E2=80=99.


--001a114b14a2fb3783055eecdd48--