unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#74644] [PATCH] Update SwayFX version to 0.4
@ 2024-12-02  8:38 Josep Bigorra
  2024-12-05 21:35 ` Rodion Goritskov
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Josep Bigorra @ 2024-12-02  8:38 UTC (permalink / raw)
  To: 74644

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

Hi all, after having added the scenefx dependency, now we can update
to SwayFX 0.4 ! :D

Here is a patch for that, I hope I didn't miss anything.

Regards,
Joe

[-- Attachment #2: 0001-update-swayfx-version-to-0.4.patch --]
[-- Type: text/x-patch, Size: 1558 bytes --]

From b32067ee9de094541980bfac157872c73c1ace43 Mon Sep 17 00:00:00 2001
Message-ID: <b32067ee9de094541980bfac157872c73c1ace43.1733128178.git.jjbigorra@gmail.com>
From: Josep Bigorra <jjbigorra@gmail.com>
Date: Mon, 2 Dec 2024 09:28:56 +0100
Subject: [PATCH] update swayfx version to 0.4

---
 gnu/packages/wm.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 2ab6f88cd5..f7bb77c23c 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1960,7 +1960,7 @@ (define-public swayfx
   (package
     (inherit sway)
     (name "swayfx")
-    (version "0.3.2")
+    (version "0.4")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -1969,7 +1969,7 @@ (define-public swayfx
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "13d8icd45j937jgkidr7cyjys4nnvxh4ilp7ml0i2ml39ipv01qv"))))
+                "0651gbkszc8wwkiiw983m3815cfyk4c9v4mpd1nqf27a0f6qjgsm"))))
     (build-system meson-build-system)
     (inputs (list basu
                   cairo
@@ -1980,9 +1980,10 @@ (define-public swayfx
                   libxkbcommon
                   pango
                   pcre2
+                  scenefx
                   swaybg
                   wayland
-                  wlroots-0.16))
+                  wlroots-0.17))
     (home-page "https://github.com/WillPower3309/swayfx")
     (synopsis "Sway Fork with extra options and effects")
     (description
-- 
2.46.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#74644] [PATCH] Update SwayFX version to 0.4
  2024-12-02  8:38 [bug#74644] [PATCH] Update SwayFX version to 0.4 Josep Bigorra
@ 2024-12-05 21:35 ` Rodion Goritskov
  2024-12-09 10:56 ` [bug#74644] SwayFX Josep Bigorra
  2024-12-11  1:32 ` bug#74644: [PATCH] Update SwayFX version to 0.4 Hilton Chain
  2 siblings, 0 replies; 4+ messages in thread
From: Rodion Goritskov @ 2024-12-05 21:35 UTC (permalink / raw)
  To: 74644; +Cc: Josep Bigorra


Hi!

Patch applies, SwayFX builds and starts successfully.
Haven't tested SwayFX-specific functionality, but it starts and manages
windows just fine.

The only thing that (as I think) could be changed in this patch is
commit message.

Currently it has the whole cover letter in commit message, while it
could be something like this (according to the usual commit format in
this repo):

> gnu: swayfx: Update to 0.4.
>
> * gnu/packages/wm.scm (swayfx): Update to 0.4.

Thank you for the patch, wanted to take a look on actual SwayFX for some time!




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#74644] SwayFX
  2024-12-02  8:38 [bug#74644] [PATCH] Update SwayFX version to 0.4 Josep Bigorra
  2024-12-05 21:35 ` Rodion Goritskov
@ 2024-12-09 10:56 ` Josep Bigorra
  2024-12-11  1:32 ` bug#74644: [PATCH] Update SwayFX version to 0.4 Hilton Chain
  2 siblings, 0 replies; 4+ messages in thread
From: Josep Bigorra @ 2024-12-09 10:56 UTC (permalink / raw)
  To: 74644

Hi Rodion, I am happy to see your answer.
I am daily driving this for a few days, with nice stability, more so than 0.3
I hope we can merge it in soon to upstream :)

I am confused about your mention of the commit message.
I am unexperienced with patches, so bear with me. My commit message
was real short as I remember, and opening the patch i see no commit
message.
Is there a way you could fix this one, before merging in?

Thanks in advance,
Regards




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#74644: [PATCH] Update SwayFX version to 0.4
  2024-12-02  8:38 [bug#74644] [PATCH] Update SwayFX version to 0.4 Josep Bigorra
  2024-12-05 21:35 ` Rodion Goritskov
  2024-12-09 10:56 ` [bug#74644] SwayFX Josep Bigorra
@ 2024-12-11  1:32 ` Hilton Chain
  2 siblings, 0 replies; 4+ messages in thread
From: Hilton Chain @ 2024-12-11  1:32 UTC (permalink / raw)
  To: Josep Bigorra; +Cc: 74644-done

Hi Josep,

On Mon, 02 Dec 2024 16:38:44 +0800,
Josep Bigorra wrote:
>
> [1  <text/plain; UTF-8 (7bit)>]
> Hi all, after having added the scenefx dependency, now we can update
> to SwayFX 0.4 ! :D
>
> Here is a patch for that, I hope I didn't miss anything.
>
> Regards,
> Joe
> [2 0001-update-swayfx-version-to-0.4.patch <text/x-patch; US-ASCII (base64)>]
> From b32067ee9de094541980bfac157872c73c1ace43 Mon Sep 17 00:00:00 2001
> Message-ID: <b32067ee9de094541980bfac157872c73c1ace43.1733128178.git.jjbigorra@gmail.com>
> From: Josep Bigorra <jjbigorra@gmail.com>
> Date: Mon, 2 Dec 2024 09:28:56 +0100
> Subject: [PATCH] update swayfx version to 0.4
>
> ---
>  gnu/packages/wm.scm | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Added changelog to commit message and applied as
e24adc3bdf7cfeacc6aa7788d4a8292df425f6b2, thanks!




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-12-11  1:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-02  8:38 [bug#74644] [PATCH] Update SwayFX version to 0.4 Josep Bigorra
2024-12-05 21:35 ` Rodion Goritskov
2024-12-09 10:56 ` [bug#74644] SwayFX Josep Bigorra
2024-12-11  1:32 ` bug#74644: [PATCH] Update SwayFX version to 0.4 Hilton Chain

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).