unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Filip Lajszczak <filip@lajszczak.dev>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 48289@debbugs.gnu.org
Subject: [bug#48289] [PATCH] gnu: Add python-pythonanywhere.
Date: Sun, 9 May 2021 14:06:42 +0100	[thread overview]
Message-ID: <CAKk7972xs6cTWOU=2REiMC1SAMfxnDWCtaVx0K-fM-1eNdYtgQ@mail.gmail.com> (raw)
In-Reply-To: <864b6bb2288824630d6e28d01c22617443c1e5b8.camel@telenet.be>

On Sat, 8 May 2021 at 22:16, Maxime Devos <maximedevos@telenet.be> wrote:
> Phases do not need to return #t anymore; the warning you get if you
> remove it is misleading.  The warning will disappear once core-updates
> is merged.

Good to know!

>
> > +      (replace 'check
> > +       (lambda _
> > +        (invoke "pytest" "-m" "not slowtest") #t)))))
>
> To support "guix build --without-tests" and cross-compilation, make this
>
> > +      (replace 'check
> > +       (lambda* (#:key tests? #:allow-other-keys)
> > +        (when tests?
> > +         (invoke "pytest" "-m" "not slowtest"))))
>

Thanks for the review! I'm about to post a new version of the patch.

All the best,
Filip




  reply	other threads:[~2021-05-09 13:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-08 13:28 [bug#48289] [PATCH] gnu: Add python-pythonanywhere Filip Lajszczak
2021-05-08 21:16 ` Maxime Devos
2021-05-09 13:06   ` Filip Lajszczak [this message]
2021-05-09 13:09 ` Filip Lajszczak
2021-12-17 23:08 ` Filip Lajszczak
2022-01-03 16:34   ` bug#48289: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKk7972xs6cTWOU=2REiMC1SAMfxnDWCtaVx0K-fM-1eNdYtgQ@mail.gmail.com' \
    --to=filip@lajszczak.dev \
    --cc=48289@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).