unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: John Soo <jsoo1@asu.edu>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 37038@debbugs.gnu.org
Subject: [bug#37038] Amending author email
Date: Wed, 28 Aug 2019 05:05:20 +0000	[thread overview]
Message-ID: <CAKf5CqXbXgSkxA3pzPmKyd0BtexWhbEyiKz9kyYFbuJtBaDG7g@mail.gmail.com> (raw)
In-Reply-To: <87tva2kznr.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2749 bytes --]

> Applied with a followup commit to address ‘guix lint’ warnings.

Thank you! I was unsure what to do about those lint errors. I updated
cedille with the proper fetch to fix the lint issues with it.

>  Also, it fails to build for me

I included a second patch to fix the build issue. It looks like this line
in the Makefile would cause this problem:

./ial/ial.agda-lib:
git submodule update --init --recursive


> > From 22ff16058b7b43622beaca1742b9520fb987310c Mon Sep 17 00:00:00 2001
> > From: John Soo <jsoo1@asu.edu>
> > Date: Mon, 12 Aug 2019 08:43:07 -0700
> > Subject: [PATCH 2/2] gnu: Add cedille.
> >
> > * gnu/packages/cedille.scm: new file.
> > * gnu/packages/cedille.scm (cedille): new variable.
>
> Could you (1) add this file to gnu/local.mk, and (2) address the
> remaining ‘guix lint’ warnings?
>
>
> --8<---------------cut here---------------start------------->8---
> make[1]: Leaving directory
> '/tmp/guix-build-cedille-1.1.1.drv-0/cedille-1.1.1/core'
> git submodule update --init --recursive
> fatal: not a git repository (or any of the parent directories): .git
> make: *** [Makefile:102: ial/ial.agda-lib] Error 128
> --8<---------------cut here---------------end--------------->8---
>
>
> [...]
>
> > +           (lambda* (#:key outputs #:allow-other-keys)
> > +             (let* ((out (assoc-ref outputs "out"))
> > +                    (cedille-site-lisp
> > +                     (string-append
> > +                      out "/share/emacs/site-lisp/guix.d/cedille-"
> > +                      ,version "/")))
>
> To aid readability, I’d call the variable just ’lisp’; long names aren’t
> helpful for local variables IMO.
>
> > +         ;; Byte compilation fails
> > +         (delete 'build)
>
> Should it be a FIXME?
>
> > +    (synopsis
> > +     (string-append
> > +      "Language based on Calculus of Dependent Lambda Eliminations"))
>
> ‘string-append’ is unnecessary.
>
> > +    (description
> > +     "Cedille is an interactive theorem-prover and dependently
> > +typed programming language, based on extrinsic (aka Curry-style)
> > +type theory.  This makes it rather different from type theories
> > +like Coq and Agda, which are intrinsic (aka Church-style).  In
> > +Cedille, terms are nothing more than annotated versions of terms
> > +of pure untyped lambda calculus.  In contrast, in Coq or Agda,
> > +the typing annotations are intrinsic parts of terms.  The typing
> > +annotations can only be erased as an optimization under certain
> > +conditions, not by virtue of the definition of the type theory.")
>
> M-q here if you use Emacs.  :-)
>
> Could you send an updated patch?
>
> Thanks,
> Ludo’.
>

[-- Attachment #2: Type: text/html, Size: 3580 bytes --]

  reply	other threads:[~2019-08-28  5:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15 16:07 [bug#37038] [PATCH] Add Cedille John Soo
2019-08-16  3:16 ` [bug#37038] Amending author email John Soo
2019-08-27 22:32   ` Ludovic Courtès
2019-08-28  5:05     ` John Soo [this message]
2019-08-28  5:11       ` John Soo
2019-08-28  5:17         ` John Soo
2019-08-28  5:23         ` Ricardo Wurmus
2019-08-28  6:21           ` John Soo
2019-08-28 15:10             ` John Soo
2019-08-28 15:48             ` bug#37038: " Ludovic Courtès
2019-08-28 17:00               ` [bug#37038] " John Soo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKf5CqXbXgSkxA3pzPmKyd0BtexWhbEyiKz9kyYFbuJtBaDG7g@mail.gmail.com \
    --to=jsoo1@asu.edu \
    --cc=37038@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).