Em qua., 17 de mar. de 2021 às 16:31, Efraim Flashner
<efraim@flashner.co.il> escreveu:
> Thanks. Some inlined comments.

Okay. You may find a new version of the patch attached.

> > * gnu/packages/lua.scm (emilua): Update to 0.3.0.
>
> The other changes should be listed here. For example
> [search-paths]: New field.

Fixed.

> > +      '("-Denable_http=true" "-Denable_tests=false" "-Dversion_suffix=-guix1")))
>
> Why are we adding '-guix1' as a version suffix?

$ emilua --version
Emilua 0.3.0-guix1

That's the only difference. When people fill bug reports, it'll make
it easy to identify which platform they're using.

> >     (native-inputs
> > -    `(("gcc" ,gcc-10) ; gcc-7 is too old for our C++17 needs
> > +    `(("asciidoctor" ,ruby-asciidoctor)
>
> If possible I'd prefer to not pull in ruby-asciidoctor, it pulls in
> pandoc, which will limit this package to GHC supported systems only, ie
> x86_64 and i686.

You sure about that? I failed to follow the dependencies track to pandoc.

In any case, asciidoctor is only used to build the manpages (and it
doesn't need pandoc here) and it'd be okay to cross-build. Also
manpage generation can be disabled easily with the flag
-Denable_manpages=false if desired. What's your call?

> > +      ("fmt" ,fmt)
>
> You'll also need to import pretty-print at the top of the file.

My bad. Fixed.

> > +   (native-search-paths
> > +    (list (search-path-specification
> > +           (variable "EMILUA_PATH")
> > +           (files '("lib/emilua-0.3")))))
>
> this can be (list (string-append "/lib/emilua-"
>             (version-major+minor version)))

Fixed.


--
Vinícius dos Santos Oliveira
https://vinipsmaker.github.io/