will do.

On Thu, Sep 14, 2023 at 2:42 PM Ludovic Courtès <ludo@gnu.org> wrote:

> Hi,
>
> Andy Tai <atai@atai.org> skribis:
>
> > * gnu/packages/machine-learning.scm: (tensorflow-lite):
> > Update to 2.13.0
> > [inputs]: Add gemmlowp
> > [native-inputs]: Remove gemmlowp-src
> > *
> gnu/packages/patches/tensorflow-lite-disable-local-cmake-3rdparty-components.patch:
> > New file
>
> Overall LGTM.  Some comments…
>
> Could you add the patch to ‘gnu/local.mk’?
>
> > +       (patches
> > +               (search-patches
> > +                ;; patch to disable local cmake build code for 3rdparty
> > +                ;; componentas
> > +
> "tensorflow-lite-disable-local-cmake-3rdparty-components.patch"))))
>
> Please add the comment at the top of the patch itself, as reported by
> ‘guix lint’; also adjust indentation here as in the other files.
>
> > +         (string-append "-Dgemmlowp_ROOT=" #$(this-package-input
> "gemmlowp"))
> > +         )
>
> Please move paren to the previous line.
>
> >                  (invoke "tar" "--strip-components=1"
> >                          "-xf" (assoc-ref inputs "fft2d-src")))
> >
> > -              (copy-recursively (assoc-ref inputs "gemmlowp-src")
> > -                                "/tmp/gemmlowp/")))
> > +              ;(copy-recursively (assoc-ref inputs "gemmlowp-src")
> > +              ;                  "/tmp/gemmlowp/")
> > +
> > +              ))
>
> Leftover?  You can remove these two lines.
>
> Could you send an updated patch?
>
> Thanks in advance,
> Ludo’.
>


-- 
Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat:
andytai1010
Year 2023 民國112年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能